[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 Adam Miller changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|---

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 Adam Miller changed: What|Removed |Added Summary|Review Request: |Review Request: |ython-

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 Athos Ribeiro changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #1 from Athos Ribeiro --- Hello Adam, I am taking this review. - The package files (consumer.py and __init__.py) were not packaged at all - Upstream setup.py version reads 0.0.1 while package version tag reads 0.0.2 - The descr

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #2 from Adam Miller --- I've fixed all but the last comment, I don't know what you meant by "It would be nice to have the python2- subpackage Requires: under the python2 subpackage itself" Spec URL: https://maxamillion.fedorapeopl

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #3 from Athos Ribeiro --- Hi Adam, Thanks for the changes! > I've fixed all but the last comment, I don't know what you meant by "It > would be nice to have the python2- subpackage Requires: under the python2 > subpackage itself"

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #4 from Athos Ribeiro --- - Actually, you do need to include the requires under the python2 subpackage (the ones you do not need to move there are the BRs): $ rpm -qp --requires python2-fedmsg-rabbitmq-serializer-0.0.5-1.fc27.no

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #5 from Adam Miller --- Just to be clear, are you waiting on anything or is this approved? I wasn't certain. Thanks! :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about c

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #6 from Athos Ribeiro --- Created attachment 1279834 --> https://bugzilla.redhat.com/attachment.cgi?id=1279834&action=edit Fix python2 subpackage Requires > - Actually, you do need to include the requires under the python2 subpa

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #7 from Adam Miller --- A ok, sorry. I misunderstood. I'll fix up the nice to haves also. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this p

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #8 from Adam Miller --- Spec URL: https://maxamillion.fedorapeople.org/python-fedmsg-rabbitmq-serializer.spec SRPM URL: https://maxamillion.fedorapeople.org/python-fedmsg-rabbitmq-serializer-0.0.5-2.fc27.src.rpm -- You are receiv

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 Athos Ribeiro changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from At

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #10 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-fedmsg-rabbitmq-serializer -- You are receiving this mail because: You are on the CC list for the bug. You are