[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

2017-06-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1460662 Jun Aruga changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

2017-06-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1460662 --- Comment #6 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-mustermann -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

2017-06-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1460662 Vít Ondruch changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

2017-06-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1460662 --- Comment #4 from Jun Aruga --- Vit, thank you for the review. I fixed those items that you mentioned. 1 point. > ~~~ > %setup -q -D -T -n %{gem_name}-%{version} -b1 -b2 > ~~~ Below "-b n" looks better regarding the

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

2017-06-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1460662 --- Comment #3 from Vít Ondruch --- BTW there appears to be circular dependency with Sinatra, you should consider to prepare Mustermann for bootstrap. -- You are receiving this mail because: You are on the CC list for

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

2017-06-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1460662 --- Comment #2 from Vít Ondruch --- * Summary/Description - I'd say that the summary is misleading. The original (but capitalized) would be better IMHO. - The description should start with capital letter. * Group

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

2017-06-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1460662 Vít Ondruch changed: What|Removed |Added Status|NEW |ASSIGNED