https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Bug 1463492 depends on bug 1484795, which changed state.
Bug 1484795 Summary: Review Request: golang-github-mattn-go-getopt - getopt for
golang
https://bugzilla.redhat.com/show_bug.cgi?id=1484795
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Tomofumi Hayashi changed:
What|Removed |Added
Flags|needinfo?(s1061...@gmail.co |
|m)
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Tomofumi Hayashi changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Athos Ribeiro changed:
What|Removed |Added
Flags|needinfo?(athoscribeiro@gma |needinfo?(s1061...@gmail.co
Product: Fedora
Version: rawhide
Component: Package Review
Athos Ribeiro has canceled Package Review
's request for Athos Ribeiro
's needinfo:
Bug 1463492: Review Request: koko - container connector
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #28 from Ath
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Jan Chaloupka changed:
What|Removed |Added
Flags|needinfo?(jchaloup@redhat.c |
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #26 from s1061...@gmail.com ---
Thank you Jan for your comments and explanation about undocumented guideline
because I can only read documented rules (I hope it will be documented soon).
Koko uses vendoring (i.e. bundling dependent
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
srakitnican changed:
What|Removed |Added
Flags||needinfo?(jchaloup@redhat.c
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
srakitnican changed:
What|Removed |Added
Flags|needinfo?(samuel.rakitnican |
|@gmail.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Jan Chaloupka changed:
What|Removed |Added
Depends On||1484795
--- Comment #24 from Jan Chal
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #23 from s1061...@gmail.com ---
Hi Athos,
Thank you for your review and valuable comments!
I've update spec files as following. This is made by gofed from scratch.
Spec URL: http://s1061123.net/koko/koko_v051a.spec
SRPM URL:
https
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Athos Ribeiro changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedo
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Athos Ribeiro changed:
What|Removed |Added
CC||athoscribe...@gmail.com,
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
s1061...@gmail.com changed:
What|Removed |Added
Flags||needinfo?(samuel.rakitnican
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
srakitnican changed:
What|Removed |Added
Flags|needinfo?(samuel.rakitnican |
|@gmail.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #19 from s1061...@gmail.com ---
(In reply to s1061123 from comment #18)
> Samuel, thank you for your review! I've taken care of it and upload it.
(snip)
> W.r.t github tarball location, I don't change URL because it is default
> se
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
s1061...@gmail.com changed:
What|Removed |Added
Flags||needinfo?(samuel.rakitnican
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
srakitnican changed:
What|Removed |Added
Flags|needinfo?(samuel.rakitnican |
|@gmail.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
s1061...@gmail.com changed:
What|Removed |Added
Flags||needinfo?(samuel.rakitnican
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #16 from s1061...@gmail.com ---
Samuel,
Thank you for your review! Regarding code download from internet, I will take
care of it soon.
But I'm wondering that lint error because all terms are correct words, not
wrong.
1st warning ca
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #15 from srakitnican ---
The newer SPEC file doesn't have changelog entry for the new package release
0.5-1 .
(In reply to Dan Williams from comment #12)
> Samuel, any chance you could look at the latest files? Is there anythin
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #14 from s1061...@gmail.com ---
Hi Dan and Samuel,
Thank you for your clarification about the review!
BTW, upstream releases newer version, hence I upload spec files.
I only modify version in spec file.
Spec URL: http://s1061123.
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
srakitnican changed:
What|Removed |Added
Flags|needinfo?(samuel.rakitnican |
|@gmail.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Dan Williams changed:
What|Removed |Added
Flags||needinfo?(samuel.rakitnican
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #11 from s1061...@gmail.com ---
(In reply to srakitnican from comment #10)
> No sure about (In reply to s1061123 from comment #9)
> > Hi srakitnican,
> >
> > Thank you for your review again!
> >
> > Here is the modified spec/SRPM,
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #10 from srakitnican ---
No sure about (In reply to s1061123 from comment #9)
> Hi srakitnican,
>
> Thank you for your review again!
>
> Here is the modified spec/SRPM, all comments above are taken care of it.
> BTW, I need to ke
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #9 from s1061...@gmail.com ---
Hi srakitnican,
Thank you for your review again!
Here is the modified spec/SRPM, all comments above are taken care of it.
BTW, I need to keep 'git' in its 'BuildRequires:' because 'go get' invokes
gi
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #8 from srakitnican ---
> Also, please make sure that there are no lines in the description longer than
> 80 characters.
https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #7 from srakitnican ---
One more, you must include license file with the package if present with the
sources, see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text
Just add
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #6 from srakitnican ---
You're welcome.
Also think about adding a man page for your command, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #5 from s1061...@gmail.com ---
(In reply to srakitnican from comment #4)
> Just a few comments:
>
> 1. Missing changelog, see:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
> 2. The %defattr directive should not
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
srakitnican changed:
What|Removed |Added
CC||samuel.rakitni...@gmail.com
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #3 from s1061...@gmail.com ---
(In reply to Dan Williams from comment #2)
> At least I'm happy if I'm eligeable to sponsor, it's been a while so I can't
> recall whether I'm a sponsor or not. If i'm not, please disregard...
Thank
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
--- Comment #2 from Dan Williams ---
At least I'm happy if I'm eligeable to sponsor, it's been a while so I can't
recall whether I'm a sponsor or not. If i'm not, please disregard...
--
You are receiving this mail because:
You are on the CC
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
Dan Williams changed:
What|Removed |Added
CC||d...@redhat.com
--- Comment #1 from Da
https://bugzilla.redhat.com/show_bug.cgi?id=1463492
s1061...@gmail.com changed:
What|Removed |Added
Blocks||177841 (FE-NEEDSPONSOR)
Referenc
36 matches
Mail list logo
