[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #30 from Fedora Update System --- dbus-broker-7-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on t

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|---

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #28 from Fedora Update System --- dbus-broker-7-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #27 from Fed

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #25 from Fedora Update System --- dbus-broker-7-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c84cf2fe90 -- You are receiving this mail because: You are on the CC list fo

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #26 from Fedora Update System --- dbus-broker-7-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8d26c7dd5f -- You are receiving this mail because: You are on the CC list fo

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #24 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dbus-broker -- You are receiving this mail because: You are on the CC list for the bug. You are always notifie

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Jan Synacek changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #23 from Jan

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Tom Gundersen changed: What|Removed |Added Flags|needinfo?(tgunders@redhat.c | |om)

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #21 from Tom Gundersen --- Created attachment 1326028 --> https://bugzilla.redhat.com/attachment.cgi?id=1326028&action=edit proposed spec file -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Flags|

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #19 from Jan Synacek --- I can't access those... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Tom Gundersen changed: What|Removed |Added Flags|needinfo?(tgunders@redhat.c | |om)

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Jan Synacek changed: What|Removed |Added Flags||needinfo?(tgunders@redhat.c

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #16 from Tom Gundersen --- Updated %description now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #15 from Zbigniew Jędrzejewski-Szmek --- You should drop the first line in %description — no need to repeat what's already in the summary anyway. Looks good otherwise 👍. -- You are receiving this mail because: You are on the CC

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #14 from Tom Gundersen --- Pushed a release. All comments should be addressed. Thanks for the feedback! Latest spec file: . -- You are receivi

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Jan Synacek changed: What|Removed |Added Flags|needinfo?(jsynacek@redhat.c | |om)

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Igor Gnatenko changed: What|Removed |Added Flags||needinfo?(jsynacek@redhat.c

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #11 from Tom Gundersen --- I'll update to use %meson and pkgconfig(), and resubmit once we have the next upstream release. Thanks for the feedback! -- You are receiving this mail because: You are on the CC list for the bug. You a

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #10 from David Herrmann --- (In reply to Igor Gnatenko from comment #9) > * most likely you want to use pkgconfig(xxx) buildrequires for most of > things, check meson.build True. Tom, can you update those? > * please don't bundle

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Igor Gnatenko changed: What|Removed |Added CC||ignate...@redhat.com --- Comment #9 f

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #8 from Jan Synacek --- Apart from the source problem, all looks fine to me. (In reply to Tom Gundersen from comment #7) > > dbus-broker.src: W: file-size-mismatch dbus-broker-2.tar.gz = 136357, > > https://github.com/bus1/dbus-b

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #7 from Tom Gundersen --- I tried to address all the comments, the only outstanding thing is > dbus-broker.src: W: file-size-mismatch dbus-broker-2.tar.gz = 136357, > https://github.com/bus1/dbus-broker/archive/v2/dbus-broker-2.t

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- > jsynacek: This should be fixed. Please, remove the BuildRequires: gcc from > the spec. That's obsolete advice. gcc must be listed. See https://fedoraproject.org/wiki/Packaging:Guidelines#

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #5 from Jan Synacek --- Thanks for the answers! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Tom Gundersen changed: What|Removed |Added Flags|needinfo?(tgunders@redhat.c | |om)

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Jan Synacek changed: What|Removed |Added CC||tgund...@redhat.com Flags|

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #1 from Jan Synacek --- I'm going to post the entire review output of fedora-review first and then snippets of it that I have found important with embedded comments in it. -- You are receiving this mail because: You are on the CC

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #2 from Jan Synacek --- This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't s

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

https://bugzilla.redhat.com/show_bug.cgi?id=1482202 Jan Synacek changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedora