[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #1 from Jonathan Dieter --- rpmlint output: zchunk.src: W: spelling-error %description -l en_US rsync -> sync, r sync zchunk.src: W: spelling-error %description -l en_US checksums -> check sums, check-sums, checks zchunk.x86_64: W:

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 Jonathan Dieter changed: What|Removed |Added CC||ngomp...@gmail.com Assignee

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 Jonathan Dieter changed: What|Removed |Added Assignee|ignate...@redhat.com|i.gnatenko.br...@gmail.com -- You

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #2 from Neal Gompa --- Please split out the libraries into a separate libs subpackage, so that multilibbing will work correctly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #3 from Jonathan Dieter --- Something like zchunk-libs? Should zchunk-devel be renamed to zchunk-libs-devel? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to th

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #4 from Igor Gna

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #5 from Igor Gnatenko --- So the licensing is complicated here: * It should be BSD and MIT and Public Domain * Provides: bundled(buzhash) = VERSION OF BUZHASH There seems to be some bundled code about multipart parsing... * Provide

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #6 from Igor Gnatenko --- * Source0: https://github.com/zchunk/%{name}/archive/%{version}/%{name}-%{version}.tar.gz You could replace this by Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz * Missing BuildRequi

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #7 from Jonathan Dieter --- (In reply to Igor Gnatenko from comment #5) > So the licensing is complicated here: > * It should be BSD and MIT and Public Domain > * Provides: bundled(buzhash) = VERSION OF BUZHASH I had to modify the

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #8 from Jonathan Dieter --- (In reply to Jonathan Dieter from comment #7) > Having said that, if you feel strongly about this, I will change zchunk so > openssl is an optional dependency, that, if available, will provide the > hash

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #9 from Igor Gnatenko --- (In reply to Jonathan Dieter from comment #7) > (In reply to Igor Gnatenko from comment #5) > > So the licensing is complicated here: > > * It should be BSD and MIT and Public Domain > > * Provides: bundle

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #10 from Jonathan Dieter --- (In reply to Igor Gnatenko from comment #9) > (In reply to Jonathan Dieter from comment #7) > > (In reply to Igor Gnatenko from comment #5) > > > So the licensing is complicated here: > > > * It should

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #11 from Jonathan Dieter --- Updated spec: Spec URL: https://www.jdieter.net/downloads/zchunk/zchunk.spec SRPM URL: https://www.jdieter.net/downloads/zchunk/zchunk-0.7.5-1.fc28.src.rpm -- You are receiving this mail because: You

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #12 from Jonathan Dieter --- Ok, in this updated spec, the only bundled code is buzhash from the urlblock project. It's used to figure out when to automatically end a chunk. There's a new dependency on openssl, and I think I've f

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #13 from Neal Gompa --- > %ldconfig_scriptlets This needs to be `%ldconfig_scriptlets libs` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and co

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #14 from Jonathan Dieter --- (In reply to Neal Gompa from comment #13) > > %ldconfig_scriptlets > > This needs to be `%ldconfig_scriptlets libs` Good catch! Fixed in 0.7.5-2 Spec URL: https://www.jdieter.net/downloads/zchunk/zc

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #15 from Neal Gompa --- (In reply to Jonathan Dieter from comment #14) > (In reply to Neal Gompa from comment #13) > > > %ldconfig_scriptlets > > > > This needs to be `%ldconfig_scriptlets libs` > > Good catch! Fixed in 0.7.5-2

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #16 from Jonathan Dieter --- (In reply to Neal Gompa from comment #15) > You should leave it as devel instead of libs-devel. Otherwise, looks fine to > me. Fixed in 0.7.5-3 Spec URL: https://www.jdieter.net/downloads/zchunk/zchu

[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas

2018-07-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|POST Flags|