[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Martin Pitt changed: What|Removed |Added Status|POST|CLOSED Resolution|---

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #27 from Martin Pitt --- Anthony, the first push needs to happen manually. From then on, the cockpituous bot will do releases automatically. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #26 from Anthony McInerney --- I've added martinpitt as admin and cockpit as commit access. Is the package going to be pushed automagically, or do i grab the srpm and commit it? -- You are receiving this mail because: You are

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #25 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cockpit-composer -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|POST

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #23 from Anthony McInerney --- https://pagure.io/releng/fedora-scm-requests/issue/10279#comment-559461 The review is not approved by the assignee of the Bugzilla bug Metadata Update from @limb: - Issue close_status updated to:

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Miroslav Suchý changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #22 from Miroslav

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #21 from Miroslav Suchý --- > But I suppose that happens at "fedpkg request-repo" time? Yes, or any time later he can go to src.fedoraproject.org/rpms/cockpit-composer click on the settings tab and add anyone as co-maintainer.

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #20 from Martin Pitt --- @Miroslav: Fixed the description in https://github.com/weldr/welder-web/pull/588 , thanks for pointing out! Anthony, Miroslav: We need the "cockpit" Fedora user to be able to push to this dist-git, and

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #19 from Miroslav Suchý --- the %description can be more descriptive. E.g., the first paragraph from README is just fine. And it should end with a dot (you are missing it there).

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Miroslav Suchý changed: What|Removed |Added CC||msu...@redhat.com

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Robert-André Mauchin changed: What|Removed |Added Status|POST|ASSIGNED --- Comment #17 from

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #15 from Martin Pitt --- @Robert: Yes, `-a` implies `-R`. Also this went through CI, which tests the installed rpm, so if it would not copy something important, everything would fail. -- You are receiving this mail because: You

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #14 from Robert-André Mauchin --- (In reply to Martin Pitt from comment #13) > Thanks Robert for the detailled review! > > > - Use "cp -a" or "install -p" to keep file timestamps > > Done in

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #13 from Martin Pitt --- Thanks Robert for the detailled review! > - Use "cp -a" or "install -p" to keep file timestamps Done in https://github.com/weldr/welder-web/pull/587 > - Don't mix tabs and spaces: tabs on line 2 and 3

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Robert-André Mauchin changed: What|Removed |Added Flags|needinfo?(zebo...@gmail.com | |)

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #11 from Martin Pitt --- The tarball gets created here, in "make dist-gzip": Essentially, it calls webpack to produce dist/ from src/, and then puts the original

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #10 from Miro Hrončok --- Getting somebody to review this. (I for example decided not to do so due to the way everything is prebuilt - I don't have time to dedicate to review the process how the tarball is created.) -- You are

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #9 from Martin Pitt --- For the record, all issues found above have been fixed for a month. What is the next step here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #8 from Martin Pitt --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/@weldr/welder-web/fedora-29-x86_64/00857246-cockpit-composer/cockpit-composer.spec SRPM URL:

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Martin Pitt changed: What|Removed |Added Flags||needinfo?(zebo...@gmail.com

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #5 from Miro Hrončok --- I understand that, I'm just pointing out the obvious: This should not be done in Fedora. (Note "should", not "must".) -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #4 from Martin Pitt --- Right, the upstream releases contain pre-built webpacks in dist/. There really is no realistic way to build them as part of a Fedora package build, as it requires internet access (npm install), or shipping

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #3 from Miro Hrončok --- In that case, use: Source0: https://github.com/weldr/welder-web/releases/download/%{version}/cockpit-composer-%{version}.tar.gz Also, it looks like the repository contains sources an the

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 --- Comment #2 from Martin Pitt --- Coming from here: https://github.com/weldr/welder-web/releases -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #1

[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

https://bugzilla.redhat.com/show_bug.cgi?id=1659556 afm...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR)