Product: Fedora
Version: rawhide
Component: Package Review
Package Review has canceled Package
Review 's request for Zuzana Svetlikova
's needinfo:
Bug 1673400: Review Request: nodejs-antora-site-generator-default - The default
site generator pipeline for producing and publishing static
https://bugzilla.redhat.com/show_bug.cgi?id=1673400
--- Comment #7 from Robert-André Mauchin ---
I was told the bundled thingie are automated by nodejs-packaging.
- Use:
Source0:%{fc_name}-%{version}.tgz
Source1:%{fc_name}-tarball.sh
- You need to take into account all
https://bugzilla.redhat.com/show_bug.cgi?id=1673400
--- Comment #6 from Robert-André Mauchin ---
In that case you should add a Provides: bundled(blah) = version-release for
each bundled node modules.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1673400
--- Comment #5 from Zuzana Svetlikova ---
node_modules directory is bundled on purpose (for the sake of maintainability)
and that's also reason why %{nodejs_symlink_deps} is commented out. Only
problem with that is that bundled Provides
https://bugzilla.redhat.com/show_bug.cgi?id=1673400
--- Comment #4 from Robert-André Mauchin ---
You shouldn't include bundled node modules, you should unbundle the whole
package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1673400
--- Comment #3 from Robert-André Mauchin ---
- Shouldn't be commented out:
#%{nodejs_symlink_deps}
- The Summary line shouldn.%'t be more than 80 characters
- The description line should be split to stay below 80 characters per line
-
https://bugzilla.redhat.com/show_bug.cgi?id=1673400
--- Comment #2 from Zuzana Svetlikova ---
Spec URL:
https://fedorapeople.org/~zvetlik/nodejs-antora-site-generator-default/nodejs-antora-site-generator-default.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1673400
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment
