https://bugzilla.redhat.com/show_bug.cgi?id=1674278
Mattia Verga changed:
What|Removed |Added
Status|ASSIGNED|NEW
Assignee|zebo...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob.
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #24 from id...@protonmail.com ---
Sorry for my absence, I've been busy with school.
(In reply to Michael Schwendt from comment #23)
> If no license file is included in the source package, there is no
> requirement for the packager
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #23 from Michael Schwendt ---
If no license file is included in the source package, there is no requirement
for the packager to add one:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #22 from Robert-André Mauchin ---
- You must install the LICENSE file with %license in %files
%license LICENSE
- Use %set_build_flags to set Fedora build flags:
%build
%set_build_flags
%make_build
- Separate your changelog e
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Bl
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #21 from id...@protonmail.com ---
(In reply to leigh scott from comment #20)
> Now you need to make it use the default fedora compiler flags, currently it
> has none
>
>
> + /usr/bin/make -O -j8 CC=gcc
> building ttyclock.c
> gcc
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #20 from leigh scott ---
Now you need to make it use the default fedora compiler flags, currently it has
none
+ /usr/bin/make -O -j8 CC=gcc
building ttyclock.c
gcc -Wall -g $(pkg-config --cflags ncurses) ttyclock.c -o tty-clock
$
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #19 from id...@protonmail.com ---
(In reply to Vít Ondruch from comment #18)
> You should probably try Mock to build your package:
>
> https://github.com/rpm-software-management/mock/wiki
>
> This would help to catch the dependenc
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #18 from Vít Ondruch ---
You should probably try Mock to build your package:
https://github.com/rpm-software-management/mock/wiki
This would help to catch the dependency issues early.
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #17 from id...@protonmail.com ---
(In reply to leigh scott from comment #16)
> (In reply to idf31 from comment #15)
> > (In reply to leigh scott from comment #14)
> > > > (In reply to leigh scott from comment #12)
> > > > > building
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #16 from leigh scott ---
(In reply to idf31 from comment #15)
> (In reply to leigh scott from comment #14)
> > > (In reply to leigh scott from comment #12)
> > > > building ttyclock.c
> > > > cc -Wall -g $(pkg-config --cflags ncurs
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #15 from id...@protonmail.com ---
(In reply to leigh scott from comment #14)
> > (In reply to leigh scott from comment #12)
> > > building ttyclock.c
> > > cc -Wall -g $(pkg-config --cflags ncurses) ttyclock.c -o tty-clock
> > > $(p
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #14 from leigh scott ---
> (In reply to leigh scott from comment #12)
> > building ttyclock.c
> > cc -Wall -g $(pkg-config --cflags ncurses) ttyclock.c -o tty-clock
> > $(pkg-config --libs ncurses)
> > BUILDSTDERR: /bin/sh: cc: co
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #13 from id...@protonmail.com ---
(In reply to leigh scott from comment #11)
> The current srpm fails to build in mock or koji.
>
>
> $ koji build --scratch f30 tty-clock-2.3-1.fc29.src.rpm
> Uploading srpm: tty-clock-2.3-1.fc29.s
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #12 from leigh scott ---
building ttyclock.c
cc -Wall -g $(pkg-config --cflags ncurses) ttyclock.c -o tty-clock $(pkg-config
--libs ncurses)
BUILDSTDERR: /bin/sh: cc: command not found
BUILDSTDERR: make: *** [Makefile:26: tty-clock
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #11 from leigh scott ---
The current srpm fails to build in mock or koji.
$ koji build --scratch f30 tty-clock-2.3-1.fc29.src.rpm
Uploading srpm: tty-clock-2.3-1.fc29.src.rpm
[] 100% 00:00:00
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #10 from id...@protonmail.com ---
(In reply to Elliott Sales de Andrade from comment #9)
> You should link to raw versions of the files so that tools like
> fedora-review work.
>
> * Remove lib from summary
> * BuildRequires cannot
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
Elliott Sales de Andrade changed:
What|Removed |Added
CC||quantum.anal...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #8 from id...@protonmail.com ---
I made Source0 less repetitive by using the url macro.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and componen
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #7 from id...@protonmail.com ---
I fixed a typo in the URL section.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
__
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #6 from id...@protonmail.com ---
I fixed the wrong license short name and modified the changelog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #5 from id...@protonmail.com ---
I updated my .spec file to fix the broken url and the bad paths.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product an
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #4 from id...@protonmail.com ---
(In reply to leigh scott from comment #3)
> The source url is invalid
>
> spectool -g tty-clock.spec
> Getting https://github.com/xorg62/tty-clock/releases/tag/v2.3.tar.gz to
> ./v2.3.tar.gz
> %
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #3 from leigh scott ---
The source url is invalid
spectool -g tty-clock.spec
Getting https://github.com/xorg62/tty-clock/releases/tag/v2.3.tar.gz to
./v2.3.tar.gz
% Total% Received % Xferd Average Speed TimeTime
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #2 from id...@protonmail.com ---
(In reply to Jaroslav Prokop from comment #1)
> I'll do an unofficial review, just some basic points:
> * use macros, e.g. %{_bindir}/tty-clock and %{_mandir}/man1/ ...
>
> * I don't think rm -rf bu
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
Jaroslav Prokop changed:
What|Removed |Added
CC||jar.pro...@volny.cz
--- Comment #1
27 matches
Mail list logo
