subject:"\[Bug 1684346\] Review Request\: ocaml\-dune \- A composable build system for OCaml"

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-05 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 Andy Li changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|---

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-04 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-dune -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-03 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 --- Comment #11 from Andy Li --- I've added the Provides on "dune" as suggested. Spec URL: https://gist.github.com/andyli/e8837f66df97f8c659f114c063549da5/raw/4675620d49839457e5ee450abcf5fb5841b154bb/ocaml-dune.spec SRPM URL:

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-01 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 --- Comment #10 from Robin Lee --- (In reply to Andy Li from comment #9) > Assigning to Robin as required by > https://pagure.io/releng/fedora-scm-requests/issue/10074 I am sorry. You may have to open a new issue. -- You are receiving this

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-01 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 Andy Li changed: What|Removed |Added Assignee|nob...@fedoraproject.org|robinlee.s...@gmail.com --- Comment #9

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-01 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 --- Comment #8 from Andy Li --- Hi Ben, I added the prefix to be consistent with openSUSE's ocaml-dune package. I've no objection against adding a provides on "dune", or even just name it as "dune" instead of "ocaml-dune". For the record,

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-01 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 --- Comment #7 from Ben Rosser --- Hey, thanks for taking care of this! It was on my list of things to do but I kept putting it off. :( I would suggest adding a Provides on "dune"; I named the package "jbuilder" originally because it's an

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-01 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 --- Comment #6 from Andy Li --- Wrong URLs for the previous comment. Here are the real ones. Spec URL: https://gist.github.com/andyli/e8837f66df97f8c659f114c063549da5/raw/67cf9852121c0a436924984da57b1f49ad95f0c5/ocaml-dune.spec SRPM URL:

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-01 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 --- Comment #5 from Andy Li --- Good catch. I've just fixed the missing manpage. Spec URL: https://gist.github.com/andyli/e8837f66df97f8c659f114c063549da5/raw/566433f7b36682edbb23c286e8efa6ee495ce06f/ocaml-dune.spec SRPM URL:

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-01 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 --- Comment #4 from Robin Lee --- And you may consider adding rpm macros like %dune_build, %dune_install, %dune_runtest to facilitate building of dune-based packages. -- You are receiving this mail because: You are on the CC list for the

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-01 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1684346 Robin Lee changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Robin