https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Benson Muite changed:
What|Removed |Added
Flags|needinfo?(benson_muite@emai |
|lplus.org)
Product: Fedora
Version: rawhide
Component: Package Review
Benson Muite has canceled Package Review
's request for Benson Muite
's needinfo:
Bug 1684603: Review Request: bCNC - GRBL CNC command sender, autoleveler and
G-code editor
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #34 from Benson Muite ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #33 from Jaroslav Škarvada ---
(In reply to Benson Muite from comment #32)
> bCNC.noarch: W: python-bytecode-without-source
> /usr/lib/python3.11/site-packages/bCNC/lib/python_utils/__pycache__/compat.
> cpython-311.opt-1.pyc
>
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #32 from Benson Muite ---
Some rpmlint warnings:
$ rpmlint bCNC-0.9.14.52~20221017git523f1ec7-4.fc38.src.rpm
rpmlint session starts
rpmlint: 2.2.0
configuration:
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #31 from Jaroslav Škarvada ---
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-4.fc35.src.rpm
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #30 from Jaroslav Škarvada ---
(In reply to Benson Muite from comment #26)
Both bundled packages are used for web iface.
> Can jquery be unbundled and the packaged version used:
>
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #28 from Jaroslav Škarvada ---
python-opencv is for optional webcam streaming
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #29 from Jaroslav Škarvada ---
I will probably add scipy as recommends.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #27 from Jaroslav Škarvada ---
(In reply to Benson Muite from comment #26)
> It still fails to install. Tried adding the additional dependencies, and
> this did not help.
> Try a copr build with -fedora-review enabled to see
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #26 from Benson Muite ---
It still fails to install. Tried adding the additional dependencies, and this
did not help.
Try a copr build with -fedora-review enabled to see this.
Tried using
mock install -r
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #25 from Jaroslav Škarvada ---
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-3.fc35.src.rpm
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #24 from Jaroslav Škarvada ---
(In reply to Jaroslav Škarvada from comment #23)
> (In reply to Benson Muite from comment #21)
> > For the updated package, following issue is raised:
> > Package must own all directories that it
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #23 from Jaroslav Škarvada ---
(In reply to Benson Muite from comment #21)
> For the updated package, following issue is raised:
> Package must own all directories that it creates.
> Note: Directories without known owners:
>
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #22 from Jaroslav Škarvada ---
(In reply to Benson Muite from comment #20)
> Thanks for updating the package. When building on Debian, several linux
> packages
> are installed, see
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #21 from Benson Muite ---
For the updated package, following issue is raised:
Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/256x256,
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #20 from Benson Muite ---
Thanks for updating the package. When building on Debian, several linux
packages
are installed, see https://github.com/vlachoudis/bCNC/blob/master/.travis.yml
The Fedora equivalents are:
libpng-devel
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #19 from Jaroslav Škarvada ---
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-2.fc35.src.rpm
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #18 from Jaroslav Škarvada ---
Comments:
> a) Installation seems like an error with Fedora-review,
> https://bugzilla.redhat.com/show_bug.cgi?id=2132574, but checking
Probably.
> b) A typical warning in the build log
> writing
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #17 from Benson Muite ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #16 from Jaroslav Škarvada ---
New snapshot:
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-1.fc35.src.rpm
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #15 from Jaroslav Škarvada ---
Regarding the version, I could refresh the snapshot.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #14 from Jaroslav Škarvada ---
New version:
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20210908git36896e5f-1.fc35.src.rpm
Regarding the tests, the
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #13 from Jaroslav Škarvada ---
Thanks for the review.
> Initial Comments:
> a) See Python packaging guidelines,
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/
> consider naming slightly differently
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #12 from Benson Muite ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Benson Muite changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|benson_mu...@emailplus.org
Product: Fedora
Version: rawhide
Component: Package Review
Zdenek Dohnal has canceled Package Review
's request for Jaroslav Škarvada
's needinfo:
Bug 1684603: Review Request: bCNC - GRBL CNC command sender, autoleveler and
G-code editor
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Zdenek Dohnal changed:
What|Removed |Added
CC||zdoh...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Didik Supriadi changed:
What|Removed |Added
Whiteboard|NotReady|
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #9 from Jaroslav Škarvada ---
New version, python3 ready:
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52-0.2.20210908git36896e5f.fc33.src.rpm
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #8 from Jaroslav Škarvada ---
Upstream already ported the code to the Python 3. This review request needs
updated package.
I am going to update it.
--
You are receiving this mail because:
You are always notified about changes
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Didik Supriadi changed:
What|Removed |Added
Whiteboard||NotReady
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Jaroslav Škarvada changed:
What|Removed |Added
Flags|needinfo?(jskarvad@redhat.c |
|om)
Product: Fedora
Version: rawhide
Component: Package Review
Jaroslav Škarvada has canceled Package Review
's request for Jaroslav Škarvada
's needinfo:
Bug 1684603: Review Request: bCNC - GRBL CNC command sender, autoleveler and
G-code editor
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Product: Fedora
Version: rawhide
Component: Package Review
Jaroslav Škarvada has canceled Package Review
's request for Jaroslav Škarvada
's needinfo:
Bug 1684603: Review Request: bCNC - GRBL CNC command sender, autoleveler and
G-code editor
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Jaroslav Škarvada changed:
What|Removed |Added
Flags|needinfo?(jskarvad@redhat.c |
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #3 from Jaroslav Škarvada ---
I will probably wait for the python3 version.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
CC||zbys...@in.waw.pl
---
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
Miro Hrončok changed:
What|Removed |Added
CC||mhron...@redhat.com
--- Comment #1
39 matches
Mail list logo
