https://bugzilla.redhat.com/show_bug.cgi?id=1714377
Miro Hrončok changed:
What|Removed |Added
Status|POST|CLOSED
Fixed In Version|
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #23 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/ansible-bender
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
Miro Hrončok changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #21 from Gordon Messmer ---
Spec URL:
https://bitbucket.org/gordonmessmer/ansible-bender/raw/f0e302132eb77f95e2a6843040a75fcd78a7987b/ansible-bender.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1047/36011047/ansibl
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #20 from Miro Hrončok ---
Package Review
==
Issues:
1) The actual license seems to be MIT, not GPLv3.
2) There are no versions in %changelog.
3) please see why ansible_bender/version.py is empty.
Legend:
[x] = Pas
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
Gordon Messmer changed:
What|Removed |Added
Flags|needinfo?(gordon.messmer@gm |
|ail.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
Miro Hrončok changed:
What|Removed |Added
Flags||needinfo?(gordon.messmer@gm
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
Miro Hrončok changed:
What|Removed |Added
Status|NEW |ASSIGNED
QA Contact|extras...@fe
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #16 from Gordon Messmer ---
Thanks for sponsoring me (and for all of the kind words), Miro. Are there any
additional steps required to approve this review?
--
You are receiving this mail because:
You are on the CC list for the b
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #15 from Miro Hrončok ---
Gordon, you receive feedback very well, thanks!
Once you decide to do some reviews, feel free to ask me for help (here, e-mail
or IRC (mhrocnok at #fedora-devel)) but even if you don't, please:
* indica
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #14 from Gordon Messmer ---
Created attachment 1575249
--> https://bugzilla.redhat.com/attachment.cgi?id=1575249&action=edit
privileged build log
--
You are receiving this mail because:
You are on the CC list for the bug.
You a
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #13 from Gordon Messmer ---
spec URL:
https://bitbucket.org/gordonmessmer/ansible-bender/raw/a7e4718d2bf3d6aaef2143f9d540ef490d36bfce/ansible-bender.spec
koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=35146593
--
Y
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #12 from Miro Hrončok ---
I like the double conditional, but I'd call it --with privileged_tests (that's
a gain a matter of style and feel free to keep as is).
The %check section can be simplified:
%if %{with check}
%check
PYTHON
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #11 from Gordon Messmer ---
spec URL:
https://bitbucket.org/gordonmessmer/ansible-bender/raw/e4b6e6b31b183acfc1c4bd748b402e07986446b9/ansible-bender.spec
koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=35138464
I've
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #10 from Gordon Messmer ---
I wasn't previously aware of the "--enable-network" flag for mock. However,
that's not enough to allow the tests to run. The build log includes:
Error: error running newgidmap: exit status 1: newgidma
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #9 from Miro Hrončok ---
On Fedora 29, 30 and rawhide, ansible-python3 is provided by the ansible
package for backwards compatibility only. It should just need ansible.
When the tests are disabled by default, I suggest addin
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #8 from Gordon Messmer ---
Created attachment 1575004
--> https://bugzilla.redhat.com/attachment.cgi?id=1575004&action=edit
rpm build output with tests enabled, from Fedora 30 system
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #7 from Gordon Messmer ---
So, the bad news is that all of the tests, including the unit tests, require
network connectivity and cannot be run in mock.
The good news is that I built an F30 VM and ran the build with tests there and
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #6 from Miro Hrončok ---
No tests are run:
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.4t5w9E
+ umask 022
+ cd /builddir/build/BUILD
+ cd ansible-bender-0.6.1
+ /usr/bin/python3 setup.py test
running test
running egg_info
writi
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
CC||domi...@greysector.net
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #4 from Miro Hrončok ---
https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this produc
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #3 from Gordon Messmer ---
I'd be very happy to review other submissions. Are there guidelines for
reviewers?
I've added a %check section, and expanded buildrequires to support it. I've
also used the python3_pkgversion macro to
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
Miro Hrončok changed:
What|Removed |Added
CC||mhron...@redhat.com
--- Comment #2 fro
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #1 from Gordon Messmer ---
This is my first package in Fedora, so I need a sponsor.
Successful koji task is here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=35099252
--
You are receiving this mail because:
You are on th
24 matches
Mail list logo
