[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-03-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 Breno changed: What|Removed |Added Status|NEW |CLOSED Resolution|---

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 --- Comment #10 from Vít Ondruch --- (In reply to Breno from comment #9) > So, regarding the puppet 6 requirement, cane is required by > semantic_puppet[1] which is required by puppet. It seems it is just developement dependency. It will be r

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 --- Comment #9 from Breno --- Hi Vít, Thanks for your feedback regarding the testing. I will check that with the upstream. So, regarding the puppet 6 requirement, cane is required by semantic_puppet[1] which is required by puppet. Does it m

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 --- Comment #8 from Vít Ondruch --- (In reply to Vít Ondruch from comment #7) > Also, last but not least, it seems Cane upstream suggest to use Rubocop > instead of Cane, therefore I wonder why are you trying to include Cane into > Fedora? Ac

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 --- Comment #7 from Vít Ondruch --- This is a way to execute the test suite: ~~~ --- a/rubygem-cane.spec +++ b/rubygem-cane.spec @@ -14,10 +14,7 @@ BuildRequires: ruby >= 1.9.0 # for the tests BuildRequires: rubygem(parallel) -# BuildRequi

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 --- Comment #6 from Breno --- Spec URL: https://raw.githubusercontent.com/skywalkerz0r/rubygem-cane/epel8/rubygem-cane.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/rubygem-cane-testing/epel-8-x86_64/01252264-rubyg

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 --- Comment #5 from Vít Ondruch --- (In reply to Adam Borowski from comment #3) > I'm not sure about the testsuite issue. Yes, it would be nice to execute the test suite. Also, I would move the test suite into -doc subpackage, because it is n

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #4 from

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 --- Comment #3 from Adam Borowski --- Issues: === - Package contains Requires: ruby(release). = MUST items = Generic: [✓]: Package is licensed with an open-source compatible license and meets other legal requirements as def

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 Adam Borowski changed: What|Removed |Added CC||kilob...@angband.pl --- Comment #2 fr

[Bug 1803276] Review Request: rubygem-cane - Provides complexity and style checkers allowing integration with custom metrics

2020-02-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803276 Breno changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 fr