https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags|fedora-review? |fedora-review-
S
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #31 from Ankur Sinha (FranciscoD) ---
(In reply to Ntish from comment #30)
> Hey Ankur,
>
> Sorry for late reply,
>
> There is nothing much update on sumatra gitrepo, last tagged release was
> done in 2015. I am checking the deve
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ntish changed:
What|Removed |Added
Flags|needinfo?(nisharma@redhat.c |
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags||needinfo?(nisharma@redhat.c
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #28 from Ntish ---
Hey Ankur,
It's in progess, I will update the ticket once there is progress.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Whiteboard||NotReady
--- Comment #27 f
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #26 from Ankur Sinha (FranciscoD) ---
Hi,
Any updates here please?
If the tool requires updating it to the new django, that may be quite a bit of
work. You could just inform upstream and drop this until they fix it :(
Cheers,
An
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #25 from Ankur Sinha (FranciscoD) ---
Looks pretty good, but some work to be done yet.
I'm afraid we can't modify the tar and then use the modified tar. You'll have
to include patches if you need to make changes to the sources. Th
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #24 from Ankur Sinha (FranciscoD) ---
Thanks! I'll have a look this week. On my list now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and comp
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #23 from Ntish ---
I have uploaded latest spec file and artifacts on
https://nitsharma.fedorapeople.org/
Thanks again :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #22 from Ntish ---
I followed below steps to have successful build.
1.) build sumatra package and generated tar file from it.
2.) generated rpm package via fedpkg from tar file above
3.) tested using mock.
I tried build from gi
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #21 from Ntish ---
There seems to be an issue with the current structure of git repo, the name of
the repo is in consistence, somewhere it is Sumatra with a capital S, and at
some places it is small s. I have tried my best to have
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #20 from Ankur Sinha (FranciscoD) ---
Hey,
No worries, please take your time.
Unfortunately, meetings are harder to do. Could you ask your queries here in
the review ticket? (That's a perfectly normal + fine thing to do)
Cheers,
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ntish changed:
What|Removed |Added
Flags|needinfo?(nisharma@redhat.c |
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags||needinfo?(nisharma@redhat.c
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #17 from Ankur Sinha (FranciscoD) ---
Hi Ntish,
Any chance you've been able to look at this again please?
Cheers,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ntish changed:
What|Removed |Added
Flags|needinfo?(nisharma@redhat.c |
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags||needinfo?(nisharma@redhat.c
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #15 from Ankur Sinha (FranciscoD) ---
Hi Ntish,
Any updates here? Please ping me over e-mail etc if you need to :)
Cheers,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notifi
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #14 from Ankur Sinha (FranciscoD) ---
Hi Ntish,
It does not build at the moment. I see you have:
python3 setup.py install
in the %prep section? Why is this? It shouldn't be there.
Please take a look at the example python spec
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #13 from Ntish ---
Hey Ankur,
Thanks for the review, i have done the changes, you suggested, Cna you please
review once again.
https://nitsharma.fedorapeople.org/python-sumatra-0.7.4-1.fc32.src.rpm
https://nitsharma.fedorapeople
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #12 from Ankur Sinha (FranciscoD) ---
Heya,
You've changed the name of the package to python-Sumatra (with a capital S), so
the links to the spec/srpm are broken.
There's no need to capitalise the name, can you please correct that
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags|needinfo?(sanjay.ankur@gmai |
|l.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ntish changed:
What|Removed |Added
Flags||needinfo?(sanjay.ankur@gmai
|
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ntish changed:
What|Removed |Added
Flags||needinfo?(sanjay.ankur@gmai
|
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #9 from Ankur Sinha (FranciscoD) ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Install
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #8 from Ankur Sinha (FranciscoD) ---
A few issues to start with:
- please update the description,
- a bunch of rpmlint errors:
Rpmlint
---
Checking: python3-sumatra-0.7.4-1.fc33.noarch.rpm
python-sumatra-0.7.4-1.fc3
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ntish changed:
What|Removed |Added
Flags||needinfo?(sanjay.ankur@gmai
|
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ntish changed:
What|Removed |Added
Comment|0 |updated
--- Comment #0 has been edited ---
S
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #7 from Ntish ---
- Initial comment: the name of the spec should match the name of the package,
so it should be called python-sumatra.spec. :
updated Name of spec from sumatra.spec to python-sumatra.spec
- I've also corrected t
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #6 from Ankur Sinha (FranciscoD) ---
No worries, please ping when you're ready and I'll continue the review. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ntish changed:
What|Removed |Added
Flags|needinfo?(nisharma@redhat.c |
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags||needinfo?(nisharma@redhat.c
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #4 from Ankur Sinha (FranciscoD) ---
Hi Ntish, any updates on this please?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #3 from Ankur Sinha (FranciscoD) ---
Any updates here Ntish?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #2 from Ankur Sinha (FranciscoD) ---
If it's only a python application and not a library/module, you can call it
sumatra, but the spec and %{name} of the spec must match:
https://docs.fedoraproject.org/en-US/packaging-guidelines/P
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
CC||neuro-sig@lists.fedoraproje
38 matches
Mail list logo