https://bugzilla.redhat.com/show_bug.cgi?id=1872867
Clark Williams changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #26 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/stalld
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #25 from Clark Williams ---
Ok, On to requesting a branch!
Thank you both for your reviews!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #24 from Jaroslav Škarvada ---
Thanks, LGTM.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #23 from Neal Gompa ---
Looks fine to me now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #22 from Clark Williams ---
Updated specfile/Makefile to actually use CFLAGS/LDFLAGS
Fixed some compiler warnings for src/stalld.c
Fixed specfile changelog annotations as per #c19
Pushed stalld-1.0-3.fc32.src.rpm and specfile to
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #21 from Jaroslav Škarvada ---
(In reply to Jaroslav Škarvada from comment #20)
> I also noticed that the release CFLAGS are still not used.
I think it's because you didn't used %configure macro, so you should edit the
spec the
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #20 from Jaroslav Škarvada ---
I also noticed that the release CFLAGS are still not used.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #19 from Neal Gompa ---
> BuildRequires:glibc-devel gcc make systemd-rpm-macros
In general, you should put each dependency on its own line, as that makes it
easier for diff management as they change in git.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
Neal Gompa changed:
What|Removed |Added
CC||ngomp...@gmail.com
--- Comment #18 from
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #17 from Jaroslav Škarvada ---
(In reply to Clark Williams from comment #16)
> Done. Pushed new spec/srpm to fedorapeople.org and have PR out on main
> source repo
Do you need Fedora sponsorship?
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #16 from Clark Williams ---
Done. Pushed new spec/srpm to fedorapeople.org and have PR out on main source
repo
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
Jaroslav Škarvada changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #15
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #14 from Clark Williams ---
Updated Makefile CFLAGS/LDFLAGS and fixed tab vs space issues
pushed latest specfile/SRPM to jcwillia.fedorapeople.org
--
You are receiving this mail because:
You are on the CC list for the bug.
You
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #13 from Clark Williams ---
Added license file (gpl-2.0.txt) and logic to install it properly.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #12 from Clark Williams ---
(In reply to Jaroslav Škarvada from comment #11)
> (In reply to Clark Williams from comment #9)
> >
> > Not sure I agree with this. The config file is strictly for the use of the
> > unit
> > file and
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #11 from Jaroslav Škarvada ---
(In reply to Clark Williams from comment #9)
>
> Not sure I agree with this. The config file is strictly for the use of the
> unit
> file and I got the impression that the customary place for these
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #10 from Clark Williams ---
(In reply to Clark Williams from comment #9)
> (In reply to Jaroslav Škarvada from comment #6)
> >
> > - I think the systemd configuration file should be installed into the
> > /etc/sysconfig, i.e.
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #9 from Clark Williams ---
(In reply to Jaroslav Škarvada from comment #6)
> Despite the CFLAGS/LDFLAGS problem mentioned in the previous comment, there
> are few more things:
>
> - Please make consistent use of the spaces and
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #8 from Jaroslav Škarvada ---
(In reply to Jaroslav Škarvada from comment #6)
> - You needn't list manual pages as a doc, but this is not a blocker [2]
>
> [1]
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #7 from Jaroslav Škarvada ---
Also in the comment 5 I wasn't correct, it doesn't build on the aarch64,
ppc64le and s390x:
src/stalld.c: In function 'sched_setattr':
src/stalld.c:88:17: error: '__NR_sched_setattr' undeclared
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #6 from Jaroslav Škarvada ---
Despite the CFLAGS/LDFLAGS problem mentioned in the previous comment, there are
few more things:
- Please make consistent use of the spaces and tabs. You used tabs as a
separator for the "Name",
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #5 from Jaroslav Škarvada ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #4 from Clark Williams ---
updated specfile with above concerns addressed
SOURCE0 is temporarily pointing at my fedorapeople.org page. Will be updated
when we work out the tarball generation logic
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #3 from Clark Williams ---
(In reply to Jaroslav Škarvada from comment #2)
> I took a first look:
>
> - Version:%(grep ^VERSION ../Makefile | awk '{print $3}')
> This is not acceptable because there is no ../Makefile before
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #2 from Jaroslav Škarvada ---
I took a first look:
- Version: %(grep ^VERSION ../Makefile | awk '{print $3}')
This is not acceptable because there is no ../Makefile before the sources are
downloaded and unpacked. The version
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #1 from Clark Williams ---
rpmlint run on SRPM:
---
$ rpmlint -i redhat/SRPMS/stalld-1.0-1.fc32.src.rpm
stalld.src: E: specfile-error error: line 2:
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
Jaroslav Škarvada changed:
What|Removed |Added
CC||jskar...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1872867
Jaroslav Škarvada changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are receiving
29 matches
Mail list logo
