[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Jordi Sanfeliu changed: What|Removed |Added Resolution|--- |RAWHIDE Status|ASSIGNED

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #59 from Jordi Sanfeliu --- (In reply to Petr Pisar from comment #57) > Verification of the installed package passes. Ok. > > The package is APPROVED. Thank you very much for patience and excellent assistance. -- You are recei

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #58 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/smf-spf -- You are receiving this mail because: You are on the CC list for the bug. You are alwa

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Petr Pisar changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #57 from Petr

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #55 from Fedora Review Service --- Created attachment 1975573 --> https://bugzilla.redhat.com/attachment.cgi?id=1975573&action=edit The .spec file difference from Copr build 6164195 to 6169035 -- You are receiving this mail b

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #56 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6169035 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhi

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #54 from Jordi Sanfeliu --- (In reply to Petr Pisar from comment #53) > The %attr() macro must on the same line as the socket file. The way you > wrote it does not have any effect: > > $ rpm -qlvp ../RPMS/x86_64/smf-spf-2.5.1^202

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #53 from Petr Pisar --- The %attr() macro must on the same line as the socket file. The way you wrote it does not have any effect: $ rpm -qlvp ../RPMS/x86_64/smf-spf-2.5.1^20220423g061e937-1.fc39.x86_64.rpm | grep sock -rw-r--r-

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #51 from Fedora Review Service --- Created attachment 1975350 --> https://bugzilla.redhat.com/attachment.cgi?id=1975350&action=edit The .spec file difference from Copr build 6164027 to 6164195 -- You are receiving this mail b

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #52 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6164195 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhi

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #50 from Jordi Sanfeliu --- (In reply to Petr Pisar from comment #49) > FIX: Package the socket file with %attr(0600,smfs,smfs). OK, done. - Please, find the latest .spec and SRPM versions here Spec URL: https://ftp.fibranet.cat

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #49 from Petr Pisar --- $ rpmlint smf-spf.spec ../SRPMS/smf-spf-2.5.1^20220423g061e937-1.fc39.src.rpm ../RPMS/x86_64/smf-spf-* rpmlint session starts ===

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #48 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6164027 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhi

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #47 from Fedora Review Service --- Created attachment 1975330 --> https://bugzilla.redhat.com/attachment.cgi?id=1975330&action=edit The .spec file difference from Copr build 6161483 to 6164027 -- You are receiving this mail b

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #46 from Jordi Sanfeliu --- (In reply to Petr Pisar from comment #45) > TODO: Are you sure sendmail is required at build time (smf-spf.spec:23)? No, it doesn't. It was a mistake. Fixed. > FIX: Correct a version in the changelog

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #45 from Petr Pisar --- Url and Source0 addresses are Ok. Source0 archive (SHA-512: 5b7955dae6d19bea1290e2cfd700d150ad46e53325b5bac9305f6534623802daecd8aee0696cb47708934e2a8b8008a8536f0d65657cf1003a12a1423bfb4a3e) is original. Ok.

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Fedora Review Service changed: What|Removed |Added URL||https://github.com/jcbf/smf

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #43 from Fedora Review Service --- Created attachment 1975172 --> https://bugzilla.redhat.com/attachment.cgi?id=1975172&action=edit The .spec file difference from Copr build 6149097 to 6161483 -- You are receiving this mail b

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #42 from Jordi Sanfeliu --- (In reply to Petr Pisar from comment #37) > FIX: Missing an Url tag in the spec file pointing to an upstream. Did you > mean ? Yes, done. > FIX: Source0 looks like a V

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #41 from Jordi Sanfeliu --- (In reply to Petr Pisar from comment #40) > %autosetup has -n option to specify the top-level directory in the archive. > See > #_c

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #40 from Petr Pisar --- %autosetup has -n option to specify the top-level directory in the archive. See . -- You are receiving this mail beca

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #39 from Jordi Sanfeliu --- > FIX: Source0 looks like a VCS snapshot. Put a URL you cloned it from into a > comment above Source0 tag >

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #38 from Petr Pisar --- (In reply to Jordi Sanfeliu from comment #36) > > Maybe you should try a scratch build in Fedora Koji "koji build --scratch > > f39-candidate smf-spf-2.5.1.061e937-1.fc38.src.rpm". This how Fedora > > pack

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #37 from Petr Pisar --- FIX: Missing an Url tag in the spec file pointing to an upstream. Did you mean ? FIX: Source0 looks like a VCS snapshot. Put a URL you cloned it from into a comment above Sou

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Petr Pisar changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags|

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #36 from Jordi Sanfeliu --- > Maybe you should try a scratch build in Fedora Koji "koji build --scratch > f39-candidate smf-spf-2.5.1.061e937-1.fc38.src.rpm". This how Fedora packages > are built without the failing COPR appendag

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #34 from Fedora Review Service --- Created attachment 1974408 --> https://bugzilla.redhat.com/attachment.cgi?id=1974408&action=edit The .spec file difference from Copr build 6141267 to 6149097 -- You are receiving this mail b

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #35 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6149097 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhi

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #33 from Jordi Sanfeliu --- Thanks for your review Petr. > This is not a failure of the build. The cause is DNF5 which replaced DNF4 in > Fedora 39 and DNF5 does not support "dnf repoquery -l" invocation. You can > file a bug ag

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #32 from Petr Pisar --- > Build log: > https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhide-x86_64/06141267-smf-spf/builder-live.log.gz This one shows a failure in a fedora

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #31 from Jordi Sanfeliu --- Petr, Do you know why the build failed? I'm reading the logs but I cannot see where is the cause. -- You are receiving this mail because: You are always notified about changes to this product and com

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #30 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6141267 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhi

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #29 from Fedora Review Service --- Created attachment 1974030 --> https://bugzilla.redhat.com/attachment.cgi?id=1974030&action=edit The .spec file difference from Copr build 6141151 to 6141267 -- You are receiving this mail b

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #28 from Jordi Sanfeliu --- Oh!, I forgot to update adding the smfs user and group with an sysusers approach. Let's see how it goes now. - Please, find the latest .spec and SRPM versions here Spec URL: https://ftp.fibranet.cat/smf

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #27 from Jordi Sanfeliu --- I'm unable to find out where it failed in the logs, I see some Warnings but they seem harmless. Can you help me please? Thanks. -- You are receiving this mail because: You are always notified about c

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #25 from Fedora Review Service --- Created attachment 1974025 --> https://bugzilla.redhat.com/attachment.cgi?id=1974025&action=edit The .spec file difference from Copr build 6141088 to 6141151 -- You are receiving this mail b

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #26 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6141151 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhi

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #24 from Jordi Sanfeliu --- It looks like the build failed because it was unable to download the source file: WARNING: Cannot download url: https://github.com/jcbf/smf-spf/archive/v2.5.1.061e937/smf-spf-2.5.1.061e937.tar.gz The u

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #22 from Fedora Review Service --- Created attachment 1974021 --> https://bugzilla.redhat.com/attachment.cgi?id=1974021&action=edit The .spec file difference from Copr build 5383892 to 6141088 -- You are receiving this mail b

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #23 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6141088 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhi

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #21 from Jordi Sanfeliu --- Of course I am, and thank you very much for your assistance. I've changed the string "GPLv2+" by "GPL-2.0-or-later" so I hope this will be enough. - Please, find the latest .spec and SRPM versions here

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #20 from Petr Pisar --- If you are still interested in this package, could you please update License tag to use an SPDX format and update adding the smfs user and group

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com --- Comment #19 from P

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #18 from Jordi Sanfeliu --- $ fedpkg request-repo smf-spf 1877006 Could not execute request_repo: The Bugzilla bug is not approved yet Anyone can give a push to this package? -- You are receiving this mail because: You are alwa

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #17 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5383892 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1877006-smf-spf/fedora-rawhi

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #16 from Jordi Sanfeliu --- (In reply to Jordi Sanfeliu from comment #15) > (In reply to Robert-André Mauchin 🐧 from comment #11) > > Package approved. - Please, find the latest .spec and SRPM versions here Spec URL: https://ftp.

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #15 from Jordi Sanfeliu --- (In reply to Robert-André Mauchin 🐧 from comment #11) > Package approved. Hello, I'm tired to wait upstream to release the new version, so I thought I'll go ahead with the latest commit 2.5.1+061e937.

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Jordi Sanfeliu changed: What|Removed |Added Flags|needinfo?(jo...@fibranet.ca | |t)

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Mattia Verga changed: What|Removed |Added Assignee|zebo...@gmail.com |nob...@fedoraproject.org Sta

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #12 from Jordi Sanfeliu --- (In reply to Robert-André Mauchin 🐧 from comment #11) > Package approved. Great news! :-) Thank you very much for your kind assistance. Best wishes. -- You are receiving this mail because: You are o

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #10 from Jordi Sanfeliu --- (In reply to Robert-André Mauchin 🐧 from comment #9) > You can pass them in the spec: > > %make_build OPTFLAGS="%{optflags}" LDFLAGS="%{build_ldflags} -lmilter > -lpthread -lspf2" OK, done. Thanks!. >

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #9 from Robert-André Mauchin 🐧 --- (In reply to Jordi Sanfeliu from comment #8) > (In reply to Robert-André Mauchin 🐧 from comment #7) > > No only if you choose to go with %make_build OPTFLAGS="%{optflags}" like > > this: > > >

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #8 from Jordi Sanfeliu --- (In reply to Robert-André Mauchin 🐧 from comment #7) > No only if you choose to go with %make_build OPTFLAGS="%{optflags}" like > this: > > %make_build OPTFLAGS="%{optflags}" LDFLAGS="%{build_ldflags}

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #7 from Robert-André Mauchin 🐧 --- (In reply to Jordi Sanfeliu from comment #6) > (In reply to Robert-André Mauchin 🐧 from comment #5) > > also you need to define LDFLAGS similarly with %build_ldflags > You mean I need to add the f

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #6 from Jordi Sanfeliu --- (In reply to Robert-André Mauchin 🐧 from comment #5) > - NOt needed: > > BuildRequires:systemd-units > > Requires(post): systemd-units > Requires(preun): systemd-units > Requires(postun):

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #5 from Robert-André Mauchin 🐧 --- - NOt needed: BuildRequires: systemd-units Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units Use: BuildRequires: systemd-rpm-macros - Not needed

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #4 from Jordi Sanfeliu --- (In reply to Robert-André Mauchin 🐧 from comment #3) > Source0: > https://github.com/jcbf/smf-spf/archive/v%{version}/%{name}-%{version}.tar.gz > OK, done. > See your patch: > > diff -ru smf-

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|no

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #2 from Jordi Sanfeliu --- (In reply to Robert-André Mauchin 🐧 from comment #1) > All these things have been obsolete for years: > > # Do a systemd-based build from F-15; otherwise, a sysvinit-based build > %global use_systemd %(

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Robert-André Mauchin 🐧 changed: What|Removed |Added CC||zebo...@gmail.com --- Commen

[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Jordi Sanfeliu changed: What|Removed |Added Doc Type|--- |If docs needed, set a value -- You