[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-11-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 Pavel Valena changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version|

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-11-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-sassc-rails -- You are receiving this mail because: You are on the CC list for the bug. You are always not

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 Vít Ondruch changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Vít

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-11-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #10 from Pavel Valena --- (In reply to Vít Ondruch from comment #9) > Just to make it clear, I am reviewing this .spec file and SRPM: Yes, that's the .spec file I was pointing to, for review. > Obviously, we still have rubyg

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-11-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #9 from Vít Ondruch --- Just to make it clear, I am reviewing this .spec file and SRPM: https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01722749-rubygem-sassc-rails/rubygem-sassc-rails.spe

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-11-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 Vít Ondruch changed: What|Removed |Added Flags|needinfo?(vondruch@redhat.c | |om)

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 Pavel Valena changed: What|Removed |Added Flags||needinfo?(vondruch@redhat.c

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #6 from Pavel Valena --- Hello, sorry for the delay. Unfortunately, I forgot to continue to work on this, after getting initially stuck with the test suite. Now I was able to debug it, and all the tests pass. I've a also fixed the

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-10-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #5 from Vít Ondruch --- Ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ packag

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-10-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #4 from Vít Ondruch --- * Licensing - Please check the license of test/dummy/app/assets/stylesheets/erb_render_with_context.css.erb. It seems the package should include the `OFL` license. But probably better to check with ups

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-10-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #3 from Vít Ondruch --- * Weird RexExp - The 'g' in the following RegExp is probably not needed, since you are matching single line anyway: ~~~ sed -i -e '/require .pry./ s/^/#/g' test/test_helper.rb ~~~ * Test suite - It see

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-10-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 Vít Ondruch changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-09-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 Pavel Valena changed: What|Removed |Added Blocks||1871622 Referenced Bugs: https://bu

[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

2020-09-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #1 from Pavel Valena --- Note that te test suite is troublesome at this moment. I didn't manage to make the tests work, due to paths (assets not found, or even SassC). And CSS 'compressor' doesn't seem to work. I will try to resolv