[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-04-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #21 from Fedora Update System --- FEDORA-2021-3c813be767 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #20 from Fedora Update System --- FEDORA-2021-9229df7c09 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-04-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #19 from Fedora Update System --- FEDORA-2021-3c813be767 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-04-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #16 from

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #15 from Mohan Boddu --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/zmk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #14 from Zygmunt Krynicki --- Woot. Thank you for the advice and for your time :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 Neal Gompa changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review?

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #12 from Neal Gompa --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = Generic: [x]: Package is licensed with an open-source compatible license

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #11 from Zygmunt Krynicki --- Done, updated both the .spec and the SRPM file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 Neal Gompa changed: What|Removed |Added Flags|needinfo?(ngomp...@gmail.co | |m)

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 Zygmunt Krynicki changed: What|Removed |Added Flags||needinfo?(ngomp...@gmail.co

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #8 from Zygmunt Krynicki --- (In reply to Neal Gompa from comment #7) > (In reply to Zygmunt Krynicki from comment #6) > > (In reply to Neal Gompa from comment #5) > > > > %{_includedir}/zmk/*.mk > > > >

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #7 from Neal Gompa --- (In reply to Zygmunt Krynicki from comment #6) > (In reply to Neal Gompa from comment #5) > > > %{_includedir}/zmk/*.mk > > > %{_includedir}/zmk/pvs-filter.awk > > > > This should be simplified to just

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #6 from Zygmunt Krynicki --- (In reply to Neal Gompa from comment #5) > > %{_includedir}/zmk/*.mk > > %{_includedir}/zmk/pvs-filter.awk > > This should be simplified to just "%{_includedir}/zmk/" Hmm? As in the whole folder?

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #5 from Neal Gompa --- > %{_includedir}/zmk/*.mk > %{_includedir}/zmk/pvs-filter.awk This should be simplified to just "%{_includedir}/zmk/" -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #4 from Zygmunt Krynicki --- Thank you for the review Neal. I really appreciate this! (In reply to Neal Gompa from comment #3) > > Source0: > >

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #3 from Neal Gompa --- > Source0: > https://github.com/zyga/zmk/releases/download/v%{version}/%{name}-%{version}.tar.gz This can be shortened to "%{url}/releases/download/v%{version}/%{name}-%{version}.tar.gz" Also, I

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #2 from Zygmunt Krynicki --- Thanks Neal! I've updated the package for the 0.5 release which made packaging even more straightforward. The new URLs are: Spec URL: https://zyga.fedorapeople.org/zmk.spec SRPM URL:

[Bug 1922858] Review Request: zmk - Collection of reusable Makefiles

2021-02-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1922858 Neal Gompa changed: What|Removed |Added Status|NEW |ASSIGNED CC|