https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #23 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/Diffuse
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #22 from niohiani ---
Many thanks! I'll jump on this ASAP.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #21 from Ankur Sinha (FranciscoD) ---
Hello,
I've now sponsored you to the package maintainers group. Please continue from
here:
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #20 from niohiani ---
P.P.S. I had to travel for a bit longer than expected due to a family
situation, but am back home now and will get on top of everything over the next
few days. Sincere apologies for the delay.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #19 from niohiani ---
Final revision of spec file is here:
https://download.copr.fedorainfracloud.org/results/niohiani/Diffuse-Packaging-Test/fedora-rawhide-x86_64/02210632-diffuse/diffuse.spec
SRPM is here:
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #18 from niohiani ---
Many thanks Ankur!
I'll make a pull request in MightyCreak's repo to correct the address in the
license file, and of-course reduce the relevant entries under %files to that
one line. I'll get into pitching
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Status|ASSIGNED|POST
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #16 from niohiani ---
P.S. I noticed - because I always have the following program installed under
any distro I use - that GChemTable also creates a directory within
/usr/share/gnome/help under Fedora, so I did not list the entire
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #15 from niohiani ---
OK, I jumped on this as quick as I could, and addressed the aforementioned
issues, along with switching to the eMail address associated with my user
account in the changelog.
Spec:
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #14 from niohiani ---
Shoot. I thought I caught everything. Sorry for missing the debug_package line.
I'll fix that. It's definitely noarch. I must have misunderstood what I read
about %ghost, so I'll remedy that too. I admit that
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #13 from Ankur Sinha (FranciscoD) ---
Heya,
Looks pretty good. Will give it a full review again this week. Some tweaks that
I noticed that got left behind:
- please remove the "%global debug_package %{nil}" line. If the package
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #12 from niohiani ---
Alright Ankur! I think I've taken care of all the "Musts" by now, along with
the other things you pointed out. I did my best to address directory/file
ownership via the %ghost directive (which I just learned
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #11 from niohiani ---
Thanks again, again, Ankur! I'll get on this very soon, and after this round of
corrections it should all be in order. I'll create a temporary dedicated COPR
repo just for getting the packaging up to snuff,
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #10 from Ankur Sinha (FranciscoD) ---
Almost there, a little more work needed :)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #9 from Ankur Sinha (FranciscoD) ---
Hrm, fedora-review still isn't finding it.
Let's try again:
Spec:
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #8 from niohiani ---
(In reply to Ankur Sinha (FranciscoD) from comment #7)
> Hello,
>
> Sorry, missed the notification here. Could you please post the URLs for both
> the spec/srpm so that I can run it through fedora-review
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #7 from Ankur Sinha (FranciscoD) ---
Hello,
Sorry, missed the notification here. Could you please post the URLs for both
the spec/srpm so that I can run it through fedora-review again?
Cheers,
Ankur
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #6 from niohiani ---
Hey again folks! Just an update.
The spec file I'm amending to meet the criteria for inclusion is here now:
https://gist.github.com/bongochong/2caa25a6121487a270ac406f2e052921
I think I've addressed all - or
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #5 from niohiani ---
Starting to make changes now! Sorry for the delay. Long trip. Will share a
modified spec file when I think I have everything in order. Thanks again!
--
You are receiving this mail because:
You are on the CC
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #4 from niohiani ---
Thank you for all of the useful input. I'll look over all of this and start
making the necessary changes. I'm pretty sure I can slim down the Build
Requirements in the spec too. It might take a few days for me
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #3 from Ankur Sinha (FranciscoD) ---
Looks pretty good. Here is a first round of reviews. A few blockers here that
need fixing:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
--- Comment #2 from Ankur Sinha (FranciscoD) ---
A few notes already:
- We use the `fedora-review` tool for the first round of reviews, and that
downloads the spec/srpm from the bug here, so we need to make sure that the
links we provide
https://bugzilla.redhat.com/show_bug.cgi?id=1923830
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Status|NEW |ASSIGNED
23 matches
Mail list logo
