https://bugzilla.redhat.com/show_bug.cgi?id=1935255
Petr Viktorin changed:
What|Removed |Added
Status|POST|CLOSED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #14 from Tomas Hrcka ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-jaraco-path
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always noti
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
Miro Hrončok changed:
What|Removed |Added
Status|ASSIGNED|POST
Assignee|ksu...@redhat.co
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #12 from Karolina Surma ---
All looks good to me. The package can be APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #11 from Tomáš Hrnčiar ---
Apologies, disregard previous links. I made a couple of minor changes.
https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02060038-python-jaraco-path/py
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #10 from Tomáš Hrnčiar ---
Hello Karolina, here is the updated spec file, thank you.
https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02060023-python-jaraco-path/python-jaraco-pa
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #9 from Miro Hrončok ---
> I always struggle to use the correct GitHub URL's when working with archives.
The URLs that work are:
https://github.com///archive/.zip
https://github.com///archive/.tar.gz
https://github.com///archive/
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #8 from Tomáš Hrnčiar ---
(In reply to Miro Hrončok from comment #7)
> 1. Have you considered using this patch definition?
That's a good idea, I will do it.
> If you'd like to both use this AND have a nicer filename, you can do
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #7 from Miro Hrončok ---
Thanks Karolina for the detailed review. I'm here with just a few nit picks,
nothing is critical:
1. Have you considered using this patch definition?
Patch1: https://github.com/jaraco/jaraco.pa
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #6 from Karolina Surma ---
Hi Tomas,
The main issue was indeed solved.
There is a typo in %files section, in line: %exclude %dir
%{python3_sitelib}/jaraco/__pychache__ (should be: __pycache__) resulting in
both jaraco packages ow
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #5 from Tomáš Hrnčiar ---
Hello Karolina & Lumir,
thank you for the review. I have addressed your concerns. You can find the
updated spec file below.
https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #4 from Karolina Surma ---
Also as noted by Lumir, please make sure that the resulting package depends on
python3-jaraco containing the paths you're excluding here.
--
You are receiving this mail because:
You are on the CC list
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #3 from Karolina Surma ---
Hi Tomas,
The package builds, but when built, it doesn't contain the actual file(s) it's
supposed to have, there are only metadata and documentation.
There are also some changes that would be nice to in
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #2 from Lumír Balhar ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02049882-python-jaraco-path/python-jaraco-path.spec
SRPM URL:
https://download.copr.fedorainfra
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #1 from Tomáš Hrnčiar ---
I just realized I forgot to add a link to the patch.
https://patch-diff.githubusercontent.com/raw/jaraco/jaraco.path/pull/1.patch
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
Lumír Balhar changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
Miro Hrončok changed:
What|Removed |Added
Blocks||1933046
Referenced Bugs:
https://bu
17 matches
Mail list logo
