[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Jaroslav Škarvada changed: What|Removed |Added Status|NEW |CLOSED Resolution|---

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #16 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/servus -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #15 from Jaroslav Škarvada --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Otto Urpelainen changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #14

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Jaroslav Škarvada changed: What|Removed |Added Flags|needinfo?(jskarvad@redhat.c | |om)

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Otto Urpelainen changed: What|Removed |Added Flags||needinfo?(jskarvad@redhat.c

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Otto Urpelainen changed: What|Removed |Added Flags||fedora-review? --- Comment #11

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Otto Urpelainen changed: What|Removed |Added Assignee|rjeff...@redhat.com |otu...@iki.fi

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #10 from Jaroslav Škarvada --- (In reply to Jaroslav Škarvada from comment #9) Correct links: Spec URL: https://jskarvad.fedorapeople.org/servus/servus.spec RPM URL:

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #9 from Jaroslav Škarvada --- Spec URL: https://jskarvad.fedorapeople.org/servus/servus.spec SRPM URL: https://jskarvad.fedorapeople.org/servus/servus-1.5.2-2.fc33.src.rpm Hopefully all problems fixed :) I went with the 6.0.0

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #8 from Otto Urpelainen --- Thank you for the update. Other issues I listed are ok now, but the license question is still not completely right. LGPL is layered on top of GPL, so *both* LGPL and GPL license texts must be included.

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #7 from Jaroslav Škarvada --- > > > %{_libdir}/*.so.* > > > > Globbing all shared objects like this SHOULD NOT be done. At least the major > > version number should be fixed, so that ABI breaks are noticed on updates. > > So do

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #6 from Jaroslav Škarvada --- Spec URL: https://jskarvad.fedorapeople.org/servus/servus.spec SRPM URL: https://jskarvad.fedorapeople.org/servus/servus-1.5.2-2.fc33.src.rpm -- You are receiving this mail because: You are on the

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #5 from Jaroslav Škarvada --- (In reply to Otto Urpelainen from comment #1) Guys, thanks for review. > > For the bundling probably FESCO exception will be needed. > > Not anymore, nowadays the packager can decide to leave

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #4 from Rafael Jeffman --- Otto, Agreed. Thank your for correcting me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #3 from Otto Urpelainen --- (In reply to Rafael Jeffman from comment #2) > Hello Jarsolav, > > - There's are issues with the upstream source regarding missing > license files, and the issue was reported. The license file >

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #2 from Rafael Jeffman --- Hello Jarsolav, These were the itens I found that should be fixed in this package: - There's are issues with the upstream source regarding missing license files, and the issue was reported. The

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Otto Urpelainen changed: What|Removed |Added CC||otu...@iki.fi --- Comment #1 from

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Rafael Jeffman changed: What|Removed |Added CC||rjeff...@redhat.com

[Bug 1972445] Review Request: servus - Zeroconf discovery in C++

https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Jaroslav Škarvada changed: What|Removed |Added Blocks||976793 Referenced Bugs: