https://bugzilla.redhat.com/show_bug.cgi?id=2036758
Fedora Update System changed:
What|Removed |Added
Resolution|--- |ERRATA
Status|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--- Comment #19 from Fed
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
--- Comment #18 from
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #17 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-parsimonious
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always not
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #16 from Alessio ---
Great.
Thank you very much.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bu
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
Ben Beasley changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #15 from Ben
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #14 from Alessio ---
Whoops.
Thanks.
I added %autochangelog and also %autorelease
Spec URL:
https://alciregi.fedorapeople.org/python-parsimonious/python-parsimonious.spec
SRPM URL:
https://alciregi.fedorapeople.org/python-parsim
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #13 from Ben Beasley ---
Looks great (and beautifully straightforward!) except for a changelog format
issue:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues
==
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #12 from Ben Beasley ---
(In reply to Alessio from comment #10)
> I get this deprecation warning
>
> […]
>
> (If I'm not wrong, I've seen it using pyproject-rpm-macros also on another
> package). Is it expected?
I would expect
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #11 from Alessio ---
Whoops
New SPEC and SRPM:
Spec URL:
https://alciregi.fedorapeople.org/python-parsimonious/python-parsimonious.spec
SRPM URL:
https://alciregi.fedorapeople.org/python-parsimonious/python-parsimonious-0.8.1-1.f
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #10 from Alessio ---
Thank you very much.
I opted for the two patch files.
I asked upstream if there are any news on this PR
https://github.com/erikrose/parsimonious/pull/168#issuecomment-1007951362
I get this deprecation warning
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #9 from Ben Beasley ---
I see you converted to pyproject-rpm-macros, which is great! I’ll save the full
re-review until you have a chance to read my feedback on the patch, but here’s
what I see at a glance:
- Can drop
BuildRe
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #8 from Ben Beasley ---
With those patches, you can use the 0.8.1 release tarball as you did in your
original spec file.
I should have explained that process in the first place—I got lazy and hoped I
wouldn’t have to. ;-)
--
Yo
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #7 from Ben Beasley ---
Created attachment 1849573
--> https://bugzilla.redhat.com/attachment.cgi?id=1849573&action=edit
Combined patch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #6 from Ben Beasley ---
Created attachment 1849572
--> https://bugzilla.redhat.com/attachment.cgi?id=1849572&action=edit
Patch for second commit in PR
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #5 from Ben Beasley ---
Created attachment 1849571
--> https://bugzilla.redhat.com/attachment.cgi?id=1849571&action=edit
Patch for first commit in PR
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #4 from Ben Beasley ---
It looks like that patch works, but also reverts some commits in the original
upstream.
When a PR applies cleanly to the last release, you can just add .patch to its
URL, which is extremely convenient:
http
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #3 from Alessio ---
I managed to create the patch file in this way:
git clone https://github.com/erikrose/parsimonious.git
cd parsimonious
git remote add original https://github.com/swayson/parsimonious
git fetch original
git diff
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
--- Comment #2 from Alessio ---
> The most obvious choices are either
>
> - Rebase https://github.com/erikrose/parsimonious/pull/168 to the 0.8.1
> tag
> and apply it as a patch. This is the nicest choice if feasible. I can
>
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
Ben Beasley changed:
What|Removed |Added
Flags|needinfo?(code@musicinmybra |
|in.net)
https://bugzilla.redhat.com/show_bug.cgi?id=2036758
Ben Beasley changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|c...@musicinmybrain.net
Statu
21 matches
Mail list logo
