https://bugzilla.redhat.com/show_bug.cgi?id=2037645
Mark E. Fuller changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #28 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/cantera
--
You are receiving this mail because:
You are always notified about changes to this product and componen
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
Mark E. Fuller changed:
What|Removed |Added
Summary|Review Request: Cantera - |Review Request: cantera -
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #27 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/Cantera
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #26 from Mark E. Fuller ---
Thank you Jose, Christopher, and Dominik.
It's very gratifying to be able to contribute a package and I look forward to
participating even more in the future.
--
You are receiving this mail because:
Y
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
José Matos changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #25 from José
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #24 from Mark E. Fuller ---
I revised the spec and bumped the distribution: there's now a cantera-static
package that includes the two `.a` files such that they need not be downloaded
and installed unless specifically desired.
Spe
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #23 from José Matos ---
Running fedora-review identifies the following issues:
- Header files in -devel subpackage, if present.
Note: cantera-common :
/usr/share/cantera/samples/cxx/bvp/BoundaryValueProblem.h cantera-common
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
CC||domi...@greysector.net
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
Mark E. Fuller changed:
What|Removed |Added
Blocks||177841 (FE-NEEDSPONSOR)
Referenced
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
Mark E. Fuller changed:
What|Removed |Added
Depends On|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzill
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
Mark E. Fuller changed:
What|Removed |Added
Blocks||505154 (FE-SCITECH)
Referenced Bug
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #21 from Mark E. Fuller ---
Sorry about that.
Spec URL:
https://download.copr.fedorainfracloud.org/results/fuller/Cantera/srpm-builds/03132758/cantera.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/fuller/Canter
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #20 from José Matos ---
(In reply to Mark E. Fuller from comment #19)
> OK, I've implemented the changes and the koji build is at
> https://koji.fedoraproject.org/koji/taskinfo?taskID=80961831
> Everything seems to be working
>
>
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
Mark E. Fuller changed:
What|Removed |Added
Depends On||177841 (FE-NEEDSPONSOR)
Referenced
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #19 from Mark E. Fuller ---
OK, I've implemented the changes and the koji build is at
https://koji.fedoraproject.org/koji/taskinfo?taskID=80961831
Everything seems to be working
(Also the COPR builds are running without issue at
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #18 from José Matos ---
(In reply to Mark E. Fuller from comment #17)
> Thanks for all the advice - this is extremely helpful.
> Also sorry for the delay - it's the weekend in Israel.
There is no problem, Shabbat Shalom. :-)
> La
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #17 from Mark E. Fuller ---
Thanks for all the advice - this is extremely helpful.
Also sorry for the delay - it's the weekend in Israel.
Latest koji scratch build with the suggested modifications is at
https://koji.fedoraproject.
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #16 from José Matos ---
Could you, please, add the prefix=%{_prefix} to the scons install call?
Looking into packages that require scons to build I see that pattern.
# repoquery --disablerepo=* --enablerepo=rawhide-source --whatr
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #15 from Christopher Crouse ---
I modified the spec locally, and added the following to the %install section,
after the `scons install` command:
...
%if 0%{?fedora} > 35
mv %{buildroot}%{_prefix}/local/bin/ck2cti
%{buildroot}
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #14 from José Matos ---
(In reply to Mark E. Fuller from comment #12)
> Sorry, I forgot to add the link to the known problem/open issue with Cantera
> installing files in the wrong location:
> https://github.com/Cantera/cantera/iss
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #13 from Mark E. Fuller ---
The Koji scratch build is at
https://koji.fedoraproject.org/koji/taskinfo?taskID=80914079
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about chan
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #12 from Mark E. Fuller ---
Sorry, I forgot to add the link to the known problem/open issue with Cantera
installing files in the wrong location:
https://github.com/Cantera/cantera/issues/1149
--
You are receiving this mail becau
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #11 from Mark E. Fuller ---
Hi Jose,
Regarding the SRPM not building, this is a known problem for all but one
buildroot on Rawhide/F36 and it probably has to do with a problem in the
SConstruct file.
The SRPM builds properly under
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #10 from José Matos ---
In addition to Christopher's remark here are some other issues.
You should bump the release number after each change in the review process. It
becomes easier for us to see the progress between versions.
T
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #9 from Christopher Crouse ---
Looks much better now!
Some more comments:
- I noticed the changelog is in a nonstandard format. I would recommend using
"rpmdev-bumpspec", will handle adding the entry and formatting the entry
corr
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #8 from Mark E. Fuller ---
I made all the updates suggested so far to the spec file and have updated the
spec and SRPM accordingly
Spec URL:
https://download.copr.fedorainfracloud.org/results/fuller/Cantera/fedora-35-x86_64/031302
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #7 from Mark E. Fuller ---
Thank you both very much already.
I am making the suggested changes to the spec file right now.
Here are revised links for the spec and SRPM files:
Spec URL:
https://download.copr.fedorainfracloud.org/re
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
José Matos changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #6 from José Matos
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #5 from Christopher Crouse ---
(In reply to José Matos from comment #4)
> (In reply to Christopher Crouse from comment #2)
> > Hi Mark,
> >
> > Maybe I can give some pointers:
> >
> > [1] The spec *Source0:* URL can be simplified
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #4 from José Matos ---
(In reply to Christopher Crouse from comment #2)
> Hi Mark,
>
> Maybe I can give some pointers:
>
> [1] The spec *Source0:* URL can be simplified: `%{url}archive/main.tar.gz`
>
> [2] The spec %files sectio
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
--- Comment #3 from José Matos ---
When submitting a fedora review you should give the direct path to the srpm and
not just the folder.
This allows to make some steps in the review automatic. E.g. in order to help
me analyze the package I use
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
Christopher Crouse changed:
What|Removed |Added
CC||m...@amz-x.com
--- Comment #2 fr
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
José Matos changed:
What|Removed |Added
CC||jama...@fc.up.pt
Doc Type|---
34 matches
Mail list logo
