https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Alejandro Sáez Morollón changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Andreas Schneider changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--
You are recei
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #28 from Andreas Schneider ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If your application is a C or C++ application yo
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #27 from Jakub Kadlčík ---
Created attachment 1952874
--> https://bugzilla.redhat.com/attachment.cgi?id=1952874&action=edit
The .spec file difference from Copr build 5583255 to 5695433
--
You are receiving this mail because:
Y
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Alejandro Sáez Morollón changed:
What|Removed |Added
Flags|needinfo?(a...@redhat.com) |
--- Comment #26 from Alej
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Andreas Schneider changed:
What|Removed |Added
Flags||needinfo?(a...@redhat.com)
--
Y
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #25 from Andreas Schneider ---
Looking at the build.log from a fedora-review run, it doesn't look like tests
are being executed:
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.pzbvFD
+ umask 022
+ cd /builddir/build/BUILD
+ cd del
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #24 from Alejandro Sáez Morollón ---
Spec URL: https://alexsaezm.fedorapeople.org/rpms/delve/delve.spec
SRPM URL:
https://alexsaezm.fedorapeople.org/rpms/delve/delve-1.20.1-2.fc39.src.rpm
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #23 from Alejandro Sáez Morollón ---
Thanks for taking the review. I changed the %{_bindir}/* to %{_bindir}/dlv.
Regarding the name, as we discussed through chat, delve is a well-known app so
it doesn't need to follow the go namin
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #22 from Andreas Schneider ---
In the %check section:
delvepath=%{buildroot}/%{gopath}/src/%{goipath}
cp -r _fixtures $delvepath
cp -r pkg/dwarf/line/_testdata $delvepath/pkg/dwarf/line
pushd $delvepath
for d in $(go list ./... |
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Andreas Schneider changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|a...@redhat.com
--
You are rece
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #21 from Andreas Schneider ---
Reading https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/
I think the Name: should be %{goname}
And the spec name should follow that?
--
You are receiving this mail because:
You a
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Andreas Schneider changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #20 fr
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Andreas Schneider changed:
What|Removed |Added
CC||a...@redhat.com
Status|
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #18 from Alejandro Sáez Morollón ---
COPR repository with the latest version of Delve built for aarch64 and x86_64
for Fedora 36, 37, and Rawhide in case someone wants to review the package:
https://copr.fedorainfracloud.org/coprs
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Alejandro Sáez Morollón changed:
What|Removed |Added
Flags||needinfo?(zebo...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #15 from Alejandro Sáez Morollón ---
Spec URL:
https://src.fedoraproject.org/fork/alexsaezm/rpms/delve/raw/rawhide/f/delve.spec
SRPM URL:
https://alexsaezm.fedorapeople.org/rpms/delve/delve-1.20.1-1.fc38.src.rpm
Description: Delve
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #14 from Alejandro Sáez Morollón ---
(In reply to Alejandro Sáez Morollón from comment #13)
> Spec URL:
> https://src.fedoraproject.org/fork/alexsaezm/rpms/delve/raw/rawhide/f/delve.
> spec
> SRPM URL:
> https://alexsaezm.fedorapeo
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #13 from Alejandro Sáez Morollón ---
Spec URL:
https://src.fedoraproject.org/fork/alexsaezm/rpms/delve/raw/rawhide/f/delve.spec
SRPM URL:
https://alexsaezm.fedorapeople.org/rpms/delve/delve-1.9.0-2.fc37.src.rpm
Description: Delve i
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #12 from Mark E. Fuller ---
Also v1.9.0 has just been released:
https://github.com/go-delve/delve/releases/tag/v1.9.0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about chan
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #11 from Robert-André Mauchin 🐧 ---
# Currently Delve only supports x86_64
%global golang_arches x86_64 aarch64
needs to be higher up in the spec. Macros define ExclusiveArch: just below
Version, so it needs to be above.
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #10 from Alejandro Sáez Morollón ---
(In reply to Alejandro Sáez Morollón from comment #9)
> FYI: There's a problem with starlark, delve uses an old version of this and
> the newer version that we have in Fedora breaks tests.
> I'm
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #9 from Alejandro Sáez Morollón ---
FYI: There's a problem with starlark, delve uses an old version of this and the
newer version that we have in Fedora breaks tests.
I'm working on this.
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Mark E. Fuller changed:
What|Removed |Added
CC||mark.e.ful...@gmx.de
--- Comment #8
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Alejandro Sáez Morollón changed:
What|Removed |Added
Flags|needinfo?(a...@redhat.com) |
--- Comment #7 from Aleja
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #6 from Robert-André Mauchin 🐧 ---
Wait there's more:
You need to use
%description
%{common_description}
%gopkg <--
%prep
%goprep
no self defined devel package.
Similarly the %files for devel shouldn't be defined manu
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Flags||needinfo?(a...@redhat.com)
-
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #4 from Alejandro Sáez Morollón ---
Thanks for the notes. Those were legacy things I did when I started and totally
forgot to remove them.
I updated the links.
--
You are receiving this mail because:
You are always notified abou
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #3 from Robert-André Mauchin 🐧 ---
Don't:
# Currently Delve only supports x86_64
ExcludeArch:ppc64le
ExcludeArch:s390x
ExcludeArch:aarch64
ExcludeArch:i686
ExcludeArch:armv7hl
instead redefine golang_arches to
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Flags||fedora-review?
Assig
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
--- Comment #1 from Alejandro Sáez Morollón ---
This is retired package that the Go SIG is interested in claim back.
Currently this package depends on this other other two reviews:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2102385
31 matches
Mail list logo
