[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rfc3986-validator -- You are receiving this mail because: You are on the CC list for the bug. You are alway

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #9 from chedi toueiti --- @maxwell I'm the one who has to thank you for your patience and thorough review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on t

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 Maxwell G changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #7 from chedi toueiti --- done, please check again (same links) https://chedi.fedorapeople.org/python-rfc3986-validator.spec https://chedi.fedorapeople.org/python-rfc3986-validator-0.1.0-1.fc37.src.rpm -- You are receiving thi

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #6 from Maxwell G --- Thanks for incorporating my changes. > - I prefer to keep that convention with slugname even if used once if you > don't mind I don't agree with it, but as I said, it's up to you :). > - added a patch remo

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #5 from chedi toueiti --- here is the last update with the following changes: - added the period to the common_description - added a patch removing the pytest-runner from the setup.py (I'll try to escalate the issue upstream) - I

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #4 from Maxwell G --- Sure, no problem! (In reply to Maxwell G from comment #1) > > %global common_description %{expand: > > A pure python RFC3986 validator > > } > > This should end with a period. Don't forget to fix this. > %

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #3 from chedi toueiti --- @maxwell thanks for taking the time to review this package, I didn't add checks because the tests are using another package (rfc3987) not present yet in fedora. the new version with the necessary correct

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 Maxwell G changed: What|Removed |Added Assignee|nob...@fedoraproject.org|gotmax@e.email Flags|

[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

2022-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 Maxwell G changed: What|Removed |Added CC||gotmax@e.email Doc Type|---