[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-09-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #12 from Renich Bon Ciric --- Hello, Benson. So, I've had a conversation with upstream and Lorenzo has a few request: https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/ylBv2-_hAgAJ package rename -- He's a

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-09-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #11 from Renich Bon Ciric --- Right on. Here's the sub-packaged ... err... package: Spec URL: https://renich.fedorapeople.org/janus-gateway/janus-gateway.spec SRPM URL: https://renich.fedorapeople.org/janus-gateway/janus-gateway-

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-09-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #10 from Benson Muite --- Great. Can you subpackage? This is helpful for re-usability. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and compon

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-09-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #9 from Renich Bon Ciric --- OK, asked the questions and got a response from the developer: https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/k1fXZQr0AQAJ In short: c) No codecs used by the main app. Only one plugin tra

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-09-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #8 from Renich Bon Ciric --- Forgot to post the files: Spec URL: https://renich.fedorapeople.org/janus-gateway/janus-gateway.spec SRPM URL: https://renich.fedorapeople.org/janus-gateway/janus-gateway-1.0.4-4.fc36.src.rpm -- You

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-09-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #7 from Renich Bon Ciric --- OK, sorry for the delay. > a) Should the .sample files go in the documentation directory? OK, done. Moved all sample files to %{_docdir} as part of the main package (not the -doc package). > b) Mig

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-09-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #6 from Benson Muite --- Thanks for the update. Fedora Review now runs: Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Packag

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-08-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Benson Muite changed: What|Removed |Added Status|NEW |ASSIGNED Flags|

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-08-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #5 from Renich Bon Ciric --- You rock! i definitely owe you one. :D Fixed most of the issues. Let me address a few, though: > Do all the tests need network access? IF not, it would be good to try to run > those that do not. It

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-08-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #4 from Benson Muite --- Licenses used: *No copyright* GNU General Public License, Version 3 janus-gateway-1.0.4/README.md janus-gateway-1.0.4/bower.json janus-gateway-1.0.4/npm

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-08-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #3 from Benson Muite --- Thanks. Can probably also remove automake and autoconf, and add gcc see https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_packaging Probably adding systemd to BuildRequires rather than

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-08-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #2 from Renich Bon Ciric --- (In reply to Benson Muite from comment #1) > fedora-review did not complete for me. Got the following error: > > RPM build errors: > File must begin with "/": %{_unitdir}/janus-gateway.service > Ch

[Bug 2121585] Review Request: janus-gateway - An open source general purpose WebRTC server.

2022-08-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Benson Muite changed: What|Removed |Added CC||benson_mu...@emailplus.org Doc