Product: Fedora
Version: rawhide
Component: Package Review
Benson Muite has canceled Package Review
's request for Benson Muite
's needinfo:
Bug 2142006: Review Request: VulkanSceneGraph - A modern, cross platform, high
performance scene graph library built upon Vulkan graphics/c
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
Benson Muite changed:
What|Removed |Added
Flags|needinfo?(benson_muite@emai |
|lplus.org)
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #13 from Benson Muite ---
If it is easy to add man pages, that would be great.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
There may be cases where one may not want to also have a web browser
running when
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #12 from Benson Muite ---
From fedora-review
[!]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 109824000 bytes in /usr/share
VulkanSceneGraph-do
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #11 from François Cami ---
I can generate them, it's a sed away in the build directory:
$ sed -i s/GENERATE_MAN.*/GENERATE_MAN\ =\ YES/g Doxyfile.docs-vsg
However:
* the package ships no binaries
* "make install" does not install
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #10 from Benson Muite ---
Can you also generate man pages? See
https://www.doxygen.nl/manual/config.html#cfg_generate_man
Checking javascript and fonts in the generated HTML documentation.
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #8 from François Cami ---
Thanks!
Spec URL: https://fcami.fedorapeople.org/srpms/vsg/VulkanSceneGraph.spec
SRPM URL:
https://fcami.fedorapeople.org/srpms/vsg/VulkanSceneGraph-1.0.0-1.fc35.src.rpm
Changes:
* Upstream replaced the
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #7 from Benson Muite ---
Known issue with rpmlint and the SPDX identifiers. Other things raised by
fedora-review:
Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define releasecan
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #6 from François Cami ---
Thanks!
* libvsg.so / libvsg.so.* is correctly split now, I think
* License breakdown provided in spec file and the License: flag was updated (
https://docs.fedoraproject.org/en-US/legal/license-field/ )
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #5 from Benson Muite ---
When running Fedora-review
Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files directly in %_libdir.
See: https://docs.fedoraproject.org/e
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
Benson Muite changed:
What|Removed |Added
Flags||fedora-review?
Status|NEW
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #4 from François Cami ---
Changes:
* switched to 0.1%{dist} as per comment#3
* added -libs
* version is now determined from two variables rather than hardcoded
Spec URL: https://fcami.fedorapeople.org/srpms/vsg/VulkanSceneGraph.sp
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #3 from François Cami ---
I'm unclear about what to do wrt:
https://fedoraproject.org/wiki/User:Tibbs/VersioningCleanup#Prerelease_versions
Should it look like:
Release:1%{?dist}
Or:
Release:0.1%{?dist}
--
You a
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
--- Comment #2 from François Cami ---
How to test:
$ git clone https://github.com/vsg-dev/MyFirstVsgApplication
$ cd MyFirstVsgApplication/
$ mkdir build ; cd build
$ cmake ..
$ make
$ ls
$ bin/myfirstvsgapplication ../models/glider.vsgt
-
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
François Cami changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
--- Comme
15 matches
Mail list logo