[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 Tomi Lähteenmäki changed: What|Removed |Added Resolution|--- |RAWHIDE Status|POST

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #22 from Vasiliy Glazov --- If you plan build and add to repos for other releases (f38, f37, f36, epel9...) you should request that branches. You can close this ticket after rawhide build or after target release build. -- You a

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #21 from Tomi Lähteenmäki --- SCM repository created and committed the sources for rawhide. Bodhi update seemed to trigger automatically: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9449c4062f. Should I also create f38 bran

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #20 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/numberstation -- You are receiving this mail because: You are on the CC list for the bug. You ar

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #19 from Vasiliy Glazov --- Done. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=215128

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #17 from Jakub Kadlčík --- Created attachment 1942002 --> https://bugzilla.redhat.com/attachment.cgi?id=1942002&action=edit The .spec file difference from Copr build 5255606 to 5430141 -- You are receiving this mail because: Y

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #18 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5430141 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2151289-numberstation/fedora

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #16 from Tomi Lähteenmäki --- Forgot to link latest SPRM: Spec URL: https://pagure.io/numberstation/raw/master/f/numberstation.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lihis/numberstation/fedora-37-x86_64/

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #15 from Vasiliy Glazov --- Seems good now. I will sponsor you. What is your FAS login? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and compo

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #14 from Tomi Lähteenmäki --- > 1. You must explay why explicitly disable debuginfo Thanks for the link, now I know how to use it properly. > 2. No need to describe each file and directory at %files section ... Okay, that's good

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #13 from Vasiliy Glazov --- 1. You must explay why explicitly disable debuginfo https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages If it is because package noarch than it is not needed. RPM will do it h

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #12 from Tomi Lähteenmäki --- Thanks for the review! > 1. Why %global debug_package %{nil} ? No reason, removed it. > 2. Change I'm not sure about what you exactly want, could you elaborate? > 4. Add to %check section: The ap

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #11 from Vasiliy Glazov --- 5. Change %setup -n %{name}-%{version} to %autosetup -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component htt

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-02-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 Vasiliy Glazov changed: What|Removed |Added CC||vasc...@gmail.com --- Comment #10 fr

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 Petr Menšík changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review?

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #7 from Jakub Kadlčík --- Created attachment 1939210 --> https://bugzilla.redhat.com/attachment.cgi?id=1939210&action=edit The .spec file difference from Copr build 5252620 to 5255606 -- You are receiving this mail because: Yo

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #8 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5255606 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2151289-numberstation/fedora-

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #6 from Tomi Lähteenmäki --- Missed the sub-directory under the "%{_datadir}/%{name}" so pushed once more. Spec URL: https://pagure.io/numberstation/raw/master/f/numberstation.spec SRPM URL: https://download.copr.fedorainfracloud.

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #5 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5252620 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2151289-numberstation/fedora-

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #4 from li...@lihis.net --- Thanks for the review! The issues are now fixed and the package can be reviewed again. However, I'm not sure about the rpmlint error "E: explicit-lib-dependency libhandy". If it is not explicitly requir

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 Petr Menšík changed: What|Removed |Added Flags||fedora-review? -- You are receiving t

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 --- Comment #3 from Petr Menšík --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package installs a %{name}.desktop using desktop-file-i

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 Petr Menšík changed: What|Removed |Added Assignee|nob...@fedoraproject.org|pemen...@redhat.com Status|NE

[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

2023-01-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 Petr Menšík changed: What|Removed |Added Doc Type|--- |If docs needed, set a value B