https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Carl George š¤ changed:
What|Removed |Added
Fixed In Version||mod_auth_cas-1.2-4.fc39
Sta
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Carl George š¤ changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
Status|ASSIG
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #30 from Scott Williams ---
I rebuilt it with Fedora Review enabled and it looks like the patching and
whitespace issues are now taken care of:
Review:
https://download.copr.fedorainfracloud.org/results/vwbusguy/mod_auth_cas/fedor
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #29 from Scott Williams ---
Looks like the review service is failing to trigger now, so you can find the
copr build against this change here:
https://copr.fedorainfracloud.org/coprs/vwbusguy/mod_auth_cas/build/5646180/
--
You ar
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #28 from Scott Williams ---
Ah, thanks for the tip (re: autosetup). Looks like the patches are in order
now.
[fedora-review-service-build]
Spec URL:
https://download.copr.fedorainfracloud.org/results/vwbusguy/mod_auth_cas/fedora-
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #27 from Scott Williams ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/vwbusguy/mod_auth_cas/fedora-rawhide-x86_64/05646180-mod_auth_cas/mod_auth_cas.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/resul
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Carl George š¤ changed:
What|Removed |Added
Flags|needinfo?(c...@redhat.com) |
--- Comment #26 from Carl George š¤
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #25 from Scott Williams ---
I'm also noticing that the spec file still references pcre-devel and not
pcre2-devel, which seems to indicate that neither patch was applied.
--
You are receiving this mail because:
You are always not
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Scott Williams changed:
What|Removed |Added
Flags||needinfo?(c...@redhat.com)
--- Comme
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #23 from Jakub KadlÄĆk ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5645444
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173751-mod_auth_cas/fedora-
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #22 from Jakub KadlÄĆk ---
Created attachment 1950826
--> https://bugzilla.redhat.com/attachment.cgi?id=1950826&action=edit
The .spec file difference from Copr build 5603291 to 5645444
--
You are receiving this mail because:
Y
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #21 from Timothy Hansen ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/vwbusguy/mod_auth_cas/fedora-rawhide-x86_64/05645429-mod_auth_cas/mod_auth_cas.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/resul
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #20 from Scott Williams ---
Patches submitted to Tim's repo:
https://github.com/thansen11/mod_auth_cas_rpm/pull/3/files
--
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #19 from Scott Williams ---
"We don't necessarily need to wait for upstream to merge that and the pcre2
change. We can include them in the package as patch files, with comments
linking to their upstream PRs. In fact I recommend d
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #18 from Carl George š¤ ---
I was just about to comment on that m4 thing. Thanks for sending that
upstream.
We don't necessarily need to wait for upstream to merge that and the pcre2
change. We can include them in the package as
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #17 from Scott Williams ---
PR submitted upstream: https://github.com/apereo/mod_auth_cas/pull/210
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #16 from Scott Williams ---
Ah, well, the answer seems to be right there. Putting `LT_INIT` where I
removed AC_PROD_LIBTOOL seems to compile just fine. I'll submit another PR
upstream.
--
You are receiving this mail because:
Y
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #15 from Scott Williams ---
The m4 macro thing looks like it's not going to be as trivial as removing it
from the config.ac:
```
src/Makefile.am:6: error: Libtool library used but 'LIBTOOL' is undefined
src/Makefile.am:6: The us
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #14 from Scott Williams ---
Looks like we might be close:
```
[!]: Reviewer should test that the package builds in mock.
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #13 from Jakub KadlÄĆk ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5603291
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173751-mod_auth_cas/fedora-
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #12 from Jakub KadlÄĆk ---
Created attachment 1948707
--> https://bugzilla.redhat.com/attachment.cgi?id=1948707&action=edit
The .spec file difference from Copr build 5575004 to 5603291
--
You are receiving this mail because:
Y
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #11 from Timothy Hansen ---
Made recommended changes to spec file. PCRE2 pull request upstream is being
reviewed: https://github.com/apereo/mod_auth_cas/pull/209
[fedora-review-service-build]
Spec URL:
https://download.copr.fedora
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Scott Williams changed:
What|Removed |Added
Link ID||Github
|
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #10 from Scott Williams ---
Patch submitted upstream: https://github.com/apereo/mod_auth_cas/pull/209
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this prod
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #9 from Scott Williams ---
For what it's worth, I'm trying to see if I can submit a patch upstream to
support PCRE2. I'm pretty close to getting it working, but working around kids
is hard..
--
You are receiving this mail becau
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #8 from Carl George š¤ ---
Thanks for submitting this re-review. This is a fairly old spec file, so it
will need a bit of cleaning up to bring it up to modern Fedora packaging
standards. Don't get discouraged by the following wall
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #7 from Jakub KadlÄĆk ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5575004
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173751-mod_auth_cas/fedora-r
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #6 from Jakub KadlÄĆk ---
Created attachment 1946802
--> https://bugzilla.redhat.com/attachment.cgi?id=1946802&action=edit
The .spec file difference from Copr build 5574725 to 5575004
--
You are receiving this mail because:
Yo
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #5 from Scott Williams ---
Just trying to trigger the updated review.
[fedora-review-service-build]
Spec URL:
https://download.copr.fedorainfracloud.org/results/vwbusguy/mod_auth_cas/fedora-rawhide-x86_64/05574866-mod_auth_cas/mod
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #4 from Scott Williams ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/vwbusguy/mod_auth_cas/fedora-rawhide-x86_64/05574866-mod_auth_cas/mod_auth_cas.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/resul
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Scott Williams changed:
What|Removed |Added
Link ID||Red Hat Bugzilla 1934268
--
You ar
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Scott Williams changed:
What|Removed |Added
CC||vwfoxg...@gmail.com
--- Comment #3 f
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
--- Comment #2 from Timothy Hansen ---
https://download.copr.fedorainfracloud.org/results/vwbusguy/mod_auth_cas/fedora-rawhide-x86_64/05574866-mod_auth_cas/
--
You are receiving this mail because:
You are always notified about changes to th
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Jakub KadlÄĆk changed:
What|Removed |Added
URL||http://www.ja-sig.org/wiki/
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
Carl George š¤ changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
35 matches
Mail list logo
