https://bugzilla.redhat.com/show_bug.cgi?id=2238751
Fedora Update System changed:
What|Removed |Added
Resolution|--- |ERRATA
Status|MODIFI
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
Fedora Update System changed:
What|Removed |Added
Status|POST|MODIFIED
--- Comment #25 from
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #24 from Marc-Andre Lureau ---
(In reply to Fabio Valentini from comment #23)
> I see that you tried building the package and got stopped by some changes I
> pushed to the cargo RPM macros a few days ago. Sorry about that!
> I push
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #23 from Fabio Valentini ---
I see that you tried building the package and got stopped by some changes I
pushed to the cargo RPM macros a few days ago. Sorry about that!
I pushed a followup fix to dist-git for that, the package now
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #22 from Fedora Admin user for bugzilla script actions
---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rutabaga-gfx-ffi
--
You are receiving this mail because:
You are always notified about changes t
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
Fabio Valentini changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #20 from Marc-Andre Lureau ---
(In reply to Fabio Valentini from comment #18)
> Thanks for the update. Can you verify that the new version builds?
it builds for me on f39 (rawhide toolbox is kinda broken for me atm, due to
dnf5 tr
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #19 from Fabio Valentini ---
Looks like there's still some weirdness going on due to the unusual directory /
workspace setup in the upstream project ...
You might need to run %cargo_generate_buildrequires twice, like this?
"""
%ge
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #18 from Fabio Valentini ---
Thanks for the update. Can you verify that the new version builds?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list f
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #17 from Marc-Andre Lureau ---
(In reply to Fabio Valentini from comment #16)
> (In reply to Marc-Andre Lureau from comment #15)
> > (In reply to Fabio Valentini from comment #14)
> > > > error: no matching package named `once_cell
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #16 from Fabio Valentini ---
(In reply to Marc-Andre Lureau from comment #15)
> (In reply to Fabio Valentini from comment #14)
> > > error: no matching package named `once_cell` found
> > > location searched: registry `crates-io`
>
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #15 from Marc-Andre Lureau ---
(In reply to Fabio Valentini from comment #14)
> > error: no matching package named `once_cell` found
> > location searched: registry `crates-io`
>
> You need to run `%cargo_generate_buildrequires` i
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #14 from Fabio Valentini ---
> I couldn't easily find any rust package using that btw. fixed
There's over 2000 Rust packages, and they are only being transitioned from BR:
rust-packaging to BR: cargo-rpm-macros over time.
> Well,
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #13 from Marc-Andre Lureau ---
(In reply to Fabio Valentini from comment #12)
> > > 10. Please bump the BuildRequires from "rust-packaging >= 21" to
> > > "cargo-rpm-macros".
> > > The "rust-packaging" package no longer exists and
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #12 from Fabio Valentini ---
> > 10. Please bump the BuildRequires from "rust-packaging >= 21" to
> > "cargo-rpm-macros".
> > The "rust-packaging" package no longer exists and is only provided by
> > "cargo-rpm-macros" for backward
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #11 from Marc-Andre Lureau ---
(In reply to Fabio Valentini from comment #8)
> Thanks for the update, and sorry for the wait.
No worries (the QEMU side isn't yet merged upstream, and I am not sure when we
will actually have users)
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #10 from Marc-Andre Lureau ---
(In reply to Fabio Valentini from comment #9)
> i.e. replace the line
> %{_libdir}/librutabaga_gfx_ffi.so.*
> with
> %{_libdir}/librutabaga_gfx_ffi.so.0{,.*}
done
--
You are receiving this mail be
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #9 from Fabio Valentini ---
Oh, and another one:
11. Don't use a broad glob to list the shared library in %files:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
i.e. replace the line
%{_l
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #8 from Fabio Valentini ---
Thanks for the update, and sorry for the wait.
Package looks mostly good to me, there's just a few remaining issues:
1. The "make-snapshot.sh" script is not included in the SRPM. It should be
included a
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #7 from Marc-Andre Lureau ---
(In reply to Fabio Valentini from comment #6)
> > - generate_buildrequires needs to be during %prep, because sources must be
> > extracted (that's also how rust-ripgrep does)
>
> This is a misunderst
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
Fabio Valentini changed:
What|Removed |Added
Flags||fedora-review?
Assignee|nob
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #5 from Marc-Andre Lureau ---
- generate_buildrequires needs to be during %prep, because sources must be
extracted (that's also how rust-ripgrep does)
- fixed the -a/-n flags
- %cargo_build ok, however debugsourcefiles.list is stil
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #4 from Fabio Valentini ---
Thanks! I'll take another look later.
Note that the project's directory structure / setup is a bit unusual. It looks
like most of the functionality of this project is disabled by default:
> [features]
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #3 from Marc-Andre Lureau ---
thanks Fabio for the quick review!
1. ok I'll fix the flags
"cargo build" is called from the "build" Makefile target. I suppose we could
replace it with %cargo_* macros (as long as I can specify the
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
Fabio Valentini changed:
What|Removed |Added
CC||decatho...@gmail.com
--- Comment #2
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
--- Comment #1 from Marc-Andre Lureau ---
there is an issue with the library SONAME
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugz
https://bugzilla.redhat.com/show_bug.cgi?id=2238751
Marc-Andre Lureau changed:
What|Removed |Added
Alias||rutabaga-gfx-ffi
--
You are rec
27 matches
Mail list logo
