https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Fedora Update System changed:
What|Removed |Added
Resolution|--- |ERRATA
Status|MODIFI
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
--- Comment #22 from
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #21 from Beck Liu ---
Many thanks for the review work of the package and sponsoring me into the
packager group. I will look the contents that are in the links you listed.
--
You are receiving this mail because:
You are always no
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #20 from Fedora Admin user for bugzilla script actions
---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/libheinz
--
You are receiving this mail because:
You are always notified about changes to this p
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #19 from Miroslav Suchý ---
I added you to the Packager Group. (if you logged to src.fedoraproject.org
before you have to sign out and sign in again)
> Due to that I am not an English native speaker, so my insufficient English
>
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Miroslav Suchý changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|need
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Beck Liu changed:
What|Removed |Added
Flags||needinfo?(msu...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #16 from Fedora Review Service
---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6706846
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251523-libheinz/fe
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #15 from Fedora Review Service
---
Created attachment 2002051
--> https://bugzilla.redhat.com/attachment.cgi?id=2002051&action=edit
The .spec file difference from Copr build 6704146 to 6706846
--
You are receiving this mail b
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #14 from Beck Liu ---
update: remove the license of catch2 and related bundled line, add a bit more
expressive description
Spec URL:
https://download.copr.fedorainfracloud.org/results/shattuckite/bornagain/fedora-rawhide-x86_64/06
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #13 from Beck Liu ---
> Hmm the file libheinz/test/catch.hpp is a test. The test is not included in
> the binary package.
> https://docs.fedoraproject.org/en-US/legal/license-field/#_basic_policy
Ok, I see. Thanks for the furthe
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #12 from Miroslav Suchý ---
Hmm the file libheinz/test/catch.hpp is a test. The test is not included in the
binary package.
https://docs.fedoraproject.org/en-US/legal/license-field/#_basic_policy
So you do not need to specify the
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Miroslav Suchý changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|msu...@redhat.com
--
You are recei
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #11 from Miroslav Suchý ---
> The library is header-only, so I think it does not contain the debug
> information.
I never reviewed a package like this one. I checked with another maintainer and
it seems correct.
> I see that th
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #10 from Fedora Review Service
---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6704146
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251523-libheinz/fe
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #9 from Fedora Review Service
---
Created attachment 2001922
--> https://bugzilla.redhat.com/attachment.cgi?id=2001922&action=edit
The .spec file difference from Copr build 6700405 to 6704146
--
You are receiving this mail be
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #8 from Beck Liu ---
update with SPEC and SRPM:
I see that there is third-party catch2 library in the source code of libheinz,
which is https://jugit.fz-juelich.de/mlz/libheinz/-/blob/main/test/catch.hpp.
And I look through the li
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #7 from Beck Liu ---
Thanks for your time to take the package review.
> This is definitely not good. Why you did it?
The library is header-only, so I think it does not contain the debug
information.
> It is advised that you inc
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Miroslav Suchý changed:
What|Removed |Added
CC||msu...@redhat.com
Status|N
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Fedora Review Service changed:
What|Removed |Added
URL||https://jugit.fz-juelich.de
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Beck Liu changed:
What|Removed |Added
Blocks||177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #4 from Beck Liu ---
The copr build in last comment:
https://copr.fedorainfracloud.org/coprs/shattuckite/bornagain/build/6694777
--
You are receiving this mail because:
You are always notified about changes to this product and c
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #3 from Beck Liu ---
[fedora-review-service-build]
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #2 from Beck Liu ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/shattuckite/bornagain/fedora-rawhide-x86_64/06694777-libheinz/libheinz.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/shattuckite/
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
--- Comment #1 from Fedora Review Service
---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6695812
(failed)
Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251523-libheinz/srpm-builds/
https://bugzilla.redhat.com/show_bug.cgi?id=2251523
Beck Liu changed:
What|Removed |Added
Blocks||2251524
Referenced Bugs:
https://bugzil
26 matches
Mail list logo
