https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #20 from Guillermo Gómez guillermo.go...@gmail.com ---
Please be this comment just to note that im ok with the new review and Ken and
I talked about it off line and we are ok and in good terms. :)
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #19 from Guillermo Gómez guillermo.go...@gmail.com ---
I was about today to work on this. Nobody reviewed the bug during the history
of it, it was always an open discussion. Closing it this way is just rude.
That's not the Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Ken Dreyer ktdre...@ktdreyer.com changed:
What|Removed |Added
Status|NEW |CLOSED
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #17 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Guillermo, just checking to see if you've had a chance to review those
patches and merge them into your unicorn package? It would be great to get
unicorn into Fedora.
I've updated
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #16 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Guillermo,
I noticed something else that can be changed in the packaging today.
20. skip .gitkeep removals. This commit removes the find + rm command that
deletes the .gitkeep
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #15 from Guillermo Gómez guillermo.go...@gmail.com ---
Well, i'm not just repeating exactly the same line over and over (just for
people not viewing the code in which case that would just stupid, basically the
reason for me to
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #12 from Guillermo Gómez guillermo.go...@gmail.com ---
Thanks Ken for your contributions :), i will make changes an update my spec for
f20 and look for a reviewer (probably today). Package yet needs to be approved.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #13 from Guillermo Gómez guillermo.go...@gmail.com ---
(In reply to Vít Ondruch from comment #5)
(In reply to comment #4)
Not sure what is the issue with the test suite, but if you run the tests
independently, there is no point
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #14 from Vít Ondruch vondr...@redhat.com ---
Well, have many repeating lines has nothing to do with readability. This
applies to the sed lines as well as the testrb lines.
If you want to disable single file, it is better to disable
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #11 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Guillermo, I've pushed a couple more patches to Git:
15. use gem_docdir macro. This commit uses the gem_docdir macro in the %files
list instead of manually specifying the same thing.
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Ken Dreyer ktdre...@ktdreyer.com changed:
What|Removed |Added
Flags|needinfo?(ktdreyer@ktdreyer |
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags|
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Guillermo Gómez guillermo.go...@gmail.com changed:
What|Removed |Added
Assignee|guillermo.go...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #7 from Axilleas Pipinellis axill...@archlinux.gr ---
Hey Guillermo, are you still on to this? If not I'd like to take over, thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Guillermo Gómez guillermo.go...@gmail.com changed:
What|Removed |Added
Flags|needinfo?(guillermo.gomez@g |
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Guillermo Gómez guillermo.go...@gmail.com changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Jason Tibbitts ti...@math.uh.edu changed:
What|Removed |Added
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Ken Dreyer ktdre...@ktdreyer.com changed:
What|Removed |Added
CC|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Vít Ondruch vondr...@redhat.com changed:
What|Removed |Added
CC|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #3 from Guillermo Gómez guillermo.go...@gmail.com ---
(In reply to comment #2)
Guillermo: Not sure if you're still working on this package or not, but I
made a few changes to clean it up and upgrade to 4.5.0.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=786636
--- Comment #4 from Julian C. Dunn jd...@aquezada.com ---
Cool, no problem.
I managed to work around the build problem. It's a namespace conflict when
running under testrb, so I applied a patch to rename the test class. This SRPM
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Julian C. Dunn jd...@aquezada.com changed:
What|Removed |Added
CC|
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=786636
Michael Scherer m...@zarb.org changed:
What|Removed |Added
23 matches
Mail list logo
