https://bugzilla.redhat.com/show_bug.cgi?id=833462
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|ON_QA |CLOSED
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #22 from Fedora Update System upda...@fedoraproject.org ---
hawkey-0.2.5-1.git042738b.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/hawkey-0.2.5-1.git042738b.fc17
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|MODIFIED|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #12 from Scott Tsai scottt...@gmail.com ---
This review is against the latest .spec file in hawkey git:
1. Remove python2 from BuildRequires
python2-devel pulls it in anyway.
-BuildRequires: python2 python2-devel
+BuildRequires:
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #13 from Scott Tsai scottt...@gmail.com ---
Ales,
while I have your attention I'll raise a few issue non-packaging related issues
that I see in hawkey:
1. You don't tag your releases in git.
Instead you seem to commit a change to
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #14 from Ales Kozumplik akozu...@redhat.com ---
(In reply to comment #12)
This review is against the latest .spec file in hawkey git:
I've uploaded a copy of hawkey.spec with my recommended changes above here:
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #15 from Ales Kozumplik akozu...@redhat.com ---
(In reply to comment #13)
Ales,
while I have your attention I'll raise a few issue non-packaging related
issues that I see in hawkey:
1. You don't tag your releases in git.
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Scott Tsai scottt...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
---
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #17 from Ales Kozumplik akozu...@redhat.com ---
APPROVED.
Thank you for the review and the patches.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Ales Kozumplik akozu...@redhat.com changed:
What|Removed |Added
Flags||fedora-cvs?
---
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #19 from Scott Tsai scottt...@gmail.com ---
(In reply to comment #17)
Best of luck on improving package management in Fedora.
BTW, where is a good place to discuss hawkey and dnf development?
I'd like to know more about the problems
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #20 from Ales Kozumplik akozu...@redhat.com ---
(In reply to comment #19)
(In reply to comment #17)
Best of luck on improving package management in Fedora.
BTW, where is a good place to discuss hawkey and dnf development?
I'd
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #21 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).
No need to request f18, devel is automatic.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #11 from Ales Kozumplik akozu...@redhat.com ---
(In reply to comment #10)
(In reply to comment #9)
Ales, with your latest patch, the Requires generated seems fine.
Looking at the files included in the hawkey RPMS, one thing that
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #10 from Scott Tsai scottt...@gmail.com ---
(In reply to comment #9)
Ales, with your latest patch, the Requires generated seems fine.
Looking at the files included in the hawkey RPMS, one thing that stands out is
that it's a C
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #9 from Ales Kozumplik akozu...@redhat.com ---
(In reply to comment #8)
Although the section at
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
focuses on explicit library package deps, its bottom is meant to
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #8 from Michael Schwendt mschwe...@gmail.com ---
Although the section at
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
focuses on explicit library package deps, its bottom is meant to be understood
like
In the
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Michael Schwendt mschwe...@gmail.com changed:
What|Removed |Added
Blocks||833511
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #6 from Michael Schwendt mschwe...@gmail.com ---
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
| MUST: rpmlint must be run on the source rpm and all binary rpms
| the build produces. The output should be posted in the
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #7 from Ales Kozumplik akozu...@redhat.com ---
Updated version:
http://akozumpl.fedorapeople.org/review/hawkey_3/hawkey.spec
http://akozumpl.fedorapeople.org/review/hawkey_3/hawkey-0.2.4-7.git04ecf00.fc17.src.rpm
I tried to resolve
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #3 from Ales Kozumplik akozu...@redhat.com ---
(In reply to comment #1)
(In reply to comment #0)
Ales,
The .spec as-is produces a binary python-hawkey package that can't be
installed due to a missing requires on
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #4 from Ales Kozumplik akozu...@redhat.com ---
(In reply to comment #3)
caused by _hawkey_testmodule.so having a DT_NEEDED entry (i.e. is linked
with) _hawkeymodule.so and RPM automatically generating a requires from
that.
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #5 from Ales Kozumplik akozu...@redhat.com ---
Here's a new spec file and a new .srpm:
http://akozumpl.fedorapeople.org/review/hawkey_2/hawkey.spec
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Karel Klíč kk...@redhat.com changed:
What|Removed |Added
CC||kk...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Scott Tsai scottt...@gmail.com changed:
What|Removed |Added
CC||scottt...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Scott Tsai scottt...@gmail.com changed:
What|Removed |Added
CC||dw...@infradead.org
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Scott Tsai scottt...@gmail.com changed:
What|Removed |Added
CC|dw...@infradead.org |
https://bugzilla.redhat.com/show_bug.cgi?id=833462
Scott Tsai scottt...@gmail.com changed:
What|Removed |Added
Flags||fedora-review?
--
You
29 matches
Mail list logo
