https://bugzilla.redhat.com/show_bug.cgi?id=852211
Petr Šabata changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #2 from Petr Šabata ---
* One of the files is distributed under the MIT/X license. Please, correct the
License tag to "BSD and MIT".
* Respect Fedora %optflags/$RPM_OPT_FLAGS.
* Use %global instead of %define.
The rest of the package
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #3 from Lukas Zapletal ---
All three remarks fixed plus after discussion with upstream I slightly changed
description texts:
https://github.com/lzap/spec_reviews/commit/79d5d2862ebcd13a1c38cf199bf049c31d9730fe
http://koji.fedoraproj
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #4 from Petr Šabata ---
What does the STATIC variable do?
From a brief look, it doesn't seem to affect CFLAGS at all.
--
You are receiving this mail because:
You are on the CC list for the bug.
__
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #5 from Lukas Zapletal ---
It's unused by default, I have decided to leverage it until there is a new
version with dedicated variables for packagers.
config.mk:
CFLAGS += -g --std=c99 -pedantic -Wall -Wno-overlength-strings -Os ${
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #6 from Lukas Zapletal ---
I see it's not used:
http://kojipkgs.fedoraproject.org//work/tasks/3526/4433526/build.log
Investigating.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #7 from Petr Šabata ---
I usually just patch config.mk to suit Fedora needs.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
pac
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #8 from Lukas Zapletal ---
I really do not understand why rpmbuild is quoting the parameter. Tried several
scenarios, without any luck. I will need to patch it.
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Petr Šabata changed:
What|Removed |Added
Status|ASSIGNED|NEW
Assignee|psab...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #10 from Lukas Zapletal ---
Ok I created a patch that respects fedora CFLAGS:
https://github.com/lzap/spec_reviews/commit/5772d10508c16094089a1047ade42dde8e067055
http://koji.fedoraproject.org/koji/taskinfo?taskID=4441341
ANYONE PL
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Michael Scherer changed:
What|Removed |Added
CC||m...@zarb.org
Assignee|nob..
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #12 from Lukas Zapletal ---
Changes made:
https://github.com/lzap/spec_reviews/commit/663c81793a2c8dde06e577044c83ca742fa0a4d1
Links:
https://github.com/lzap/spec_reviews/raw/master/dunst.spec
http://kojipkgs.fedoraproject.org//work
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #13 from Michael Scherer ---
The srpm si no longer here, can you host it somewhere else ?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mai
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #14 from Lukas Zapletal ---
Sure, sorry about that:
http://lzap.fedorapeople.org/fedora-packaging/dunst/0.3.1-3/dunst-0.3.1-3.fc17.src.rpm
http://lzap.fedorapeople.org/fedora-packaging/dunst/0.3.1-3/dunst-0.3.1-3.fc17.x86_64.rpm
ht
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #15 from Lukas Zapletal ---
New release 0.4.0 is available. I will bump the package version once it is
approved.
Message from the upstream author:
Since dunst has lost its ability to show notifications independendly of
dbus/libnotif
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #16 from Michael Scherer ---
There is bundled library :
http://code.google.com/p/inih/
( and I think draw.h come from dmenu as well ).
Could you please open a ticket with fesco to have a execption for this ? ( as I
cannot approve i
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #17 from Michael Scherer ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Package issues:
[!]: Package contains no bundled libraries.
There is a bundl
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #18 from Lukas Zapletal ---
Thank you, submitting https://fedorahosted.org/fesco/ticket/955
What is your recommendation for the package name? Github is a big pain for
packagers, it is formatting tarballs as username-project-hash.tar.
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #19 from Lukas Zapletal ---
Oh I filed into the wrong trac. Filing as
https://fedorahosted.org/fpc/ticket/216 now.
--
You are receiving this mail because:
You are on the CC list for the bug.
_
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #20 from Michael Scherer ---
the guideline for tarball are here :
http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
as long as you document it, this should be ok.
--
You are receiving this mail because:
You a
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #21 from Lukas Zapletal ---
Created subpackage - small static library for INI parsing. Going to incorporate
the changes with upstream:
https://bugzilla.redhat.com/show_bug.cgi?id=865116
--
You are receiving this mail because:
You a
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Mario Blättermann changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #23 from Lukas Zapletal ---
Will do bump, but I need the review of the INIH library first ;-) ^^^
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-re
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Mario Blättermann changed:
What|Removed |Added
Depends On||865116
Alias|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #24 from Lukas Zapletal ---
Ok I am bumping version to 0.5.0. Changes:
- no inih static library dependency anymore
- now proper release (no more github snapshot)
- new features :-)
Please re-review. Thank you!
--
Y
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Bug 852211 depends on bug 865116, which changed state.
Bug 865116 Summary: Review Request: inih-devel - small C INI parsing library
https://bugzilla.redhat.com/show_bug.cgi?id=865116
What|Removed
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #25 from Andrew Price ---
Is anyone working on this review?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OVO8dutcc6&a=
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #26 from Michael Scherer ---
I do not have time to re-review it for now, so you can take it. I basically
already checked most issues in comment #17, so that should be fast.
--
You are receiving this mail because:
You
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Andrew Price changed:
What|Removed |Added
Assignee|m...@zarb.org |anpr...@redhat.com
--- Co
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #28 from Lukas Zapletal ---
Andrew: Sure, I apologize for the delay:
http://lzap.fedorapeople.org/fedora-packaging/dunst/0.5.0-1/
http://lzap.fedorapeople.org/fedora-packaging/dunst/0.5.0-1/dunst-0.5.0-1.f15.src.rpm
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #29 from Andrew Price ---
Test build in koji failed with:
+ make -j5 VERSION=0.5.0 PREFIX=/usr 'EXTRACFLAGS=-O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mt
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #30 from Andrew Price ---
So I've gone through all the review points and the only issue remaining is the
build failure in comment #29. Once that's fixed I think this review will likely
be over and done with.
--
You a
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #31 from Lukas Zapletal ---
Right, I was missing a build require:
https://koji.fedoraproject.org/koji/taskinfo?taskID=5084022
https://github.com/lzap/spec_reviews/commit/3b05d0ac42433e0c7a04443d24ddd4b30e58c299
--
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Andrew Price changed:
What|Removed |Added
Flags|fedora-review? |
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #33 from Petr Šabata ---
Congratulations on review+, finally ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cCV2FEuGi
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Lukas Zapletal changed:
What|Removed |Added
Flags||fedora-cvs?
--- Comment
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
--- Comment #35 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XQYHIt9K0T&a=
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852211
Lukas Zapletal changed:
What|Removed |Added
Status|NEW |CLOSED
Resoluti
38 matches
Mail list logo
