[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-11-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|---

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-11-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #34 from Fedora Update System --- valkyrie-2.0.0-5.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. _

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #33 from Fedora Update System --- Package valkyrie-2.0.0-5.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum updat

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #32 from Fedora Update System --- valkyrie-2.0.0-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/valkyrie-2.0.0-5.fc16 -- You are receiving this mail because: You are on the CC list for

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #31 from Fedora Update System --- valkyrie-2.0.0-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/valkyrie-2.0.0-5.fc17 -- You are receiving this mail because: You are on the CC list for

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #30 from Fedora Update System --- valkyrie-2.0.0-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/valkyrie-2.0.0-5.fc18 -- You are receiving this mail because: You are on the CC list for

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #29 from Fedora Update System --- valkyrie-2.0.0-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/valkyrie-2.0.0-5.el6 -- You are receiving this mail because: You are on the CC list fo

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving th

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #28 from Mario Blättermann --- Go to https://admin.fedoraproject.org/updates/, log in and click on "New update" in the left pane. Then you can add the Koji builds and submit them for testing. Don't forget to submit the bug number and

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #27 from Nathan Scott --- Ah, thanks for the reminder Mario. I'm not sure whether I've missed a step - usually at this point I would use the web interface to mark the packages as "submitted for testing" ... but, https://admin.fedorap

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #26 from Mario Blättermann --- Packages for all requested branches have been built, but I cannot find anything in Bodhi. What's the matter? -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #25 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Nathan Scott changed: What|Removed |Added Flags|fedora-cvs+ | Flags|

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Nathan Scott changed: What|Removed |Added Flags||fedora-cvs+ -- You are receiving this ma

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #24 from Nathan Scott --- New Package SCM Request === Package Name: valkyrie Short Description: Graphical User Interface for Valgrind Suite Owners: nathans Branches: f16 f17 f18 el5 el6 InitialCC: mjw -- You are

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #23 from Nathan Scott --- Awesome, thanks for all the help guys! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Sebastian Dyroff changed: What|Removed |Added Assignee|nob...@fedoraproject.org|fed...@dyroff.org --- Comment #22 fro

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Sebastian Dyroff changed: What|Removed |Added Status|NEW |ASSIGNED Flags|

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #20 from Mario Blättermann --- @Sebastian, because you are sponsored in the packagers group now, you might assign this review request to you and complete the review. -- You are receiving this mail because: You are on the CC list for

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #19 from Mario Blättermann --- (In reply to comment #17) > I made a complete review now, based on valkyrie-2.0.0-5.el6_3.src.rpm. > > There are two remaining issues, but I am not 100% sure about them. > > First: Package uses nothing

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #18 from Sebastian Dyroff --- Oh and I forgot to mention, that the issues listed by fedora-review are false positives, because you are intending to package for epel5 and the license thing is checked. -- You are receiving this mail b

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #17 from Sebastian Dyroff --- I made a complete review now, based on valkyrie-2.0.0-5.el6_3.src.rpm. There are two remaining issues, but I am not 100% sure about them. First: Package uses nothing in %doc for runtime. You moved the h

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #16 from Nathan Scott --- I've uploaded http://oss.sgi.com/~nathans/valkyrie-2.0.0-5.el6_3.src.rpm (and spec file in same location) which addresses the remaining issues, I think. Going through the issues/questions listed in c13... |

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #15 from Sebastian Dyroff --- Sorry, my fault. I read the part of the COPYING about later versions again. Mario is right, it is GPLv2. -- You are receiving this mail because: You are on the CC list for the bug. _

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #14 from Mario Blättermann --- (In reply to comment #13) > I think, the license is GPLv2+. The COPYING file says GPLv2, and the source file headers doesn't contain the "newer versions" clause. That's why it remains as GPLv2. -- You

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #13 from Sebastian Dyroff --- You are intending to package this for EPEL5 right? If so, some issues are irrelevant. There is a COPYING file which contains the license. It should be listed via %doc. The INSTALL file does not look like

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #12 from Nathan Scott --- Thanks Sebastian - I've uploaded http://oss.sgi.com/~nathans/valkyrie-2.0.0-4.el6_3.src.rpm (and spec file in same location) which include your patch. -- You are receiving this mail because: You are on the

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #11 from Sebastian Dyroff --- It was getpid. Error message was: utils/vk_utils.cpp: In function 'void vkPrint(const char*, ...)': utils/vk_utils.cpp:54:104: error: 'getpid' was not declared in this scope utils/vk_utils.cpp: In funct

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #10 from Nathan Scott --- Thanks Sebastian - producing a patched spec now - could you let me know which symbol was missing there? (will need to mention it to upstream) Guess its one/more of these...? U exit

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #9 from Sebastian Dyroff --- Created attachment 622075 --> https://bugzilla.redhat.com/attachment.cgi?id=622075&action=edit patch to include unistd.h in vk_utils.cpp It still did not build for me. I have created a patch that fixes

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #8 from Nathan Scott --- I've uploaded a new http://oss.sgi.com/~nathans/valkyrie-2.0.0-3.el6_3.src.rpm which should fix this new build issue. Will discuss the FSF address with upstream (as well as asking re a man page). thanks! -

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #6 from Sebastian Dyroff --- Does still not work for me (f17). I even tried a koji scratch build for rawhide, because I wanted to be sure that it is not my system. See http://koji.fedoraproject.org/koji/taskinfo?taskID=4560328 The bu

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Thibault North changed: What|Removed |Added CC||thibault.no...@gmail.com --- Comment #5

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #4 from Nathan Scott --- Fedora and EPEL. Same spec file should work everywhere though (I hope). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-re

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Sebastian Dyroff changed: What|Removed |Added CC||b...@dyroff.org --- Comment #3 from S

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #2 from Nathan Scott --- Hi Sebastian, Thanks for taking a look (and for the tip about fedora-review, trying that out now). I've uploaded a new http://oss.sgi.com/~nathans/valkyrie-2.0.0-2.el6_3.src.rpm which should fix this build

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #1 from Sebastian Dyroff --- Created attachment 620749 --> https://bugzilla.redhat.com/attachment.cgi?id=620749&action=edit build.log with errors I am not a member of the packager group, so this is just informal. I was not able to