Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #47 from Fedora Update System ---
gogui-1.4.7-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/gogui-1.4.7-1.fc19
--
You are receiving this mail because:
You are on the CC
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #46 from Fedora Update System ---
gogui-1.4.7-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gogui-1.4.7-1.fc17
--
You are receiving this mail because:
You are on the CC
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #45 from Fedora Update System ---
gogui-1.4.7-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gogui-1.4.7-1.fc18
--
You are receiving this mail because:
You are on the CC
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Michael Schwendt changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
--
You are receivin
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #44 from Fedora Update System ---
gogui-1.4.6-14.fc18 has been pushed to the Fedora 18 stable repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https:/
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #43 from Fedora Update System ---
gogui-1.4.6-14.fc17 has been pushed to the Fedora 17 stable repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https:/
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Re
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #42 from Fedora Update System ---
gogui-1.4.6-14.fc17 has been pushed to the Fedora 17 testing repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https:
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--
You are
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #41 from Fedora Update System ---
gogui-1.4.6-14.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gogui-1.4.6-14.fc18
--
You are receiving this mail because:
You are on the
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #40 from Fedora Update System ---
gogui-1.4.6-14.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gogui-1.4.6-14.fc17
--
You are receiving this mail because:
You are on the
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
--
You
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #39 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=NvbwVVnTdF&a=
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Christophe Burgun changed:
What|Removed |Added
Flags||fedora-cvs?
--- Comm
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #37 from Pierre-YvesChibon ---
Ah, that's why Christophe couldn't set the flag himself. Sorry I missed this.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
http
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #36 from Jon Ciesla ---
fas email address and bugzilla email address need to match.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/t
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Pierre-YvesChibon changed:
What|Removed |Added
Flags||fedora-cvs?
--
You
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #35 from Christophe Burgun ---
New Package SCM Request
===
Package Name: gogui
Short Description: Graphical user interface to programs that play the board
game Go
Owners: jouty
Branches: f17 f18
--
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Pierre-YvesChibon changed:
What|Removed |Added
Flags|fedora-review? |
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #33 from Christophe Burgun ---
Add rm for class files
See changelogs:
New link :
SPEC : http://jouty.fedorapeople.org/gogui.spec
SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-14.fc17.src.rpm
--
You are receiving
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #32 from Christophe Burgun ---
Hi,
I have change the sed with the Wrapper scripts as your recommendations:
See changelogs
New link :
SPEC : http://jouty.fedorapeople.org/gogui.spec
SRPM : http://jouty.fedorapeople.o
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #31 from Christophe Burgun ---
- Delete patch gnugo desktop because upstream would prefer gogui package alone
- Remove fr_FR and just let fr
- Delete BR libxslt-devel, libxml2-devel
New link :
SPEC : http://jouty.fed
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #30 from Pierre-YvesChibon ---
(In reply to comment #28)
> (In reply to comment #27)
> > Gogui don't require gnugo
> > You can use GoGui without any Go engine as a SGF viewer/editor or as a
> > local Go board for play
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #29 from Mohamed El Morabity ---
More comments:
>>> %description -l fr_FR
"fr_FR" is maybe a little bit too restrictive, "fr" may be enough. I don't
think your package description is specific to France.
>>> BuildR
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #28 from Mohamed El Morabity ---
(In reply to comment #27)
> Gogui don't require gnugo
> You can use GoGui without any Go engine as a SGF viewer/editor or as a
> local Go board for playing games between humans.
> Howe
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #27 from Christophe Burgun ---
Hi Pierre-Yves,
Gogui don't require gnugo
You can use GoGui without any Go engine as a SGF viewer/editor or as a
local Go board for playing games between humans.
However its main use is
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #26 from Pierre-YvesChibon ---
Ok so here is the official review:
Basically, it looks all good to go, the only question is:
- Should gogui require gnugo?
One can use it without gnugo installed in a multiplayer setting
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #25 from Christophe Burgun ---
Spec has been updated with your recommendations (see changelog)
New links :
SPEC : http://jouty.fedorapeople.org/gogui.spec
SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-10.fc17.src.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #24 from Christophe Burgun ---
Spec has been updated with your recommendations (see changelog)
New links :
SPEC : http://jouty.fedorapeople.org/gogui.spec
SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-9.fc17.src.r
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #23 from Pierre-YvesChibon ---
While reading the log from the build, it seems that ant -p is missing a
parameters (and thus uses a default), but it might be safer to add it.
--
You are receiving this mail because:
Yo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #22 from Christophe Burgun ---
Koji build :
http://koji.fedoraproject.org/koji/taskinfo?taskID=4780700
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://b
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Pierre-YvesChibon changed:
What|Removed |Added
Status|NEW |ASSIGNED
A
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #21 from Christophe Burgun ---
I have add the licence file to the subpackage
New links :
SPEC : http://jouty.fedorapeople.org/gogui.spec
SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-8.fc17.src.rpm
--
You are re
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #20 from Pierre-YvesChibon ---
There is something missing in the javadoc package wrt to license ;-)
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #19 from Christophe Burgun ---
I have change the sed in the prep section without cat too
New links :
SPEC : http://jouty.fedorapeople.org/gogui.spec
SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-7.fc17.src.rpm
--
You are receiv
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #18 from Pierre-YvesChibon ---
>- The sed syntax has been change without the cat
Almost:
cat config/%{name}.thumbnailer | sed
"s;/usr/bin/%{name}-thumbnailer;$PREFIX/bin/%{name}-thumbnailer;"
--
You are receiving this mail becaus
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #17 from Christophe Burgun ---
Tanks for the help Mohamed
- I have change the Summary and Description as your recommendations
- The Buildrequires have been delete from javadoc subpackage
- The sed syntax has been change without the c
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #16 from Mohamed El Morabity ---
> 4) DON'T pipe sed through cat, it's useless, unreadable and considered bad
> practice. Simply use sed only instead:
>
> for FILE in bin/*; do
> if [ -f $FILE -a -x $FILE ]; then
>
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #15 from Mohamed El Morabity ---
Some comments too:
1) as I told you recently on IRC, sentences shouldn't be used in Summary;
"Graphical user interface to programs that play the board game Go" may be
enough.
2) On the contrary, use
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #14 from Christophe Burgun ---
Thanks Florencia for the informal comments :
1) I have change some gogui with the %{name} macro (see changelog)
2) The dictionary message is normal, the group tag isn't need
https://fedoraproject.org/w
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #13 from Florencia Fotorello ---
Hello,
Some informal comments:
1) You can use %{name}.desktop instead of gogui.desktop.
2) Regarding rpmlint output, just some comments, no action needed:
--
gogui.noarch: I: enchant-
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #12 from Christophe Burgun ---
- The /usr/share has been changed with the macro %{_datadir}
- The sed has been push in %prep section
- The installation for thumbnailer is now with install command
New links :
SPEC : http://jouty.fedo
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #11 from Pierre-YvesChibon ---
I think we can still improve this:
install -d $RPM_BUILD_ROOT%{_datadir}/thumbnailers
cat config/gogui.thumbnailer | sed
"s;/usr/bin/gogui-thumbnailer;$PREFIX/bin/gogui-thumbnailer;" \
> $RPM_BUILD_ROOT
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #10 from Christophe Burgun ---
For info some change have been made due to :
http://jouty.fedorapeople.org/upstream-info
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #9 from Christophe Burgun ---
I have change the spec file and rebuilt due to :
http://jouty.fedorapeople.org/upstream-info
changing xgd to install command (see changelogs)
here new links :
SPEC : http://jouty.fedorapeople.org/gogui
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #8 from Christophe Burgun ---
Hi Florencia, Pierre-Yves
[!]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
=> The desktop file name follow now the guideli
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #7 from Pierre-YvesChibon ---
Running fedora-review by itself without going through the checklist at the end
and check the point that are remaining (and making sure there are no false
positive/negative) is pretty much useless.
Please
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #6 from Florencia Fotorello ---
Complete fedora-review output:
-
$ cat 866901/gogui-review.txt
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[ ]: MUST Package i
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #5 from Florencia Fotorello ---
Hi Christophe,
Thanks for the update.
I run “fedora-review” and there are some tests that failed. Could you please
check them?
--
$ cat 866901/gogui-review.txt
Packa
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #4 from Christophe Burgun ---
Hi Florancia,
Yes of course i add the new links :
SPEC : http://jouty.fedorapeople.org/gogui.spec
SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-1.fc17.src.rpm
--
You are receiving this mail becaus
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Florencia Fotorello changed:
What|Removed |Added
CC||ffoto...@redhat.com
--- Comment #3
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #2 from Christophe Burgun ---
Hi Pierre-Yves,
- I have fill the %doc
- I have cut the long lignes :)
- I have look the requires of libxslt-devel, libxml2-devel
- I have change the .desktop install same in guidelines
- I have add the
https://bugzilla.redhat.com/show_bug.cgi?id=866901
--- Comment #1 from Pierre-YvesChibon ---
Some initial comments after having quickly looked at the spec file:
- No %doc on the sources?
- Some lines are really long...
- Check if libfoo-devel requires libfoo, that would reduce the list of
BuildR
https://bugzilla.redhat.com/show_bug.cgi?id=866901
Christophe Burgun changed:
What|Removed |Added
CC||pin...@pingoured.fr
Bloc
54 matches
Mail list logo
