[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-19 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #11 from Terje Røsten terje...@phys.ntnu.no --- Done. I assume the wildcard is to accommodate future, additional manpages, so why not '%{_mandir}/man*/brewtarget*' ? No, rpmbuild will compress all man pages and

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-19 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Summary and SCM request package names don't match, please correct. -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 876865] Review Request: brewtarget - beer recipe tool

2012-11-19 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 Pete Travis m...@petetravis.com changed: What|Removed |Added Summary|Review Request: Brewtarget |Review

[Bug 876865] Review Request: brewtarget - beer recipe tool

2012-11-19 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #13 from Pete Travis m...@petetravis.com --- New Package SCM Request === Package Name: brewtarget Short Description: An open source beer recipe creation tool Owners: immanetize Branches: f16 f17

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-18 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Depends On|177841 (FE-NEEDSPONSOR) |

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-18 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 Pete Travis m...@petetravis.com changed: What|Removed |Added Flags|

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-18 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #10 from Pete Travis m...@petetravis.com --- snip Issues: 1. Might ask upstream to include a copy of LGPL? (not a blocker) 2. rpmlint says: brewtarget.i686: W: spurious-executable-perm

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-17 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #4 from Pete Travis m...@petetravis.com --- (In reply to comment #2) Some more: * use %{version} in source url This seems a bit excessive. It would break validation tools, and require users trying to download the

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-17 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #5 from Terje Røsten terje...@phys.ntnu.no --- Thanks for updates! Some more: rpmlint issues: brewtarget.x86_64: W: invalid-license WTFPLv2 brewtarget.x86_64: W: invalid-license LGPLv2.1 According to

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-17 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #6 from Pete Travis m...@petetravis.com --- (In reply to comment #5) Thanks for updates! Some more: rpmlint issues: brewtarget.x86_64: W: invalid-license WTFPLv2 brewtarget.x86_64: W: invalid-license

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-17 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-16 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added CC|

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-16 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #2 from Terje Røsten terje...@phys.ntnu.no --- Some more: * use %{version} in source url * ctest don't seems to do anything useful, remove * no need for %{_docdir}/%{name}-%{version} in %files * app seems to ship

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-16 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #3 from Pete Travis m...@petetravis.com --- (In reply to comment #1) Some comments: * I am confused by your release tag usage, why the rc prefix and why not increase on update? Please consult:

[Bug 876865] Review Request: Brewtarget - beer recipe tool

2012-11-14 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 Pete Travis m...@petetravis.com changed: What|Removed |Added Depends On||177841