[Bug 919265] Review Request: Bijiben - Note taking app

2013-05-08 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #24 from Kalev Lember --- No, nothing wrong with it, it's perfectly fine :) Just wanted to doublecheck that it's not a typo, easy to accidentally use pkgdatadir instead of datadir. -- You are receiving this mail beca

[Bug 919265] Review Request: Bijiben - Note taking app

2013-05-08 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #23 from Mathieu Bridon --- (In reply to comment #22) > 5) > /usr/share/bijiben/icons > /usr/share/bijiben/icons/hicolor > /usr/share/bijiben/icons/hicolor/16x16 > /usr/share/bijiben/icons/hicolor/16x16/actions > /usr/

[Bug 919265] Review Request: Bijiben - Note taking app

2013-05-08 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #22 from Kalev Lember --- A few comments / questions about this package: 1) The name and summary in the spec file should match up with the name and summary in the review ticket (and also with the name and summary in

[Bug 919265] Review Request: Bijiben - Note taking app

2013-05-08 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 Kalev Lember changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #21 from Kal

[Bug 919265] Review Request: Bijiben - Note taking app

2013-05-06 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 Kalev Lember changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 919265] Review Request: Bijiben - Note taking app

2013-05-01 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #19 from Pierre-Yves Luyten --- I built 3.9.1 against rawhide. SPEC : http://py.luyten.fr/Publique/gnome/bjb/391-1/bijiben.spec SRPM : http://py.luyten.fr/Publique/gnome/bjb/391-1/bijiben-3.9.1-1.fc20.src.rpm For F19

[Bug 919265] Review Request: Bijiben - Note taking app

2013-04-24 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #18 from Ankur Sinha (FranciscoD) --- Hi Pierre, The package's already been reviewed and looks good. I've just built myself an rpm and am using it on my F19 system. Works well too. Looking forward to having it in Fedo

[Bug 919265] Review Request: Bijiben - Note taking app

2013-04-18 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #17 from Pierre-Yves Luyten --- The manual switched to creative-commons and received small fixes SPEC: http://py.luyten.fr/Publique/gnome/bjb/381-1/bijiben.spec SRPM: http://py.luyten.fr/Publique/gnome/bjb/381-1/bijib

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-26 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #16 from Pierre-Yves Luyten --- Not much change below, yes sponsoring would be nice now the version is stable. SPEC: http://py.luyten.fr/Publique/gnome/bjb/380-1/bijiben.spec SRPM: http://py.luyten.fr/Publique/gnome/b

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-20 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #15 from Mathieu Bridon --- (In reply to comment #14) > License is correct. Lifting FE-Legal. Thanks Tom! (In reply to comment #13) > I can sponsor you Like I said in comment 11, the package was in a state where I'd

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-20 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 Tom "spot" Callaway changed: What|Removed |Added Blocks|182235 (FE-Legal) | C

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-20 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #13 from Matthias Clasen --- I can sponsor you -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KLqPi3owKO&a=cc_unsubscrib

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-17 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #12 from Pierre-Yves Luyten --- New minor release, mostly removing patches SPEC: http://py.luyten.fr/Publique/gnome/bjb/3792-1/bijiben.spec SRPM: http://py.luyten.fr/Publique/gnome/bjb/3792-1/bijiben-3.7.92-1.fc19.src

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-15 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #11 from Mathieu Bridon --- Ok, the package looks very good now! :) If I could, I would approve your package, provided that the legal team confirms I didn't make any mistake with that License tag. I wrote to the lega

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-15 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #10 from Pierre-Yves Luyten --- Hey Mathieu, yes i should really look for mock soon! SPEC: http://py.luyten.fr/Publique/gnome/bjb/3971-3/bijiben.spec P0: http://py.luyten.fr/Publique/gnome/bjb/3971-3/license-use-con

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-14 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #9 from Mathieu Bridon --- Thanks for the quick update Pierre-Yves, this is looking much better already! Remaining issues: [!]: gtk-update-icon-cache is not invoked => See: http://fedoraproject

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-14 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #8 from Pierre-Yves Luyten --- Cool, %find_lang is now a good friend! Two patch were pushed (upstream so for 3.7.92 rc). - Patch to get rid of GPLv2+ - Patch to use static link to libgd - Use find_lang - Remove define

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-13 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #7 from Matthias Clasen --- wrt: => Shouldn't %{_datadir}/help/C/%{name} be marked as %doc? %find_lang does this for you if you use --with-gnome -- You are receiving this mail because: You are on the CC list fo

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-13 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #6 from Matthias Clasen --- Wrt to libgd - that is not actually a separately installable library, just a git module that is being shared by a number of new GNOME applications, while the code is getting ready for eventu

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-13 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 Matthias Clasen changed: What|Removed |Added CC||mcla...@redhat.com ---

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-13 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #4 from Mathieu Bridon --- (In reply to comment #3) > Hello Matthieu, Only one "t". ;) > thanks much for the review (sorry there was all these little > things..). No worries, the purpose of the review is also to lea

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-13 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #3 from Pierre-Yves Luyten --- Hello Matthieu, thanks much for the review (sorry there was all these little things..). I will submit soon new SPEC and SRPM soon for the technical parts. Concerning the license : yes, s

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-13 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 Mathieu Bridon changed: What|Removed |Added CC||boche...@fedoraproject.o

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-09 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #1 from Pierre-Yves Luyten --- I just built 3.7.91 and discovered some issues on previous spec. It's built from rawhide to have all the dependencies. Spec: http://py.luyten.fr/Publique/gnome/bjb/3791/bijiben.spec SRPM

[Bug 919265] Review Request: Bijiben - Note taking app

2013-03-07 Thread bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 Pierre-Yves Luyten changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONS