Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #50 from Fedora Update System upda...@fedoraproject.org ---
nomacs-1.0.2-3.fc19 has been pushed to the Fedora 19 stable repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #49 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #46)
Yes, that's what I've been trying to tell you all this time! (You will want
to keep the -DENABLE_RAW=1 though.)
Ok - I will do this in next
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Orion Poplawski or...@cora.nwra.com changed:
What|Removed |Added
CC|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #45 from Eugene A. Pivnev ti.eug...@gmail.com ---
Seems that %cmake .. is the best solution:
https://bugzilla.redhat.com/show_bug.cgi?id=952632
To Kevin, Mamoru: what you think about this?
--
You are receiving this
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #46 from Kevin Kofler ke...@tigcc.ticalc.org ---
Yes, that's what I've been trying to tell you all this time! (You will want to
keep the -DENABLE_RAW=1 though.)
--
You are receiving this mail because:
You are on the
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|ON_QA
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #47 from Fedora Update System upda...@fedoraproject.org ---
nomacs-1.0.2-3.fc17 has been pushed to the Fedora 17 stable repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #48 from Fedora Update System upda...@fedoraproject.org ---
nomacs-1.0.2-3.fc18 has been pushed to the Fedora 18 stable repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #43 from Kevin Kofler ke...@tigcc.ticalc.org ---
But %cmake macro has no debug or release flags at all.
Most projects don't actually need a build type. While in principle, a
CMakeLists.txt can do all sorts of things
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #33 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #32)
1. -DCMAKE_BUILD_TYPE=Release - as you know - %cmake by default not set
Release.
But my point is, why do you want to set the build type
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #34 from Mamoru TASAKA mtas...@fedoraproject.org ---
Note that I still approve this package.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #35 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #34)
Note that I still approve this package.
I can do this in next release.
But we must to solve this problem.
For other cmake-based applications
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #36 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Jon Ciesla limburg...@gmail.com changed:
What|Removed |Added
Flags|fedora-cvs? |
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|ASSIGNED
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #37 from Fedora Update System upda...@fedoraproject.org ---
nomacs-1.0.2-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/nomacs-1.0.2-3.fc17
--
You are receiving this
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #38 from Fedora Update System upda...@fedoraproject.org ---
nomacs-1.0.2-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/nomacs-1.0.2-3.fc18
--
You are receiving this
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #39 from Fedora Update System upda...@fedoraproject.org ---
nomacs-1.0.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nomacs-1.0.2-3.fc19
--
You are receiving this
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|MODIFIED
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #40 from Fedora Update System upda...@fedoraproject.org ---
nomacs-1.0.2-3.fc19 has been pushed to the Fedora 19 testing repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #41 from Kevin Kofler ke...@tigcc.ticalc.org ---
I'm not familiar in cmake, so - propose good flags
My proposal was to simply use:
%cmake -DENABLE_RAW=1 ..
without setting -DCMAKE_BUILD_TYPE=Release. Or is there any
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #42 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #41)
I'm not familiar in cmake, so - propose good flags
My proposal was to simply use:
%cmake -DENABLE_RAW=1 ..
without setting
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #19 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #17)
Well, as Kevin says, it is easier to fix build flags locally (i.e. in your
srpm) to be compliant with Fedora packaging policy. Of course you
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #20 from Mamoru TASAKA mtas...@fedoraproject.org ---
Please change URLs (especially release number) when you modified spec file and
add new %changelog entry appropriately:
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #21 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #20)
Please change URLs (especially release number) when you modified spec file
and add new %changelog entry appropriately:
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #22 from Eugene A. Pivnev ti.eug...@gmail.com ---
CXX flags set to -O3 only.
Spec URL: http://tieugene.fedorapeople.org/rpms/nomacs/nomacs.spec
SRPM URL:
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Mamoru TASAKA mtas...@fedoraproject.org changed:
What|Removed |Added
Flags|fedora-review?
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #24 from Kevin Kofler ke...@tigcc.ticalc.org ---
Now what's the point of using
-DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS_RELEASE:STRING=-O2
? Isn't it exactly as if neither of those flags were passed?
Normally,
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #25 from Eugene A. Pivnev ti.eug...@gmail.com ---
1. -DCMAKE_BUILD_TYPE=Release - as you know - %cmake by default not set
Release.
2. -DCMAKE_CXX_FLAGS_RELEASE:STRING=-O2 - Mr. Tasaka don't want to see -O3
in Makefile.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Eugene A. Pivnev ti.eug...@gmail.com changed:
What|Removed |Added
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Jon Ciesla limburg...@gmail.com changed:
What|Removed |Added
CC|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Eugene A. Pivnev ti.eug...@gmail.com changed:
What|Removed |Added
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #28 from Eugene A. Pivnev ti.eug...@gmail.com ---
What?..
1. The reviewer will review your package. You should fix any blockers that the
reviewer identifies. Once the reviewer is happy with the package, the
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Jon Ciesla limburg...@gmail.com changed:
What|Removed |Added
Flags|fedora-cvs? |
---
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #30 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #29)
You set the flag to ? once you've included an SCM request:
https://fedoraproject.org/wiki/Package_SCM_admin_requests
Ooops... sorry.
They
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Eugene A. Pivnev ti.eug...@gmail.com changed:
What|Removed |Added
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #32 from Kevin Kofler ke...@tigcc.ticalc.org ---
1. -DCMAKE_BUILD_TYPE=Release - as you know - %cmake by default not set
Release.
But my point is, why do you want to set the build type to Release at all? All
it
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #11 from Eugene A. Pivnev ti.eug...@gmail.com ---
I was badly sleeping this night and decided revert cmake flags back (and delete
-DCXX...).
Because nomacs not set -O.
Then redundant -O3s are cmake's or %cmake's
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #12 from Mamoru TASAKA mtas...@fedoraproject.org ---
So still -O3 optimization flag is left, please fix.
Please try what Kevin suggested, or you may modify cmake-generated
files as one method.
--
You are receiving
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #13 from Kevin Kofler ke...@tigcc.ticalc.org ---
Yes, if you set -DCMAKE_BUILD_TYPE=Release, you MUST also set
-DCMAKE_CXX_FLAGS_RELEASE:STRING=-O2 -DNDEBUG.
--
You are receiving this mail because:
You are on the CC
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #14 from Eugene A. Pivnev ti.eug...@gmail.com ---
Please - exapand me - _why_.
It seems as dirty hack.
* nomacs not set -O at all
* Fedora requires right -O
* and requires Release for binary rpms
From developer's point
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #15 from Eugene A. Pivnev ti.eug...@gmail.com ---
s/expand/explain/g
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #16 from Kevin Kofler ke...@tigcc.ticalc.org ---
If you want CMake's and/or the %cmake macro's defaults to change, you need to
take that up with Orion Poplawski, the primary maintainer of CMake in Fedora.
I am telling
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #17 from Mamoru TASAKA mtas...@fedoraproject.org ---
Well, as Kevin says, it is easier to fix build flags locally (i.e. in your
srpm) to be compliant with Fedora packaging policy. Of course you can file a
bug against
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #18 from Mamoru TASAKA mtas...@fedoraproject.org ---
By the way -O3 issue seems to be already in discussion on bug 875954 .
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Mamoru TASAKA mtas...@fedoraproject.org changed:
What|Removed |Added
Status|NEW
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org ---
Some notes:
* description
- Some part of description is redundant and better to fix
- free image viewer is just redundant. Fedora does not allow
non-free
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #7 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #6)
* description
- Some part of description is redundant and better to fix
Fixed
* SourceURL:
- For sourceforge based tarball, please
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #8 from Kevin Kofler ke...@tigcc.ticalc.org ---
%cmake sets the build type to Release by default, and unfortunately this
defaults to -O3 -DNDEBUG in CMake. Most packages override this to vastly
different defaults, but
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #9 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #8)
%cmake sets the build type to Release by default,
Sorry, but: https://bugzilla.redhat.com/show_bug.cgi?id=919044#c31
:-)
Anyway, to fix
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #10 from Kevin Kofler ke...@tigcc.ticalc.org ---
You're right, it doesn't, and IIRC this very issue is why it doesn't.
But that means the -DCMAKE_BUILD_TYPE=release you're adding is the culprit, not
the %cmake macro.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Eugene A. Pivnev ti.eug...@gmail.com changed:
What|Removed |Added
Blocks|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
CC|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
Eugene A. Pivnev ti.eug...@gmail.com changed:
What|Removed |Added
Whiteboard|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #3 from Rex Dieter rdie...@math.unl.edu ---
If there is a minimal Qt version required to build, might be a good idea to
reflect that in the BuildRequires: dependencies
--
You are receiving this mail because:
You are
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929256
--- Comment #4 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #3)
If there is a minimal Qt version required to build, might be a good idea to
reflect that in the BuildRequires: dependencies
Fixed.
Release
56 matches
Mail list logo
