https://bugzilla.redhat.com/show_bug.cgi?id=946968
Jon Ciesla changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Ngo Than changed:
What|Removed |Added
Status|CLOSED |ASSIGNED
CC|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |
--
You are receiving this
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #23 from Jon Ciesla ---
Unsetting flag.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=pbdVEz4E2a&a=cc_unsubscribe
_
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Mamoru TASAKA changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolutio
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #21 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=jAkHOgBlAg&a=
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #20 from Mamoru TASAKA ---
Yes, pcmanfm-qt is still under development and I will keep an eye on the
upstream development.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from t
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #19 from Eugene A. Pivnev ---
(In reply to comment #17)
> So as I see that fedora-review flag was set to + by the reviewer, I will
> arrange the left properly...
Don't forget that pcmanfm-qt is still too buggy (workin
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Mamoru TASAKA changed:
What|Removed |Added
Flags||fedora-cvs?
--- Comment
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Mamoru TASAKA changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assig
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Mamoru TASAKA changed:
What|Removed |Added
CC|package-review@lists.fedora |
|proj
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #16 from Mamoru TASAKA ---
Kevin, if you have some way like -DCMAKE_CXX_FLAGS_RELEASE:STRING=, I may consider to use it.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from th
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #15 from Mamoru TASAKA ---
(In reply to comment #14)
> I have to disagree, passing -D flags to CMake is much cleaner than
> postprocessing CMake output (yuck!).
I want to change "-O3" to "-O2" only, not anything else
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #14 from Kevin Kofler ---
I have to disagree, passing -D flags to CMake is much cleaner than
postprocessing CMake output (yuck!).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscrib
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #13 from Mamoru TASAKA ---
By the way -O3 issue seems to be already in discussion on bug 875954 .
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzill
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #12 from Mamoru TASAKA ---
(In reply to comment #11)
> Have you checked that this doesn't end up adding -O3 to the build flags? And
> if not, does it even have any effect at all? (By default, it defines NDEBUG,
> some
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #11 from Kevin Kofler ---
Have you checked that this doesn't end up adding -O3 to the build flags? And if
not, does it even have any effect at all? (By default, it defines NDEBUG, some
projects also add QT_NO_DEBUG.)
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #10 from Mamoru TASAKA ---
http://mtasaka.fedorapeople.org/Review_request/pcmanfm-qt/pcmanfm-qt.spec
http://mtasaka.fedorapeople.org/Review_request/pcmanfm-qt/pcmanfm-qt-0.1.0-3.fc.src.rpm
* Mon Apr 8 2013 Mamoru TAS
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #9 from Mamoru TASAKA ---
Okay, thank you.
I will upload new srpm anyway.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Eugene A. Pivnev changed:
What|Removed |Added
Flags|fedora-review? |
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #7 from Eugene A. Pivnev ---
Package Review
==
= MUST items =
[+]: Package does not contain kernel modules.
[+]: Package contains no static executables.
[x]: Header files in -devel subpackage, if p
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #6 from Eugene A. Pivnev ---
(In reply to comment #5)
> IMHO, the spacing between sections is fine as is, it's definitely not a
> review criterion. I'd remove the blank lines INSIDE the %prep, %install and
> %files sec
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #5 from Kevin Kofler ---
IMHO, the spacing between sections is fine as is, it's definitely not a review
criterion. I'd remove the blank lines INSIDE the %prep, %install and %files
sections though, then the blank lines
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Eugene A. Pivnev changed:
What|Removed |Added
Flags||fedora-review?
--- Co
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #3 from Mamoru TASAKA ---
(In reply to comment #2)
> 1. Please - separate spec sections other then expressions inside them - e.g.
> with double CR. It's too hard to read spec now.
Well, even if I add one more new line
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Eugene A. Pivnev changed:
What|Removed |Added
CC||ti.eug...@gmail.com
-
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #1 from Mamoru TASAKA ---
http://mtasaka.fedorapeople.org/Review_request/pcmanfm-qt/pcmanfm-qt.spec
http://mtasaka.fedorapeople.org/Review_request/pcmanfm-qt/pcmanfm-qt-0.1.0-2.fc.src.rpm
* Mon Apr 1 2013 Mamoru TASA
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Rex Dieter changed:
What|Removed |Added
CC||rdie...@math.unl.edu
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
Mamoru TASAKA changed:
What|Removed |Added
Blocks||928937 (qt-reviews)
--
30 matches
Mail list logo
