Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Eugene A. Pivnev changed:
What|Removed |Added
Blocks||928937 (qt-reviews)
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Kevin Kofler changed:
What|Removed |Added
CC||ke...@tigcc.ticalc.org
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Sandro Mani changed:
What|Removed |Added
Status|NEW |ASSIGNED
C
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #1 from Sandro Mani ---
Full review below. Main points:
- Also call desktop-file-validate on qterminal_drop.desktop
- Download URL does not work? As a possibility, how I handled the github url
for python-pillow: [1]
-
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #2 from Sandro Mani ---
Oh, I forgot: I've never seen %make_install. There is some reference to
%makeinstall in the guidelines but it is discouraged. How different is
%make_install to make install DESTDIR=%{buildroot}
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #3 from Eugene A. Pivnev ---
(In reply to comment #1)
> Full review below. Main points:
> - Also call desktop-file-validate on qterminal_drop.desktop
Oops... Will be fixed, Thanks
> - Download URL does not work? As a
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #4 from Sandro Mani ---
Uhm? I only mentioned python-pillow to show an example of github urls which
actually work, i.e. the part
--
# Refer to the comment for Source0 below on how to obtain the source tarball
#
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Kalev Lember changed:
What|Removed |Added
CC||kalevlem...@gmail.com
---
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #6 from Sandro Mani ---
Thanks kalev.
(For the github guidelines: the URL did indeed change shortly after the
guidelines were approved, see [1], so the guideline won't work anymore I'm
afraid)
[1] https://bugzilla.re
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #7 from Sandro Mani ---
I've opened a ticket concerning the GitHub guidelines:
https://fedorahosted.org/fpc/ticket/284
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #8 from Eugene A. Pivnev ---
(In reply to comment #7)
> I've opened a ticket concerning the GitHub guidelines:
> https://fedorahosted.org/fpc/ticket/284
Das ist fantastisch!
Spec URL: http://tieugene.fedorapeople.org
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #9 from Sandro Mani ---
Since the project has no tags, you want:
Source0:
https://github.com/qterminal/qterminal/tarball/%{commit}/%{name}-%{name}-%{version}-%{shortcommit}.tar.gz
and you can remove %ahead.
And you
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #10 from Kevin Kofler ---
Don't the guidelines say you should just spell out:
make install DESTDIR=%{buildroot}
?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #11 from Eugene A. Pivnev ---
(In reply to comment #10)
> Don't the guidelines say you should just spell out:
> make install DESTDIR=%{buildroot}
> ?
This is the same as %make_install
--
You are receiving this mail
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #12 from Eugene A. Pivnev ---
(In reply to comment #9)
> Source0:
> https://github.com/qterminal/qterminal/tarball/%{commit}/%{name}-%{name}-
> %{version}-%{shortcommit}.tar.gz
Yes, works too.
> And you forgot the se
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Sandro Mani changed:
What|Removed |Added
Flags|fedora-review? |
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Eugene A. Pivnev changed:
What|Removed |Added
Flags||fedora-cvs?
--- Comme
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |
Flags|
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #15 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XBvYlsSdrB&a=
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #16 from Fedora Update System ---
qterminal-0.4.0-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/qterminal-0.4.0-3.fc18
--
You are receiving this mail because:
You are o
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
--- Comment #17 from Fedora Update System ---
qterminal-0.4.0-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qterminal-0.4.0-3.fc19
--
You are receiving this mail because:
You are o
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED|ON_QA
--- Comment
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Fixed In
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960194
Fedora Update System changed:
What|Removed |Added
Fixed In Version|qterminal-0.4.0-3.fc19 |qterminal-0.4.0-3.
24 matches
Mail list logo
