[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-08-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 Mario Blättermann changed: What|Removed |Added CC|package-review@lists.fedora | |project.org

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-06-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 Mario Blättermann changed: What|Removed |Added Blocks||656997 (kde-reviews) -- You are rec

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-06-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 Kevin Kofler changed: What|Removed |Added CC||ke...@tigcc.ticalc.org Alias

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #1 from Dridi Boukelmoune --- Hi, During my review I've found issues that look like blockers. > MUST: rpmlint must be run on the source rpm and all binary rpms the build > produces. The output should be posted in the review.[1] $

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #2 from Dridi Boukelmoune --- To build successfully with mock: BuildRequires: jpackage-utils -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cg

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #3 from Christopher Meng --- 1. Well, not all times I can replace the COPYING, especially I cannot get permission of upstream. But such error is not blocker. Changed to GPLv2+. 2. I will suggest RPM adding iconsdir macro into mai

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #4 from Dridi Boukelmoune --- (In reply to Christopher Meng from comment #3) > 1. Well, not all times I can replace the COPYING, especially I cannot get > permission of upstream. > > But such error is not blocker. > > Changed to G

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #5 from Christopher Meng --- If you are a packager, just approve it. From your fasname dridi and varnish mod review, I think that you are not sponsored yet. I think you need to find a sponsor for your packages, and then let the s

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-08-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #6 from Kevin Kofler --- Replacing COPYING is usually a bad idea, we're not supposed to mess with upstream COPYING files in any way. (In fact, we aren't even supposed to add them if upstream forgot them entirely.) -- You are recei

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-08-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #7 from Kevin Kofler --- Oh, and for desktop-file-install, the rule is that you must run EITHER desktop-file-install OR desktop-file-validate on each *.desktop file, both do the same validations (and there's an unwritten rule that f

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-08-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 Dridi Boukelmoune changed: What|Removed |Added Flags||fedora-review+ -- You are receivi

[Bug 972860] Review Request: abakus - The simple KDE calculator

2013-08-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #8 from Dridi Boukelmoune --- @Kevin, thanks for the explanations. As I said to Christopher, maybe this should be clarified in the wiki for desktop noobs like me. @Christopher, looks like I'm allowed to change the flag since kevin'