[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel changed: What|Removed |Added Flags||fedora-cvs? ---

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #21 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ --

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #19 from Jens Petersen --- http://benboeckel.net/packaging/ghc-pretty-show/ghc-pretty-show.spec is version 1.5! Anyway please go ahead with the SCM request... :) -- You are receiving this mail because: You

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #18 from Ben Boeckel --- Hmm. It seems I have uploaded the new spec file? The srpm should be there as well? -- You are receiving this mail because: You are always notified about changes to this product and

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #17 from Ben Boeckel --- Hrm. The upload is done by a script. I'll have to look into why it is acting weird. -- You are receiving this mail because: You are always notified about changes to this product and

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #16 from Jens Petersen --- You forgot to upload the new spec file, which confuses fedora-review. You have an extra copy of LICENSE in %doc: please drop that when importing. For that you need to add "rm

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #15 from Ben Boeckel maths...@gmail.com --- Spec URL: http://benboeckel.net/packaging/ghc-pretty-show/ghc-pretty-show.spec SRPM URL: http://benboeckel.net/packaging/ghc-pretty-show/ghc-pretty-show-1.6.8.2-1.fc24.src.rpm -- You are

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #14 from Jens Petersen peter...@redhat.com --- Oh two more points occurred to me: - BR for jquery is actually redundant I think - It might be more stable to change the symlinks to jquery/1 rather than jquery/1.11? (I dunno how

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added Whiteboard|NotReady| -- You are

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flags||fedora-review+ ---

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #13 from Jens Petersen peter...@redhat.com --- Created attachment 998655 -- https://bugzilla.redhat.com/attachment.cgi?id=998655action=edit pretty-show-datadir-style.patch Please apply this patch to fix the jquery location when

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #12 from Jens Petersen peter...@redhat.com --- I tried installing the package into rawhide and f21 to check also on the symlinks warning - seems to be a rpmlint bug afaict. However while checking that I noticed that the datadir

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #10 from Ben Boeckel maths...@gmail.com --- Spec URL: http://mathstuf.fedorapeople.org//ghc-pretty-show.spec SRPM URL: http://mathstuf.fedorapeople.org//ghc-pretty-show-1.6.8.1-1.fc23.src.rpm -- You are receiving this mail

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #9 from Jens Petersen peter...@redhat.com --- Other than above comments here is the fedora-review output: Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === -

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #8 from Jens Petersen peter...@redhat.com --- Thanks for the update. The jquery approach looks good to me. I think jquery-src.js is not needed at runtime so you could probably drop that symlink. I know it is kind of nitpicking,

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #7 from Ben Boeckel maths...@gmail.com --- Spec URL: http://mathstuf.fedorapeople.org//ghc-pretty-show.spec SRPM URL: http://mathstuf.fedorapeople.org//ghc-pretty-show-1.6.8-1.fc23.src.rpm Scratch:

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel maths...@gmail.com changed: What|Removed |Added Flags|needinfo?(maths...@gmail.co | |m)

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel maths...@gmail.com changed: What|Removed |Added Blocks||1142913 Referenced

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Bug 974725 depends on bug 1078371, which changed state. Bug 1078371 Summary: Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers https://bugzilla.redhat.com/show_bug.cgi?id=1078371

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #6 from Jens Petersen peter...@redhat.com --- ping? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #5 from Jens Petersen peter...@redhat.com --- How about remove jquery from now from the package until it is packaged? This is need for updating hledger which currently blocks ghc-7.8. -- You are receiving this mail because: You

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added CC||maths...@gmail.com

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Depends On|857992 |

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Depends On||1078371

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Bug 974725 depends on bug 857992, which changed state. Bug 857992 Summary: Review Request: JQuery - Fast, concise library that simplifies how you use JavaScript https://bugzilla.redhat.com/show_bug.cgi?id=857992 What|Removed

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added Whiteboard||NotReady -- You

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora |

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added CC|

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #4 from Jens Petersen peter...@redhat.com --- But jquery is not packaged yet it seems: bug 857992. So perhaps it could be waived for now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel maths...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora |

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived `Show` instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added Whiteboard||Ready -- You are

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request:

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added Whiteboard|Ready | --- Comment #1

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived `Show` instances and generic inspection of values

https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel maths...@gmail.com changed: What|Removed |Added CC|