https://bugzilla.redhat.com/show_bug.cgi?id=994474
Miroslav Suchý msu...@redhat.com changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=994474
Christopher Meng i...@cicku.me changed:
What|Removed |Added
Status|NEW |CLOSED
https://bugzilla.redhat.com/show_bug.cgi?id=994474
Christopher Meng i...@cicku.me changed:
What|Removed |Added
CC||mh+fed...@scrit.ch
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #26 from Michael Schwendt bugs.mich...@gmx.net ---
Package Review
Filling in all the '[ ]' items in that review would have been interesting.
The beginning of the file mentions that. ;-)
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #24 from Marcel Haerry mh+fed...@scrit.ch ---
Attached is the review. I probably need now a sponsor?
--
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #25 from Marcel Haerry mh+fed...@scrit.ch ---
Created attachment 830693
-- https://bugzilla.redhat.com/attachment.cgi?id=830693action=edit
Package Review
--
You are receiving this mail because:
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #23 from Marcel Haerry mh+fed...@scrit.ch ---
Doh, good catch. I misunderstood the multi-python guidelines in the wiki. Moved
it down to the python3 section and it looks better now:
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #20 from Marcel Haerry mh+fed...@scrit.ch ---
Sorry, it took me a while to come back to this work.
But I integrated all the patches. Added python3 support and have done a
test-build against F21.
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #21 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Requires
python3-qrencode (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libpthread.so.0()(64bit)
libpython3.3m.so.1.0()(64bit)
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #22 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Oh, it should be enough to move the Requires: python3-pillow to the proper
place.
--
You are receiving this mail because:
You are always notified about changes to this
https://bugzilla.redhat.com/show_bug.cgi?id=994474
Marcel Haerry mh+fed...@scrit.ch changed:
What|Removed |Added
CC|package-review@lists.fedora |
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #10 from Michael Schwendt bugs.mich...@gmx.net ---
Spec URL:
http://git.scrit.ch/srpm/python-qrencode/plain/SPECS/python-qrencode.spec
SRPM URL: http://scrit.ch/assets/python-qrencode-1.01-1.fc19.src.rpm
Let's see also what
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #11 from Michael Schwendt bugs.mich...@gmx.net ---
And indeed, the %attr usage is enough distraction to miss a packaging mistake,
which I would spot easily under normal circumstances:
%attr(0755, -, -)
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #7 from Marcel Haerry mh+fed...@scrit.ch ---
It should instead by part of the python package, called
'qrencode._qr_encode' (or something like that), and live in
/usr/lib64/python2.7/site-packages/qrencode/qr_encode.so.
Ok, I
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #8 from Michael Schwendt bugs.mich...@gmx.net ---
That's not what private library means. It's not only about the path within
the Python modules dir.
Private refers to a shared lib that is specific/local to your package (and
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #9 from Marcel Haerry mh+fed...@scrit.ch ---
As far as I understood qr_encode.so is an internal library
that should not be advertised as being provided by the package.
However, it does not do that in my opinion:
That's what
https://bugzilla.redhat.com/show_bug.cgi?id=994474
Marcel Haerry mh+fed...@scrit.ch changed:
What|Removed |Added
Blocks||177841
https://bugzilla.redhat.com/show_bug.cgi?id=994474
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #2 from Marcel Haerry mh+fed...@scrit.ch ---
(In reply to Christopher Meng from comment #1)
1. Remove
%defattr(-, root, root)
done. Will push new spec file once I solved the other issues.
2. Filter out the private library.
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #3 from Marcel Haerry mh+fed...@scrit.ch ---
I pushed the changes to the spec file and uploaded the new srpm.
However, it's not clear to me which private library you mean, so I couldn't
work on excluding it.
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #4 from Michael Schwendt bugs.mich...@gmx.net ---
$ rpmls -p python-qrencode-1.01-1.fc20.x86_64.rpm
(!) -rwxr-xr-x /usr/lib64/python2.7/site-packages/qr_encode.so
drwxr-xr-x /usr/lib64/python2.7/site-packages/qrencode
https://bugzilla.redhat.com/show_bug.cgi?id=994474
--- Comment #5 from Marcel Haerry mh+fed...@scrit.ch ---
(In reply to Michael Schwendt from comment #4)
$ rpmls -p python-qrencode-1.01-1.fc20.x86_64.rpm
(!) -rwxr-xr-x /usr/lib64/python2.7/site-packages/qr_encode.so
Sorry, I'm not
https://bugzilla.redhat.com/show_bug.cgi?id=994474
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
CC|
23 matches
Mail list logo