-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi again,

        while testing "expire_mode=session" in inline mode [*] I saw in
"checkup.pm" this fragment of code:
- ---------------------
[...]
    # make sure that expire_mode session is disabled in VLAN isolation
    if (lc($Config{'registration'}{'expire_mode'}) eq 'session') {
        add_problem( $FATAL,
            "automatic node expiration mode
".$Config{'registration'}{'expire_mode'} . " " .
            "is incompatible with current PacketFence release. Please
file a ticket if you need this feature."
        );
    }
[...]
- ---------------------

As the comment clearly refers to "VLAN isolation" mode, it seems to me
that expire_mode=session _CAN_ be applied in "inline mode".

If this is true, the "if" condition need to be updated as it doesn't
specify neither VLAN-isolation nor inline mode, actually denying
expire_mode _also_ in inline mode.

I've replaced:

   if (lc($Config{'registration'}{'expire_mode'}) eq 'session') {

with

    if ((lc($Config{'registration'}{'expire_mode'}) eq 'session') and
       !(is_inline_enforcement_enabled())) {

and now I'm able to continue my testing with expire_mode=session, in
inline mode.

Comments and suggestions are more than welcome.

HTH.

Bye,
DV


[*] packetfence-3.6.0-1.el6 on a CentOS 6.3

- -- 
Damiano Verzulli
e-mail: dami...@verzulli.it
- ---
possible?ok:while(!possible){open_mindedness++}
- ---
"Technical people tend to fall into two categories: Specialists
and Generalists. The Specialist learns more and more about a
narrower and narrower field, until he eventually, in the limit,
knows everything about nothing. The Generalist learns less and
less about a wider and wider field, until eventually he knows
nothing about everything." - William Stucke - AfrISPA
  http://elists.isoc.org/mailman/private/pubsoft/2007-December/001935.html
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlDr6TYACgkQcwT9fsMT4SyCHwCeOM8Ca5qigcBlUFeia/BE9xPM
rzsAnjW8DHOZti440ZAOVQ0xo/JfmZo2
=Ug3H
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512
_______________________________________________
PacketFence-users mailing list
PacketFence-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/packetfence-users

Reply via email to