Re: [pacman-dev] [PATCH] makepkg : refactor run_build and run_package

2009-08-28 Thread Allan McRae
Xavier Chantry wrote: These two functions were very similar. Signed-off-by: Xavier Chantry Signed-off. Allan

Re: [pacman-dev] [PATCH] makepkg: exit on error during build() or package()

2009-08-28 Thread Allan McRae
Henning Garus wrote: Set the ERR trap to abort upon encountering an error during the execution of a build or package function. Activate set -E, which lets functions inherit the ERR trap. Signed-off-by: Henning Garus Did a lot of testing here and everything appears awesome. Signed-off and

Re: [pacman-dev] [PATCH] add support for .so dependencies

2009-08-28 Thread Florian Pritz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thomas Bächler wrote: > Allan McRae schrieb: >> Thomas Bächler wrote: >>> I want to explicitly ask you about the cons for this feature. What do >>> you think is a hard reason NOT to do it? >> >> 1) The depends array in the PKGBUILD no longer represen

Re: [pacman-dev] [PATCH] '-Spp and -Supp' options were added to generate uri list without the downloaded package uris

2009-08-28 Thread Nagy Gabor
+ if ((config->op_s_printuris >= 2) && !alpm_pkg_download_size(pkg)) { + continue; +} This means that -Sp prints everything, -Spp prints only the to-be-download URIs. This is good for backward compatibility, but for my taste -Sp should print only the to-be-download URIs, and -Spp all. (I

Re: [pacman-dev] [PATCH] '-Spp and -Supp' options were added to generate uri list without the downloaded package uris

2009-08-28 Thread Laszlo Papp
On Fri, Aug 28, 2009 at 11:34 AM, Nagy Gabor wrote: > + if ((config->op_s_printuris >= 2) && !alpm_pkg_download_size(pkg)) { >> + continue; >> +} >> > > This means that -Sp prints everything, -Spp prints only the to-be-download > URIs. This is good for backward compatibility, but for my tas

Re: [pacman-dev] [PATCH] '-Spp and -Supp' options were added to generate uri list without the downloaded package uris

2009-08-28 Thread Nagy Gabor
+ if ((config->op_s_printuris >= 2) && !alpm_pkg_download_size(pkg)) { + continue; +} This means that -Sp prints everything, -Spp prints only the to-be-download URIs. This is good for backward compatibility, but for my taste -Sp should print only the to-be-download URIs, and -Spp all.