[pacman-dev] BUG and PATCH: 'handle' not null after alpm_release()

2010-01-19 Thread Markus Meissner
Hi pacman dev list, I am the guy behind pyalpmm and I found a not so small bug in libalpm. As I wrote some unit-tests for pyalpmm I needed to open and close a libalpm-session multiple times without restarting the calling application. Something like that: 1. alpm_initialize(); 2. /** do some

Re: [pacman-dev] BUG and PATCH: 'handle' not null after alpm_release()

2010-01-19 Thread Xavier Chantry
On Tue, Jan 19, 2010 at 12:37 PM, Markus Meissner mar...@evigo.net wrote: Hi pacman dev list, I am the guy behind pyalpmm and I found a not so small bug in libalpm. As I wrote some unit-tests for pyalpmm I needed to open and close a libalpm-session multiple times without restarting the

Re: [pacman-dev] BUG and PATCH: 'handle' not null after alpm_release()

2010-01-19 Thread Dan McGee
On Tue, Jan 19, 2010 at 7:09 AM, Markus Meissner mar...@evigo.net wrote: On 01/19/2010 01:34 PM, Xavier Chantry wrote: On Tue, Jan 19, 2010 at 12:37 PM, Markus Meissner mar...@evigo.net wrote: But I couldn't do this, because the alpm_initialize() call in line 4 always threw an error (errno:

Re: [pacman-dev] BUG and PATCH: 'handle' not null after alpm_release()

2010-01-19 Thread Markus Meissner
On 01/19/2010 03:01 PM, Dan McGee wrote: On Tue, Jan 19, 2010 at 7:09 AM, Markus Meissner mar...@evigo.net wrote: On 01/19/2010 01:34 PM, Xavier Chantry wrote: On Tue, Jan 19, 2010 at 12:37 PM, Markus Meissner mar...@evigo.net wrote: But I couldn't do this, because the alpm_initialize() call

[pacman-dev] [PATCH] makepkg: [Idea] Introduce $SRCPKGDEST

2010-01-19 Thread Nezmer
Introduce $SRCPKGDEST to define a destination dir for source packages instead of saving them in $PKGDEST with binary packages. The simple patch doesn't break old behavior. Signed-off-by: Nezmer g...@nezmer.info --- etc/makepkg.conf.in |2 ++ scripts/makepkg.sh.in |7 +-- 2 files

[pacman-dev] [PATCH] Print there is nothing to do with NOOP transactions

2010-01-19 Thread Nagy Gabor
The local database is up to date message has been replaced with there is nothing to do message. This used with empty -S, -R, -U operations too. (Examples: pacman -S ignored_pkg, pacman -Ru needed_pkg.) See FS#17859. Signed-off-by: Nagy Gabor ng...@bibl.u-szeged.hu --- src/pacman/remove.c |

Re: [pacman-dev] [PATCH] makepkg: [Idea] Introduce $SRCPKGDEST

2010-01-19 Thread Allan McRae
Nezmer wrote: Introduce $SRCPKGDEST to define a destination dir for source packages instead of saving them in $PKGDEST with binary packages. The simple patch doesn't break old behavior. Signed-off-by: Nezmer g...@nezmer.info --- etc/makepkg.conf.in |2 ++ scripts/makepkg.sh.in |7

Re: [pacman-dev] [PATCH] makepkg: [Idea] Introduce $SRCPKGDEST

2010-01-19 Thread Dan McGee
On Tue, Jan 19, 2010 at 9:15 PM, Allan McRae al...@archlinux.org wrote: Nezmer wrote: Introduce $SRCPKGDEST to define a destination dir for source packages instead of saving them in $PKGDEST with binary packages. The simple patch doesn't break old behavior. Signed-off-by: Nezmer

[pacman-dev] [GIT] The official pacman repository branch, maint, updated. v3.3.3-5-g8b3f5f0

2010-01-19 Thread Dan McGee
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project The official pacman repository. The branch, maint has been updated via 8b3f5f0ce6dca98ca14cc48f5a85188313769b40 (commit) via

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.3.3-121-g0eadc99

2010-01-19 Thread Dan McGee
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project The official pacman repository. The branch, master has been updated via 0eadc992400aaad58da5866d23caee01a22e1341 (commit) via

Re: [pacman-dev] [PATCH] Show used/freed space when syncing

2010-01-19 Thread Dan McGee
On Sun, Jan 10, 2010 at 8:44 PM, Hugo Chargois hugo.charg...@free.fr wrote: On Mon, Jan 11, 2010 at 2:02 AM, Allan McRae al...@archlinux.org wrote: Please do not top post. I can not see a mention of the FR in the new patch you sent.  Did you just resend the old one? But getting to more a

Re: [pacman-dev] [PATCH] zsh_completion: Add proper completion for --ignore and --ignoregroup (v2)

2010-01-19 Thread Dan McGee
On Tue, Dec 15, 2009 at 1:11 PM, Nezmer nez...@allurelinux.org wrote: This patch provides proper comma-separated completions for --ignore and --ignoregroup Signed-off-by: Nezmer nez...@allurelinux.org --- Is this the one I should be looking at? I *hate* patch resubmits without explanation,

[pacman-dev] [PATCH] Remove setgid bit on srcdir/pkgdir creation

2010-01-19 Thread Dan McGee
It was noted in FS#17533 that setgid bits are carried down into any created subdirectories, and thus could end up being in a built package if the original package directory was marked g+s. When we create src/ and pkg/, explicitly chmod them to remove any sticky bits. Signed-off-by: Dan McGee

[pacman-dev] [PATCH] [bash_completion] Undeclared local vars/filenames with spaces/other

2010-01-19 Thread Andres Perera
Fix: 3 Undeclared local vars with common enough names to warrant breakage Performance issues with _pacman trying to replicate /usr/bin/pacman with find and other slow tools. Performance issues with expanding an array (with sometimes hundreds of items) over three times. Expanding said array to

Re: [pacman-dev] [PATCH] Remove setgid bit on srcdir/pkgdir creation

2010-01-19 Thread Dan McGee
On Tue, Jan 19, 2010 at 11:25 PM, Dan McGee d...@archlinux.org wrote: It was noted in FS#17533 that setgid bits are carried down into any created subdirectories, and thus could end up being in a built package if the original package directory was marked g+s. When we create src/ and pkg/,

Re: [pacman-dev] [PATCH] [bash_completion] Undeclared local vars/filenames with spaces/other

2010-01-19 Thread Dan McGee
On Tue, Jan 19, 2010 at 11:26 PM, Andres Perera andres...@gmail.com wrote: Fix: 3 Undeclared local vars with common enough names to warrant breakage Performance issues with _pacman trying to replicate /usr/bin/pacman with find and other slow tools. Performance issues with expanding an array

Re: [pacman-dev] [PATCH] [bash_completion] Undeclared local vars/filenames with spaces/other

2010-01-19 Thread Andres Perera
On Wed, Jan 20, 2010 at 1:07 AM, Dan McGee dpmc...@gmail.com wrote: Is this strictly necessary? You are changing one piece of code in the entire codebase to require v3 or later and as weird as it sounds, I am not going to let that fly. I won't be merging this unless it is v2 or you give some

Re: [pacman-dev] [PATCH] Remove setgid bit on srcdir/pkgdir creation

2010-01-19 Thread Allan McRae
Dan McGee wrote: On Tue, Jan 19, 2010 at 11:25 PM, Dan McGee d...@archlinux.org wrote: It was noted in FS#17533 that setgid bits are carried down into any created subdirectories, and thus could end up being in a built package if the original package directory was marked g+s. When we create src/

Re: [pacman-dev] [PATCH] Remove setgid bit on srcdir/pkgdir creation

2010-01-19 Thread Dan McGee
On Tue, Jan 19, 2010 at 11:51 PM, Allan McRae al...@archlinux.org wrote: Dan McGee wrote: On Tue, Jan 19, 2010 at 11:25 PM, Dan McGee d...@archlinux.org wrote: It was noted in FS#17533 that setgid bits are carried down into any created subdirectories, and thus could end up being in a built

Re: [pacman-dev] [PATCH] [bash_completion] Undeclared local vars/filenames with spaces/other

2010-01-19 Thread Dan McGee
On Tue, Jan 19, 2010 at 11:48 PM, Andres Perera andres...@gmail.com wrote: On Wed, Jan 20, 2010 at 1:07 AM, Dan McGee dpmc...@gmail.com wrote: Is this strictly necessary? You are changing one piece of code in the entire codebase to require v3 or later and as weird as it sounds, I am not going

Re: [pacman-dev] [PATCH] Remove setgid bit on srcdir/pkgdir creation

2010-01-19 Thread Allan McRae
Dan McGee wrote: On Tue, Jan 19, 2010 at 11:51 PM, Allan McRae al...@archlinux.org wrote: Dan McGee wrote: On Tue, Jan 19, 2010 at 11:25 PM, Dan McGee d...@archlinux.org wrote: It was noted in FS#17533 that setgid bits are carried down into any created subdirectories, and thus could end up

Re: [pacman-dev] [PATCH] [bash_completion] Undeclared local vars/filenames with spaces/other

2010-01-19 Thread Andres Perera
Uh, I broke the spaces with git's 72 textwidth. Same patch attached... diff --git a/contrib/bash_completion b/contrib/bash_completion index 62e5bc9..218321a 100644 --- a/contrib/bash_completion +++ b/contrib/bash_completion @@ -1,365 +1,234 @@ -# vim: set ft=sh ts=2 sw=2 et: -# file: