Re: [pacman-dev] [PATCH] fix for incorrect checking of return code, which causes syntax errors

2010-05-16 Thread Allan McRae
On 16/05/10 21:07, Dieter Plaetinck wrote: On Sun, 16 May 2010 10:13:46 +1000 Allan McRaeal...@archlinux.org wrote: You should commit patches with -s so that you get the signoff line. aye! but i wonder what the relevancy of the signoff is. does it just mean i tested it and approve this

Re: [pacman-dev] [PATCH] fix for incorrect checking of return code, which causes syntax errors

2010-05-16 Thread Xavier Chantry
On Sun, May 16, 2010 at 1:16 PM, Allan McRae al...@archlinux.org wrote: On 16/05/10 21:07, Dieter Plaetinck wrote: On Sun, 16 May 2010 10:13:46 +1000 Allan McRaeal...@archlinux.org  wrote: You should commit patches with -s so that you get the signoff line. aye! but i wonder what the

Re: [pacman-dev] [PATCH] redirect scriptlet stderr through alpm

2010-05-16 Thread Xavier Chantry
On Sat, May 15, 2010 at 5:41 PM, Jonathan Conder j...@skurvy.no-ip.org wrote: Fixes FS#18770, and hopefully an occasional deadlock in my frontend as well. This introduces a new EVENT: PM_TRANS_EVT_SCRIPTLET_ERROR, and moves all scriptlet-related callbacks into the parent process. I modelled

Re: [pacman-dev] [PATCH 2/2] ensure package download sizes are invalidated when an error occurs

2010-05-16 Thread Nagy Gabor
Signed-off-by: Jonathan Conder j...@skurvy.no-ip.org --- lib/libalpm/sync.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index d9f4c28..9e140dc 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@

Re: [pacman-dev] [PATCH 2/2] ensure package download sizes are invalidated when an error occurs

2010-05-16 Thread Jonathan Conder
Hi On Sun, 2010-05-16 at 14:54 +0200, Nagy Gabor wrote: The spirit of this patch is better, but it is still not perfect, because of the -Sw (PM_TRANS_FLAG_DOWNLOADONLY) case. That return(0) can also be changed to goto error, and I can see one more RET_ERR in the function. See my other patch

Re: [pacman-dev] [PATCH] redirect scriptlet stderr through alpm

2010-05-16 Thread Jonathan Conder
On Sun, 2010-05-16 at 14:02 +0200, Xavier Chantry wrote: It sounds fine to distinguish both and might be the cleanest solution, but I have two questions : 1) Do applications (in particular the ones used in scriptlets) have a consistent usage of stdout and stderr ? 2) How would frontend

Re: [pacman-dev] [PATCH] redirect scriptlet stderr through alpm

2010-05-16 Thread Xavier Chantry
On Sun, May 16, 2010 at 10:39 PM, Jonathan Conder j...@skurvy.no-ip.org wrote: Maybe you're right, and it would probably make sense if someone wanted to write a log of pacman output, they could use instead of . However, Allan seemed to imply that this wasn't the best solution, although I

Re: [pacman-dev] [PATCH 2/2] ensure package download sizes are invalidated when an error occurs

2010-05-16 Thread Nagy Gabor
Hi On Sun, 2010-05-16 at 14:54 +0200, Nagy Gabor wrote: The spirit of this patch is better, but it is still not perfect, because of the -Sw (PM_TRANS_FLAG_DOWNLOADONLY) case. That return(0) can also be changed to goto error, and I can see one more RET_ERR in the function. See my other

[pacman-dev] [PATCH] Partial fix for the phonon/qt issue

2010-05-16 Thread Nagy Gabor
This patch fixes the phonon/qt issue, if all to-be-upgraded packages are explicit targets (ie. only not-yet-installed packages are pulled by resolvedeps). This condition covers the most common situations, for example it should hold with every -Su operation. After this patch sync405.py passes, but

Re: [pacman-dev] [PATCH] redirect scriptlet stderr through alpm

2010-05-16 Thread Jonathan Conder
On Mon, 2010-05-17 at 00:50 +0200, Xavier Chantry wrote: I am pretty sure there was no hidden meaning in what Allan wrote, i.e. no preference for the simple or the complex solution. Just that even for simple solutions, it's always nice to have patches :) Ok, in that case I suggest combining

Re: [pacman-dev] [PATCH 2/2] ensure package download sizes are invalidated when an error occurs

2010-05-16 Thread Jonathan Conder
On Mon, 2010-05-17 at 01:17 +0200, Nagy Gabor wrote: Yes, I agree, it would be nice to refactor our download code. Then we could do this unset stuff in a more clever way. In addition, we could finally drop this ugly PM_TRANS_FLAG_DOWNLOADONLY flag, and allow the front-end to do the