Re: [pacman-dev] [PATCH] bash_completion: remove upstream deprecated functions

2010-10-14 Thread Dan McGee
On Tue, Oct 12, 2010 at 11:46 PM, Carlos Diaz 839...@gmail.com wrote: Populate $cur and $prev with the new bash-completion 1.2 function, _get_comp_words_by_ref. Hmm. So if this was just added, do we figure most people would have upgraded? I don't want to switch to something if Arch is the only

Re: [pacman-dev] [PATCH] bash_completion: remove upstream deprecated functions

2010-10-14 Thread Allan McRae
On 14/10/10 16:13, Dan McGee wrote: On Tue, Oct 12, 2010 at 11:46 PM, Carlos Diaz839...@gmail.com wrote: Populate $cur and $prev with the new bash-completion 1.2 function, _get_comp_words_by_ref. Hmm. So if this was just added, do we figure most people would have upgraded? I don't want to

[pacman-dev] [PATCH] Sort short options before long options in --help

2010-10-14 Thread Xavier Chantry
$ pacman -Uh options: -b, --dbpath path set an alternate database location -d, --nodeps skip dependency checks -f, --force force install, overwrite conflicting files -k, --dbonly only modify database entries, not package files -r, --root pathset an alternate

[pacman-dev] [PATCH 1/3] add 4 pactests for -Sdd

2010-10-14 Thread Xavier Chantry
Signed-off-by: Xavier Chantry chantry.xav...@gmail.com --- test/pacman/tests/sync-sdd1.py | 18 ++ test/pacman/tests/sync-sdd2.py | 15 +++ test/pacman/tests/sync-sdd3.py | 15 +++ test/pacman/tests/sync-sdd4.py | 17 + 4 files

[pacman-dev] [PATCH 3/3] add -dd option

2010-10-14 Thread Xavier Chantry
From: Florian Pritz bluew...@xssn.at -dd ignores only the version of a dependency being checked, but not the package itself. Signed-off-by: Florian Pritz bluew...@xssn.at Signed-off-by: Xavier Chantry chantry.xav...@gmail.com --- doc/pacman.8.txt |1 + src/pacman/pacman.c

Re: [pacman-dev] [PATCH] Sort short options before long options in --help

2010-10-14 Thread Nagy Gabor
$ pacman -Uh options: -b, --dbpath path set an alternate database location -d, --nodeps skip dependency checks -f, --force force install, overwrite conflicting files -k, --dbonly only modify database entries, not package files -r, --root pathset an

Re: [pacman-dev] [PATCH] Sort short options before long options in --help

2010-10-14 Thread Xavier Chantry
On Thu, Oct 14, 2010 at 1:55 PM, Nagy Gabor ng...@bibl.u-szeged.hu wrote: I like this. Cool :) +     /* First skip all spaces in both strings */ +     while(isspace((unsigned char)*s1)) +             s1++; +     while(isspace((unsigned char)*s2)) +             s2++; +     /* If we

[pacman-dev] [PATCH] Sort short options before long options in --help

2010-10-14 Thread Xavier Chantry
$ pacman -Uh options: -b, --dbpath path set an alternate database location -d, --nodeps skip dependency checks -f, --force force install, overwrite conflicting files -k, --dbonly only modify database entries, not package files -r, --root pathset an alternate

Re: [pacman-dev] [PATCH] Sort short options before long options in --help

2010-10-14 Thread Dan McGee
On Thu, Oct 14, 2010 at 8:36 AM, Xavier Chantry chantry.xav...@gmail.com wrote: diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 7d51124..38d7f6a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -26,8 +26,10 @@  #define PACKAGE_VERSION GIT_VERSION  #endif

[pacman-dev] [PATCH 1/3] Add --with-bsdtar-bin configure option

2010-10-14 Thread Nezmer
This will enable us to use a custom name and/or location of bsdtar binary in scripts. Signed-off-by: Nezmer g...@nezmer.info --- configure.ac |6 ++ contrib/Makefile.am |1 + contrib/bacman.in |4 ++-- contrib/pacscripts.in |4

[pacman-dev] [PATCH 2/3] Add --with-libarchive-prefix configure option

2010-10-14 Thread Nezmer
This will allow us to build against libarchive wherever It is installed in the system. Signed-off-by: Nezmer g...@nezmer.info --- configure.ac | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 50d4a04..a12adb1 100644 ---

[pacman-dev] [PATCH 3/3] Print the values of the new variables at the end of ./configure

2010-10-14 Thread Nezmer
Fix white space issues while at it. Signed-off-by: Nezmer g...@nezmer.info --- configure.ac |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index a12adb1..312b975 100644 --- a/configure.ac +++ b/configure.ac @@ -398,10 +398,13 @@

Re: [pacman-dev] [PATCH 2/3] Add --with-libarchive-prefix configure option

2010-10-14 Thread Dan McGee
On Thu, Oct 14, 2010 at 8:56 AM, Nezmer g...@nezmer.info wrote: This will allow us to build against libarchive wherever It is installed in the system. Signed-off-by: Nezmer g...@nezmer.info Why not just do things like this? Less hassle for us to maintain, we don't do this for any other

Re: [pacman-dev] [PATCH 2/3] Add --with-libarchive-prefix configure option

2010-10-14 Thread Dan McGee
On Thu, Oct 14, 2010 at 9:24 AM, Nezmer g...@nezmer.info wrote: On Thu, Oct 14, 2010 at 09:05:45AM -0500, Dan McGee wrote: On Thu, Oct 14, 2010 at 8:56 AM, Nezmer g...@nezmer.info wrote: This will allow us to build against libarchive wherever It is installed in the system. Signed-off-by:

Re: [pacman-dev] [PATCH] Sort short options before long options in --help

2010-10-14 Thread Xavier Chantry
On Thu, Oct 14, 2010 at 3:44 PM, Dan McGee dpmc...@gmail.com wrote: Is the assert stuff you added to be safer? We don't want to use this. One, they are compiled into nothing if NDEBUG is defined, and two, it is a bit silly to abort on this condition. cmp(NULL, NULL) ==0, and then just decide

[pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Carlos Diaz
In some systems, such as Freebsd, the base tput isn't linked against a terminfo capable ncurses. This means that there's no portable way to set color, so instead of guessing, makepkg fallbacks on using legacy termcap output manipulation. For reference, see terminfo(5) and termcap(5) for a

[pacman-dev] [PATCH 2/3] makepkg: use portable escape sequence for terminal escapes

2010-10-14 Thread Carlos Diaz
The escape string isn't necesarily \033; it's determined by what the particular termcap/info entry for that terminal contains. Bash uses ncurses functions to expand \e to the _correct_ terminal escape. Signed-off-by: Carlos Diaz 839...@gmail.com --- scripts/makepkg.sh.in | 12 ++-- 1

Re: [pacman-dev] [PATCH 2/3] makepkg: use portable escape sequence for terminal escapes

2010-10-14 Thread Dan McGee
On Thu, Oct 14, 2010 at 11:32 AM, Carlos Diaz 839...@gmail.com wrote: The escape string isn't necesarily \033; it's determined by what the particular termcap/info entry for that terminal contains. Bash uses ncurses functions to expand \e to the _correct_ terminal escape. Signed-off-by:

Re: [pacman-dev] [PATCH 2/3] makepkg: use portable escape sequence for terminal escapes

2010-10-14 Thread Andres Perera
On Thu, Oct 14, 2010 at 12:08 PM, Dan McGee dpmc...@gmail.com wrote: On Thu, Oct 14, 2010 at 11:32 AM, Carlos Diaz 839...@gmail.com wrote: The escape string isn't necesarily \033; it's determined by what the particular termcap/info entry for that terminal contains. Bash uses ncurses functions

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Nezmer
On Thu, Oct 14, 2010 at 12:02:45PM -0430, Carlos Diaz wrote: In some systems, such as Freebsd, the base tput isn't linked against a terminfo capable ncurses. This means that there's no portable way to set color, so instead of guessing, makepkg fallbacks on using legacy termcap output

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Andres Perera
On Thu, Oct 14, 2010 at 12:19 PM, Nezmer g...@nezmer.info wrote: This is already fixed in master! Err, this was done against master 2010-10-13 23:42 de5f438aef1 And what as I read from [1], you're still using terminfo capability names and hardcoded shell escapes. 1:

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Andres Perera
On Thu, Oct 14, 2010 at 12:41 PM, Nezmer g...@nezmer.info wrote: If you're running FreeBSD. The default $TERM in ttyvint is cons25(1) and it can handle the colours just fine. So I don't know how the hard-coded list is relevant. (1) I heard this vintage default will change soon. There's

Re: [pacman-dev] [PATCH] Read 'force' entry from packages

2010-10-14 Thread Xavier Chantry
On Tue, Oct 12, 2010 at 12:51 AM, Dan McGee d...@archlinux.org wrote: We weren't reading this in from our packages, thus causing us not to write it out to our local database. Adding this now will help ease the upgrade path for epoch later and not require reinstallation of all force packages.

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Nezmer
Sent this to Andres, forwarding... - Forwarded message from Nezmer g...@nezmer.info - Date: Thu, 14 Oct 2010 20:34:15 +0300 From: Nezmer g...@nezmer.info To: Andres Perera andre...@zoho.com Subject: Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Andres Perera
On Thu, Oct 14, 2010 at 1:09 PM, Nezmer g...@nezmer.info wrote: Sent this to Andres, forwarding... - Forwarded message from Nezmer g...@nezmer.info - Date: Thu, 14 Oct 2010 20:34:15 +0300 From: Nezmer g...@nezmer.info To: Andres Perera andre...@zoho.com Subject: Re: [pacman-dev]

Re: [pacman-dev] [PATCH] Read 'force' entry from packages

2010-10-14 Thread Xavier Chantry
On Thu, Oct 14, 2010 at 8:48 PM, Xavier Chantry chantry.xav...@gmail.com wrote: On Tue, Oct 12, 2010 at 12:51 AM, Dan McGee d...@archlinux.org wrote: We weren't reading this in from our packages, thus causing us not to write it out to our local database. Adding this now will help ease the

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Nezmer
On Thu, Oct 14, 2010 at 02:55:54PM -0430, Andres Perera wrote: On Thu, Oct 14, 2010 at 1:09 PM, Nezmer g...@nezmer.info wrote: Sent this to Andres, forwarding... - Forwarded message from Nezmer g...@nezmer.info - Date: Thu, 14 Oct 2010 20:34:15 +0300 From: Nezmer

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Dan McGee
On Thu, Oct 14, 2010 at 3:42 PM, Nezmer g...@nezmer.info wrote: On Thu, Oct 14, 2010 at 02:55:54PM -0430, Andres Perera wrote: On Thu, Oct 14, 2010 at 1:09 PM, Nezmer g...@nezmer.info wrote: Sent this to Andres, forwarding... - Forwarded message from Nezmer g...@nezmer.info -

Re: [pacman-dev] [PATCH 1/3] Add --with-bsdtar-bin configure option

2010-10-14 Thread Nezmer
On Thu, Oct 14, 2010 at 04:56:17PM +0300, Nezmer wrote: This will enable us to use a custom name and/or location of bsdtar binary in scripts. Signed-off-by: Nezmer g...@nezmer.info --- configure.ac |6 ++ contrib/Makefile.am |1 + contrib/bacman.in

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Andres Perera
On Thu, Oct 14, 2010 at 4:15 PM, Dan McGee dpmc...@gmail.com wrote: And in any case at all, do people actually *need* color? I'm thinking not and that patching some of this stuff might just be adding complexity for very little benefit. Finally someone considers this route. There's a good

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Andres Perera
On Thu, Oct 14, 2010 at 4:15 PM, Dan McGee dpmc...@gmail.com wrote: And in any case at all, do people actually *need* color? I'm thinking not and that patching some of this stuff might just be adding complexity for very little benefit. Finally someone considers this route. There's a good

Re: [pacman-dev] [PATCH 1/3] makepkg: fallback to legacy termcap capabilities

2010-10-14 Thread Andres Perera
On Thu, Oct 14, 2010 at 4:12 PM, Nezmer g...@nezmer.info wrote: Let me ask a simple question: Is there a real-life example where this patch would be beneficial to me as user? Is there someone who would like to run the next version of pacman on a 10 or 15 year old term definition? cons25 is

Re: [pacman-dev] [PATCH] Read 'force' entry from packages

2010-10-14 Thread Dan McGee
On Thu, Oct 14, 2010 at 3:39 PM, Xavier Chantry chantry.xav...@gmail.com wrote: On Thu, Oct 14, 2010 at 8:48 PM, Xavier Chantry chantry.xav...@gmail.com wrote: On Tue, Oct 12, 2010 at 12:51 AM, Dan McGee d...@archlinux.org wrote: We weren't reading this in from our packages, thus causing us