Re: [pacman-dev] License for new contributions?

2011-02-28 Thread Allan McRae
On 28/02/11 17:52, edmeiste...@hushmail.com wrote: On Sat, 26 Feb 2011 13:55:27 -0400 Xavier Chantry wrote: On Sat, Feb 26, 2011 at 6:42 PM, wrote: Hello pacman team! I've been following development for quite some time, and would like to submit my package signing patches for review. Out

Re: [pacman-dev] License for new contributions?

2011-02-28 Thread Dan McGee
On Mon, Feb 28, 2011 at 3:44 AM, Allan McRae wrote: > On 28/02/11 17:52, edmeiste...@hushmail.com wrote: >> >> On Sat, 26 Feb 2011 13:55:27 -0400 Xavier Chantry >>  wrote: >>> >>> On Sat, Feb 26, 2011 at 6:42 PM, >>> wrote: Hello pacman team! I've been following development fo

Re: [pacman-dev] [PATCH 1/6] A couple of minor manpage adjustments

2011-02-28 Thread Jakob Gruber
Dan and Xavier, thanks for the reviews. Sending the changes as replies + they are also up at https://github.com/schuay/pacman-arch/commits/working On 02/25/2011 03:30 PM, Dan McGee wrote: On Mon, Feb 21, 2011 at 1:02 PM, Jakob Gruber wrote: Signed-off-by: Jakob Gruber --- doc/pacman.8.txt

Re: [pacman-dev] [PATCH 2/6] Add utility functions to convert sizes to strings

2011-02-28 Thread Jakob Gruber
On 02/25/2011 03:51 PM, Dan McGee wrote: On Mon, Feb 21, 2011 at 1:02 PM, Jakob Gruber wrote: char *size_to_human_string(off_t bytes); char *size_to_human_string_short(off_t bytes); Scale to the first unit with which the value will be less or equal to 2048. size_to_human_string_short uses shor

Re: [pacman-dev] [PATCH 4/6] Refactor display_targets for readability

2011-02-28 Thread Jakob Gruber
On 02/25/2011 03:57 PM, Dan McGee wrote: On Mon, Feb 21, 2011 at 1:02 PM, Jakob Gruber wrote: Row handling is moved to its own function in preparation for verbose package lists. Signed-off-by: Jakob Gruber --- src/pacman/util.c | 53 - 1

Re: [pacman-dev] [PATCH 5/6] Table formatted output functions

2011-02-28 Thread Jakob Gruber
On 02/25/2011 04:21 PM, Dan McGee wrote: I had a real hard time following all this, but that might just be the morning brain not working well. Your reuse of curformat->data as first a immutable string holder and later a alloced format string holder is particularly hard to wrap the brain around un

Re: [pacman-dev] [PATCH 6/6] New VerbosePkgLists option

2011-02-28 Thread Jakob Gruber
On 02/25/2011 04:30 PM, Dan McGee wrote: On Mon, Feb 21, 2011 at 1:02 PM, Jakob Gruber wrote: If enabled, displays package lists for upgrade, sync and remove operations formatted as a table. Falls back to default list display if insufficient terminal columns are available. Example output (-Su)

Re: [pacman-dev] [PATCH] WIP: check local DB version

2011-02-28 Thread Dan McGee
On Sun, Feb 27, 2011 at 10:02 PM, Allan McRae wrote: > On 28/02/11 05:55, Dan McGee wrote: >> >> --- >> Any feedback on this going in? One of the checklist items on my 3.5.0 >> release >> list. >> > > It works  but notice the double print of the found file there: Turns out to be because we ca

[pacman-dev] [PATCH 1/6] A couple of minor manpage adjustments

2011-02-28 Thread Jakob Gruber
Signed-off-by: Jakob Gruber --- doc/pacman.8.txt | 45 - 1 files changed, 20 insertions(+), 25 deletions(-) diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt index 8a94ebc..7a13b89 100644 --- a/doc/pacman.8.txt +++ b/doc/pacman.8.txt @@ -173,15 +173,1

[pacman-dev] [PATCH 2/6] Add a utility function to humanize sizes

2011-02-28 Thread Jakob Gruber
Converts the given size in bytes in two possible ways: 1) target_unit is specified (!= 0): size is converted to target unit. 2) target_unit is not specified (== 0): size is converted to the first unit which will bring size to below 2048. If specified, label will point to the long label ('MB') i

[pacman-dev] [PATCH 3/6] --print-format displays size in bytes

2011-02-28 Thread Jakob Gruber
Printing the exact size seems to make more sense for scripting contexts. Signed-off-by: Jakob Gruber --- src/pacman/util.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/pacman/util.c b/src/pacman/util.c index ba93963..23b95c9 100644 --- a/src/pacman/util.c +++ b/s

[pacman-dev] [PATCH 4/6] Refactor display_targets for readability

2011-02-28 Thread Jakob Gruber
Row handling is moved to its own function in preparation for verbose package lists. Signed-off-by: Jakob Gruber --- src/pacman/util.c | 48 ++-- 1 files changed, 26 insertions(+), 22 deletions(-) diff --git a/src/pacman/util.c b/src/pacman/util.c in

[pacman-dev] [PATCH 5/6] Table formatted output functions

2011-02-28 Thread Jakob Gruber
table_display takes a list of lists of strings (representing the table cells) and displays them formatted as a table. The exact format depends on the longest string in each column. Signed-off-by: Jakob Gruber --- src/pacman/util.c | 110 + src

[pacman-dev] [PATCH 6/6] New VerbosePkgLists option

2011-02-28 Thread Jakob Gruber
If enabled, displays package lists for upgrade, sync and remove operations formatted as a table. Falls back to default list display if insufficient terminal columns are available. Example output: :: Starting full system upgrade... :: Replace libjpeg with testing/libjpeg-turbo? [Y/n] resolving dep

[pacman-dev] [GIT] The official pacman repository branch, maint, updated. v3.4.3-6-g23451e7

2011-02-28 Thread Dan McGee
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, maint has been updated via 23451e7fa4302092153b4c760561d0f134b4077a (commit) via

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.4.3-373-gaafb387

2011-02-28 Thread Dan McGee
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via aafb3874558b03e0d3720f35e27ca43f2ac735d6 (commit) vi

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.4.3-374-g07538b9

2011-02-28 Thread Dan McGee
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 07538b948a0198808dcbe68bf838e520eb341fb3 (commit) fro

[pacman-dev] [GIT] The official pacman repository branch, maint, updated. v3.4.3-374-g07538b9

2011-02-28 Thread Dan McGee
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, maint has been updated via 07538b948a0198808dcbe68bf838e520eb341fb3 (commit) via

[pacman-dev] [translation] Let's start the work for 3.5.0 release

2011-02-28 Thread Dan McGee
We're using transifex this time around, and going cold turkey, so I won't even look at translations submitted here. http://projects.archlinux.org/pacman.git/tree/doc/translation-help.txt The transifex help and the tx client will likely be your friend here. `tx pull` and `tx push -t -l en_GB` were

[pacman-dev] [PATCH] alpm: improve installing messages on warning/errors

2011-02-28 Thread Boris 'billiob' Faure
Hi, I have attached a patch to change a little bit what messages are printed when creating a ".pacnew" file. Regards -- Boris 'billiob' Faure From 96ed99092eb7487351f746c0588313d7354eefb7 Mon Sep 17 00:00:00 2001 From: Boris 'billiob' Faure Date: Mon, 28 Feb 2011 11:33:13 +0100 Subject: [PATCH]

Re: [pacman-dev] [PATCH] alpm: improve installing messages on warning/errors

2011-02-28 Thread Dan McGee
On Mon, Feb 28, 2011 at 12:35 PM, Boris 'billiob' Faure wrote: > Hi, > > I have attached a patch to change a little bit what messages are > printed when creating a ".pacnew" file. Inline patches (using git send-email if necessary) please. -Dan

Re: [pacman-dev] [translation] Let's start the work for 3.5.0 release

2011-02-28 Thread matthias
On Mon, 28 Feb 2011 11:33:17 -0600, Dan McGee wrote: > We're using transifex this time around, and going cold turkey, so I > won't even look at translations submitted here. > > http://projects.archlinux.org/pacman.git/tree/doc/translation-help.txt > > The transifex help and the tx client will lik

Re: [pacman-dev] [translation] Let's start the work for 3.5.0 release

2011-02-28 Thread Dan McGee
On Mon, Feb 28, 2011 at 1:19 PM, wrote: > On Mon, 28 Feb 2011 11:33:17 -0600, Dan McGee wrote: >> We're using transifex this time around, and going cold turkey, so I >> won't even look at translations submitted here. >> >> http://projects.archlinux.org/pacman.git/tree/doc/translation-help.txt >>

[pacman-dev] [PATCH] alpm: improve installing messages on warning/errors

2011-02-28 Thread Boris 'billiob' Faure
--- lib/libalpm/add.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index 702b12e..db5ee74 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -401,14 +401,14 @@ static int extract_single_file(struct archive *archive,

Re: [pacman-dev] [PATCH 2/2] Document API changes for pacman-3.5 release

2011-02-28 Thread Rémy Oudompheng
Would you approve documenting in alpm.h the type of elements in lists returned by libalpm functions ? They do not look obvious at all for someone that is not familiar with the internals of libalpm. -- Rémy.

Re: [pacman-dev] [PATCH 2/2] Document API changes for pacman-3.5 release

2011-02-28 Thread Dan McGee
On Mon, Feb 28, 2011 at 4:02 PM, Rémy Oudompheng wrote: > Would you approve documenting in alpm.h the type of elements in lists > returned by libalpm functions ? They do not look obvious at all for > someone that is not familiar with the internals of libalpm. Definitely. If you can do it in Doxyg

Re: [pacman-dev] [translation] Let's start the work for 3.5.0 release

2011-02-28 Thread Xavier Chantry
On Mon, Feb 28, 2011 at 6:33 PM, Dan McGee wrote: > We're using transifex this time around, and going cold turkey, so I > won't even look at translations submitted here. > > http://projects.archlinux.org/pacman.git/tree/doc/translation-help.txt > > The transifex help and the tx client will likely

[pacman-dev] [translation] We have some eerily similar messages, should we fix now or later?

2011-02-28 Thread Dan McGee
Everyone, Xavier and I noticed when walking through the translations tonight that we haven't done the greatest job keep our workload down here. There are a lot of messages that differ by punctuation only, or contain a hardcoded path vs. another one with a '%s', etc. I hacked together a quick scri

[pacman-dev] [PATCH] Fix some easy to find double translations

2011-02-28 Thread Dan McGee
A lot of these were places that should have used the same message but didn't, or were very easy to convert to using the same message and letting some of the burden off of the translators. Signed-off-by: Dan McGee --- lib/libalpm/be_sync.c |2 +- lib/libalpm/po/libalpm.pot | 18 +--

Re: [pacman-dev] [PATCH 2/2] Document API changes for pacman-3.5 release

2011-02-28 Thread Allan McRae
On 28/02/11 05:29, Dan McGee wrote: On Sun, Feb 27, 2011 at 7:35 AM, Allan McRae wrote: Signed-off-by: Allan McRae --- README | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/README b/README index 1276eaa..5da572f 100644 --- a/READM

[pacman-dev] [PATCH] Update NEWS for pacman-3.5 release

2011-02-28 Thread Allan McRae
Signed-off-by: Allan McRae --- NEWS | 47 +++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 4f5ce11..032be53 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,52 @@ VERSION DESCRIPTION --

Re: [pacman-dev] [package signing] repo-add and access to pacman keyring

2011-02-28 Thread Allan McRae
On 19/02/11 12:02, Denis A. Altoé Falqueto wrote: Hi, Well, it seems I'm busy lately, doesn't it? :) I was implementing the first TODO list for repo-add in (see https://wiki.archlinux.org/index.php/User:Allan/Package_Signing) and stuck in a point where I need some opinions on what to do. repo-

Re: [pacman-dev] [PATCH] Update NEWS for pacman-3.5 release

2011-02-28 Thread Allan McRae
On 01/03/11 14:21, Allan McRae wrote: Signed-off-by: Allan McRae --- NEWS | 47 +++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 4f5ce11..032be53 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,52 @@ VERSION D

Re: [pacman-dev] [PATCH 2/2] Document API changes for pacman-3.5 release

2011-02-28 Thread Rémy Oudompheng
On 2011/2/28 Dan McGee wrote: > On Mon, Feb 28, 2011 at 4:02 PM, Rémy Oudompheng > wrote: >> Would you approve documenting in alpm.h the type of elements in lists >> returned by libalpm functions ? They do not look obvious at all for >> someone that is not familiar with the internals of libalpm.