[pacman-dev] [PATCH 4/3] makepkg: fix a GNU-ism in awk usage

2011-04-02 Thread Rémy Oudompheng
A non-GNU version of awk may not support the (|...) syntax for an optional group and require '()' to match an empty string. The (...)? syntax is more appropriate for this usage. Signed-off-by: Rémy Oudompheng r...@archlinux.org --- Problem arises when trying to use makepkg with FreeBSD's awk.

[pacman-dev] [PATCH 1/2] configure.ac: we use fabs now so -lm is needed

2011-04-02 Thread Xavier Chantry
Signed-off-by: Xavier Chantry chantry.xav...@gmail.com --- configure.ac |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 3299302..9fb9cb0 100644 --- a/configure.ac +++ b/configure.ac @@ -131,6 +131,9 @@ AC_PATH_PROGS([BASH_SHELL], [bash

[pacman-dev] [PATCH 2/2] dload: dont forget to initialize open_mode !

2011-04-02 Thread Xavier Chantry
That's a funny one, building with optimization levels (with both gcc and clang) caused open_mode to always be set to ab, which worked. This was spotted both with clang-analyzer, and by Jakob who reported a segfault as he was using an un-optimized build. Maybe we should build with -O0 in debug

[pacman-dev] gnu89-inline

2011-04-02 Thread Xavier Chantry
I am just curious, what do we need this flag for ? I only found this : http://gcc.gnu.org/onlinedocs/gcc/Inline.html GCC implements three different semantics of declaring a function inline. One is available with -std=gnu89 or -fgnu89-inline or when gnu_inline attribute is present on all inline

Re: [pacman-dev] [PATCH 2/2] dload: dont forget to initialize open_mode !

2011-04-02 Thread Dan McGee
On Sat, Apr 2, 2011 at 9:02 AM, Xavier Chantry chantry.xav...@gmail.com wrote: That's a funny one, building with optimization levels (with both gcc and clang) caused open_mode to always be set to ab, which worked. This was spotted both with clang-analyzer, and by Jakob who reported a segfault

Re: [pacman-dev] [PATCH 1/3] Fix compatibility with older versions of libarchive.

2011-04-02 Thread Dan McGee
On Fri, Apr 1, 2011 at 5:35 PM, Rémy Oudompheng remyoudomph...@gmail.com wrote: There is no reason to not support versions of libarchive that lack ARCHIVE_COMPRESSION_UU. Distributions should work properly without this. Signed-off-by: Rémy Oudompheng r...@archlinux.org Thanks, applied to

Re: [pacman-dev] [PATCH 2/3] util.c: include limits.h for PATH_MAX macro

2011-04-02 Thread Dan McGee
On Fri, Apr 1, 2011 at 5:36 PM, Rémy Oudompheng remyoudomph...@gmail.com wrote: Signed-off-by: Rémy Oudompheng r...@archlinux.org Applied to maint. ---  lib/libalpm/util.c |    1 +  1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c index

Re: [pacman-dev] gnu89-inline

2011-04-02 Thread Dan McGee
On Sat, Apr 2, 2011 at 12:17 PM, Xavier Chantry chantry.xav...@gmail.com wrote: I am just curious, what do we need this flag for ? Searching commits, it wasn't too hard to find this, although I don't know the full context or relevance. Not sure if it was just a GCC bug at the time? commit

Re: [pacman-dev] [PATCH 4/3] makepkg: fix a GNU-ism in awk usage

2011-04-02 Thread Dan McGee
On Sat, Apr 2, 2011 at 5:31 AM, Rémy Oudompheng remyoudomph...@gmail.com wrote: A non-GNU version of awk may not support the (|...) syntax for an optional group and require '()' to match an empty string. The (...)? syntax is more appropriate for this usage. Signed-off-by: Rémy Oudompheng

Re: [pacman-dev] gnu89-inline

2011-04-02 Thread Xavier Chantry
On Sat, Apr 2, 2011 at 7:49 PM, Dan McGee dpmc...@gmail.com wrote: On Sat, Apr 2, 2011 at 12:17 PM, Xavier Chantry chantry.xav...@gmail.com wrote: I am just curious, what do we need this flag for ? Searching commits, it wasn't too hard to find this, although I don't know the full context or

Re: [pacman-dev] gnu89-inline

2011-04-02 Thread Dan McGee
On Sat, Apr 2, 2011 at 1:18 PM, Xavier Chantry chantry.xav...@gmail.com wrote: On Sat, Apr 2, 2011 at 7:49 PM, Dan McGee dpmc...@gmail.com wrote: On Sat, Apr 2, 2011 at 12:17 PM, Xavier Chantry chantry.xav...@gmail.com wrote: I am just curious, what do we need this flag for ? Searching

Re: [pacman-dev] [PATCH 3/3] diskspace: add the actually used statfs type in ifdefs

2011-04-02 Thread Dan McGee
On Fri, Apr 1, 2011 at 5:36 PM, Rémy Oudompheng remyoudomph...@gmail.com wrote: Some systems, like FreeBSD might define both statfs and statvfs: however if statvfs exists whereas getmntinfo() uses a statfs struct, the current ifdefs would select the wrong line of code. Signed-off-by: Rémy

[pacman-dev] [PATCH 3/7] libalpm: switch default VerifySig to Optional

2011-04-02 Thread Xavier Chantry
Signed-off-by: Xavier Chantry chantry.xav...@gmail.com --- lib/libalpm/alpm.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index b08191d..81877cc 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -254,8 +254,8 @@ int

[pacman-dev] [PATCH 7/7] pacman/query: correctly handle root files with -Qo

2011-04-02 Thread Xavier Chantry
spotted by clang-analyzer (strcmp with NULL rpath is bad) Signed-off-by: Xavier Chantry chantry.xav...@gmail.com --- src/pacman/query.c | 50 +- 1 files changed, 33 insertions(+), 17 deletions(-) diff --git a/src/pacman/query.c

Re: [pacman-dev] [PATCH 4/3] makepkg: fix a GNU-ism in awk usage

2011-04-02 Thread Allan McRae
On 03/04/11 04:13, Dan McGee wrote: On Sat, Apr 2, 2011 at 5:31 AM, Rémy Oudompheng remyoudomph...@gmail.com wrote: A non-GNU version of awk may not support the (|...) syntax for an optional group and require '()' to match an empty string. The (...)? syntax is more appropriate for this usage.

Re: [pacman-dev] gnu89-inline

2011-04-02 Thread Sebastian Nowicki
On Sun, Apr 3, 2011 at 1:17 AM, Xavier Chantry chantry.xav...@gmail.comwrote: I am just curious, what do we need this flag for ? I only found this : http://gcc.gnu.org/onlinedocs/gcc/Inline.html GCC implements three different semantics of declaring a function inline. One is available with